Commit graph

24055 commits

Author SHA1 Message Date
Hiroyuki Ikezoe
d61a2ff29e Make a macro for timing function. 2017-03-07 13:27:39 +09:00
Hiroyuki Ikezoe
40822f9575 Pass transition-delay and transition-duration into gecko struct. 2017-03-07 13:27:32 +09:00
Hiroyuki Ikezoe
e340d37a9f Modify some macro for animations to be able to use for transition properties as well. 2017-03-07 13:26:48 +09:00
Hiroyuki Ikezoe
96dbc9849d ensure_len() for nsStyleAutoArray<StyleTransition>. 2017-03-07 13:26:03 +09:00
Hiroyuki Ikezoe
e5386ed7aa Update bindgens. 2017-03-07 13:24:01 +09:00
bors-servo
1d497857e8 Auto merge of #15836 - upsuper:animation, r=emilio,bholley
Fix animation shorthand parsing (again)

This is from [bug 1343168](https://bugzilla.mozilla.org/show_bug.cgi?id=1343168) and mostly same as #15793 which was backed out in #15814.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15836)
<!-- Reviewable:end -->
2017-03-06 19:24:01 -08:00
bors-servo
312797fa90 Auto merge of #15797 - sendilkumarn:lang-algo, r=KiChjang
ext. filtering for lang matching

<!-- Please describe your changes on the following line: -->
This adds the extended algorithm to check the lang. This is my very first encounter with`rust`.
Open to learn.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #15746

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15797)
<!-- Reviewable:end -->
2017-03-06 18:55:02 -08:00
SendilKumar N
b6e6e84bcf ext. filtering for lang matching 2017-03-07 10:20:16 +08:00
bors-servo
0dbee36915 Auto merge of #15751 - avinash-vijayaraghavan:testing-csserror, r=cbrewster
first stab. added ServoUrl as a parameter to report_error(...) of Par…

@jdm @SimonSapin
<!-- Please describe your changes on the following line: -->

1. Added ServoUrl as a parameter to report_error(...) of ParseErrorReporter trait.
2. I am not sure how to handle the case of impl ParseErrorReporter for CSSErrorReporter and MemoryHoleReporter, so have not made any changes  (other than adding ServoUrl arg) to report_error implementations for these.
3. In StdoutErrorReporter i have added the ServoUrl arg to the info! function,
4. I would like to know if i am on the correct path and clarify what else needs to be done.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ X] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #15708 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because wanted to clarify before writing tests

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15751)
<!-- Reviewable:end -->
2017-03-06 07:11:51 -08:00
avinash
f48f0567cf Add ServoUrl as a parameter to report_error(...) of ParseErrorReporter
passes test-tidy
removed match and used map

added new test test_report_error_passing_correct_url(...) and modified old unit tests

removed the option for servourl and tidied up

removed the duplicate test.

made a few more changes after @cbrewster suggestions.

changed _url to url in few places

fixed the indenting
2017-03-06 09:06:42 -06:00
Xidorn Quan
cd22bcd506 Treat empty animation entry invalid 2017-03-06 22:01:55 +11:00
Xidorn Quan
97f2ccacbb Parse none as just a normal animation item 2017-03-06 22:01:37 +11:00
Xidorn Quan
6b03760213 Simplify animation shorthand parsing code 2017-03-06 22:01:15 +11:00
Xidorn Quan
bfa847bad7 Allow animation-name to be omitted from shorthand 2017-03-06 22:00:55 +11:00
Xidorn Quan
d2bb111ff2 Add / fix get_initial_specified_value for animation longhands 2017-03-06 22:00:29 +11:00
Xidorn Quan
6273fa0305 Make animation-name parse none 2017-03-06 22:00:04 +11:00
Xidorn Quan
4bc0cac395 Replace assert! in animation code with debug_assert! 2017-03-06 21:58:08 +11:00
bors-servo
c62973b77b Auto merge of #15830 - emilio:cssparserup, r=KiChjang
Update cssparser to get perf improvements for CSSOM setters.

In particular, it it includes https://github.com/servo/rust-cssparser/pull/124

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15830)
<!-- Reviewable:end -->
2017-03-06 00:36:05 -08:00
Emilio Cobos Álvarez
b693ae6bd5
Update cssparser to get perf improvements for CSSOM setters.
In particular, it it includes https://github.com/servo/rust-cssparser/pull/124
2017-03-06 09:24:02 +01:00
bors-servo
511b82eea3 Auto merge of #15465 - austinprete:caret-color, r=Wafflespeanut
Implement parsing/serialization for caret-color

<!-- Please describe your changes on the following line: -->
This pull request implements parsing and serialization for the caret-color CSS property, per issue #15309 .

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #15309

<!-- Either: -->
- [X] There are tests for these changes

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15465)
<!-- Reviewable:end -->
2017-03-05 23:53:26 -08:00
bors-servo
d4bdd33cd9 Auto merge of #15828 - emilio:cleanup-all-day, r=Wafflespeanut
style: Remove unneeded indirection in LonghandsToSerialize.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15828)
<!-- Reviewable:end -->
2017-03-05 23:06:55 -08:00
Emilio Cobos Álvarez
dffba35d83
style: Remove unneeded indirection in LonghandsToSerialize. 2017-03-06 08:04:22 +01:00
bors-servo
5ccf79e055 Auto merge of #15827 - moonlightdrive:use-iflet-not-match, r=mbrubeck
replace match with if let

<!-- Please describe your changes on the following line: -->
Use `if let` instead of a `match` with a single pattern.

I'm not clear if/how this needs to be tested (beyond what's been checked-off below), so please let me know if there's more to do. Thanks!

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #15810

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15827)
<!-- Reviewable:end -->
2017-03-05 19:26:27 -08:00
Jyotsna Prakash
27b60135be replace match with if-let 2017-03-05 17:52:39 -08:00
bors-servo
6b28a18f45 Auto merge of #15826 - glennw:update-wr-viewport, r=KiChjang
Update WR (overscroll support + fix viewport tests).

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15826)
<!-- Reviewable:end -->
2017-03-05 14:23:41 -08:00
Glenn Watson
44fe81da41 Update WR (overscroll support + fix viewport tests). 2017-03-06 08:21:32 +10:00
austinprete
a2074f2653 Implement parsing/serialization for caret-color 2017-03-05 10:52:32 -07:00
bors-servo
72fd27bbcc Auto merge of #15816 - servo:raf-timer, r=jdm,emilio
Improve performance of layout queries and requestAnimationFrame

Part of #14442.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15816)
<!-- Reviewable:end -->
2017-03-05 05:14:45 -08:00
bors-servo
d8a8e3e42e Auto merge of #15230 - UK992:mach-bootstrap, r=aneeshusa
Mach bootstrap: Improve and support more platforms

<!-- Please describe your changes on the following line: -->
r? @aneeshusa or @Wafflespeanut

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15230)
<!-- Reviewable:end -->
2017-03-04 04:47:13 -08:00
bors-servo
8c4931f26f Auto merge of #15702 - shubDhond:master, r=upsuper
Invalid three value positions are no longer accepted

<!-- Please describe your changes on the following line: -->
- Position parse no longer accepts invalid three value positions

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #15488 .

<!-- Either: -->
- [X] There are tests for these changes OR

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15702)
<!-- Reviewable:end -->
2017-03-04 03:11:44 -08:00
bors-servo
78210c3c94 Auto merge of #15817 - Manishearth:xul, r=bholley
Support more XUL properties

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15817)
<!-- Reviewable:end -->
2017-03-03 21:28:49 -08:00
Manish Goregaokar
58d32b284a Support more XUL properties 2017-03-03 17:22:08 -08:00
Patrick Walton
4e7ac19380 script: Use a timer when rAF is used for non-animation purposes
After this patch, when the page calls `requestAnimationFrame()` too many
times in the row without actually mutating the DOM, further calls to
`rAF` will actually perform the moral equivalent of `setTimeout(16)`.
This saves a lot of CPU time compared to actually waiting for the
vertical blanking interval, because waiting for that requires us to draw
the page.

Reduces CPU usage drastically on nytimes.com, which has a perpetual
`requestAnimationFrame()` loop that checks whether ads are in view.
2017-03-03 23:25:29 +01:00
Patrick Walton
198662f8cb layout: Replace ConstructionResult::swap_out() with get()
It only actually swaps out in nonincremental mode (which isn't suitable
for real world use), so the name is confusing.
2017-03-03 23:25:02 +01:00
bors-servo
b4d7ed7351 Auto merge of #15815 - crypto-universe:master, r=KiChjang
Use more idiomatic or_else construction

<!-- Please describe your changes on the following line: -->
or_else in more ideomatic rust construction than
match, where Some(x) => Some(x)
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #15812 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15815)
<!-- Reviewable:end -->
2017-03-03 13:36:40 -08:00
crypto-universe
afd3030af3 Use more idiomatic construction
or_else in more idiomatic rust construction than
match, where Some(x) => Some(x)
2017-03-03 22:35:29 +01:00
bors-servo
3ca6ee2f7f Auto merge of #15814 - bholley:backout_15793, r=bholley
Revert #15793 for crashes and test failures on stylo

Looks like #15793 busted autoland. Given that it's the weekend for Xidorn I'm going to back out the patch.

CC @upsuper
2017-03-03 11:53:52 -08:00
Bobby Holley
3a56899201 Revert "Auto merge of #15793 - upsuper:animation, r=emilio,bholley"
This reverts commit 7cd4c69c40, reversing
changes made to 1b1fadb8b8.
2017-03-03 11:50:15 -08:00
bors-servo
c32181c6db Auto merge of #15809 - emilio:nsstuff, r=emilio
stylo: Backport rust-nsstring crash fixes to the vendored version.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15809)
<!-- Reviewable:end -->
2017-03-03 09:15:15 -08:00
Emilio Cobos Álvarez
feac01f793
stylo: Backport rust-nsstring crash fixes to the vendored version. 2017-03-03 17:33:55 +01:00
bors-servo
1842b2e25e Auto merge of #15808 - servo:moz-user-select, r=nox,SimonSapin
Add remaining keyword values of -moz-user-select (fixes #15197)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15808)
<!-- Reviewable:end -->
2017-03-03 08:17:44 -08:00
Karan Singh
3d5b607ba5 Add remaining keyword values of -moz-user-select (fixes #15197) 2017-03-03 16:13:54 +01:00
bors-servo
5662af9057 Auto merge of #14620 - dpyro:nosniff, r=jdm
Implemented nosniff for fetch algorithm

<!-- Please describe your changes on the following line: -->

Implemented [nosniff](https://fetch.spec.whatwg.org/#should-response-to-request-be-blocked-due-to-nosniff?) for [fetch algorithm](https://fetch.spec.whatwg.org).

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #14521 (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14620)
<!-- Reviewable:end -->
2017-03-03 06:56:30 -08:00
Sumant Manne
8aac575019 Implemented nosniff for fetch algorithm 2017-03-03 15:50:58 +01:00
bors-servo
7cd4c69c40 Auto merge of #15793 - upsuper:animation, r=emilio,bholley
Fix animation shorthand parsing

which is somehow broken after #15779.

But it seems there are various issue around the animation shorthand parsing, so I try to fix it to make it match the spec.

I expect this change to fix most parsing failures in Gecko's test suite, although I haven't tested.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15793)
<!-- Reviewable:end -->
2017-03-03 03:28:21 -08:00
bors-servo
1b1fadb8b8 Auto merge of #15767 - charlesvdv:blob-close, r=nox
Remove support for Blob::{close, isClosed}

<!-- Please describe your changes on the following line: -->

<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #15660

<!-- Either: -->
- [x] There are tests for these changes

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15767)
<!-- Reviewable:end -->
2017-03-03 02:16:51 -08:00
bors-servo
0294a474b8 Auto merge of #15455 - charlesvdv:xhr-process-event, r=KiChjang
Implement XHR progress event changes

<!-- Please describe your changes on the following line: -->

This PR implements change in the specs in XHR.

Unfortunatelly, @jdm the test are not passing. It looks like the fetch module send more bytes that we should according the ```Content-Length```. This [lines](https://github.com/servo/servo/blob/master/tests/wpt/web-platform-tests/XMLHttpRequest/progress-events-response-data-gzip.htm#L70) make the test fail.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #13276  (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15455)
<!-- Reviewable:end -->
2017-03-03 01:05:11 -08:00
Charles Vandevoorde
e215cdbc5e update test metadata 2017-03-03 09:55:42 +01:00
Xidorn Quan
53027723ae Parse none as just a normal animation item 2017-03-03 16:12:11 +11:00
Xidorn Quan
1bb1eeeb53 Simplify animation shorthand parsing code 2017-03-03 16:12:09 +11:00