Glenn Watson
2a2c7e18c0
Set detail field to be 1 by default for mouse events.
...
The spec says this should be "A count of consecutive clicks that happened in a short amount of time, incremented by one."
This change matches the typical behaviour in FF.
2015-07-22 08:17:57 +10:00
bors-servo
406be7accf
Auto merge of #6690 - Ms2ger:display-getters, r=pcwalton
...
Cleanup the get_*_display methods.
2015-07-21 15:20:12 -06:00
Ms2ger
94e1d4d34c
Don't call mutate_layout_data in get_{before,after}_pseudo.
...
We don't mutate anything.
2015-07-21 22:58:16 +02:00
Till Schneidereit
126938a963
Address review comments
2015-07-21 22:56:26 +02:00
Ms2ger
093204a224
Replace get_{before,after}_display by get_{before,after}_pseudo.
2015-07-21 22:27:40 +02:00
Ms2ger
2e6a723970
Merge has_{before,after}_pseudo into get_{before,after}_display.
2015-07-21 22:27:38 +02:00
Ms2ger
cc356e58ae
Remove unused ThreadSafeLayoutNode::get_normal_display.
2015-07-21 22:27:36 +02:00
bors-servo
b1c4862119
Auto merge of #6657 - Ms2ger:ThreadSafeLayoutNodeChildrenIterator, r=pcwalton
...
Cleanup ThreadSafeLayoutNodeChildrenIterator.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6657 )
<!-- Reviewable:end -->
2015-07-21 13:38:33 -06:00
Manish Goregaokar
fda3eb6327
Make struct part of unrooted_must_root handle type parameters
2015-07-22 00:01:26 +05:30
Manish Goregaokar
511e3337fb
Fix rooting in script
2015-07-22 00:00:15 +05:30
Manish Goregaokar
f6f0a7e4aa
Make stmt part of unrooted_must_root handle type parameters ( fixes #6651 )
2015-07-22 00:00:14 +05:30
Ms2ger
930e111713
Scope ThreadSafeLayoutNode::first_child to ThreadSafeLayoutNodeChildrenIterator::new.
...
It is only used there.
2015-07-21 19:53:34 +02:00
Ms2ger
b3892b74f7
Simplify ThreadSafeLayoutNodeChildrenIterator::next().
2015-07-21 19:53:23 +02:00
bors-servo
a9f12da4f8
Auto merge of #6592 - frewsxcv:notimplementederror, r=Ms2ger
...
Use NotImplementedError for Python base class methods
From the Python docs:
https://docs.python.org/2/library/exceptions.html#exceptions.NotImplementedError
"In user defined base classes, abstract methods should raise this
exception when they require derived classes to override the method."
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6592 )
<!-- Reviewable:end -->
2015-07-21 11:28:21 -06:00
bors-servo
126f5ae8f0
Auto merge of #6681 - jdm:atomicopts, r=SimonSapin
...
Make the global options more resilient to unit tests running in paral…
…lel.
This should allow #6490 to land, since it's hitting problems with unit tests that create a resource task and therefore race on calling opts::get().
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6681 )
<!-- Reviewable:end -->
2015-07-21 07:17:47 -06:00
Josh Matthews
fecb2e3960
Make the global options more resilient to unit tests running in parallel.
2015-07-21 09:14:06 -04:00
bors-servo
cb52cc6658
Auto merge of #6608 - nnethercote:tweak-reporter-registration, r=glennw
...
Register/unregister memory reporters in a better place.
By doing this on either side of the call to the relevant tasks' start()
method, we don't need to store the mem::ProfilerChan or the reporter
name in the task itself.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6608 )
<!-- Reviewable:end -->
2015-07-20 21:43:09 -06:00
bors-servo
faa180c972
Auto merge of #6678 - glennw:gleam0.1.4, r=pcwalton
...
Update to gleam 0.1.4
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6678 )
<!-- Reviewable:end -->
2015-07-20 18:27:06 -06:00
Nicholas Nethercote
f6525b8009
Register/unregister memory reporters in a better place.
...
By doing this on either side of the call to the relevant tasks' start()
method, we don't need to store the mem::ProfilerChan or the reporter
name in the task itself.
2015-07-20 16:19:51 -07:00
bors-servo
5ac80bff8e
Auto merge of #6666 - glennw:exit-flag, r=larsbergstrom
...
Restore exit after load command line flag.
Also updates glutin with a crash fix that was exposed by this patch.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6666 )
<!-- Reviewable:end -->
2015-07-20 15:37:33 -06:00
Glenn Watson
12a2573e51
Update to gleam 0.1.4
2015-07-21 07:22:46 +10:00
bors-servo
58e9bc6583
Auto merge of #6648 - boghison:tidytoml, r=jdm
...
Make tidy check for "*" in toml files
This checks every .toml file for an asterisk and prints an error if found.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6648 )
<!-- Reviewable:end -->
2015-07-20 14:43:05 -06:00
Bogdan Cuza
0baa6b477c
Replace astersisks with appropriate versions in deps
2015-07-20 20:08:08 +03:00
Bogdan Cuza
75e14e80cd
Fix #6623 and update toml.py
2015-07-20 19:47:35 +03:00
bors-servo
20d8c275d7
Auto merge of #6675 - saneyuki:trap, r=Ms2ger
...
Implement Window.trap() to trigger a breakpoint trap
Fix #6673
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6675 )
<!-- Reviewable:end -->
2015-07-20 10:20:57 -06:00
Tetsuharu OHZEKI
eb47185d58
Implement Window.trap() to trigger a breakpoint trap
2015-07-21 00:53:17 +09:00
bors-servo
3a5e4335d7
Auto merge of #6671 - Ms2ger:browser-context, r=jdm
...
Renaming browser context to browsing context.
That's what the spec calls it.
2015-07-20 02:00:30 -06:00
Ms2ger
6d7bc2cffe
Rename browser_context identifiers to browsing_context.
2015-07-20 15:56:32 +02:00
Ms2ger
7491728a9c
Rename BrowserContext to BrowsingContext.
2015-07-20 15:41:16 +02:00
bors-servo
a432b14e68
Auto merge of #6669 - Ms2ger:println, r=metajack
...
Remove leftover debug println.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6669 )
<!-- Reviewable:end -->
2015-07-19 23:17:46 -06:00
Ms2ger
9a143bb67e
Remove leftover debug println.
2015-07-20 13:12:20 +02:00
bors-servo
685a44e1f5
Auto merge of #6668 - servo:untruncated-docs, r=Ms2ger
...
Make doc comments not truncated again.
`rustdoc --passes "collapse-docs unindent-comments"` doesn’t work is intended. It still generate HTML files that look alright at a glance, but all doc-comments are truncated to their first line for some reason I don’t understand.
See http://doc.servo.org/script/dom/index.html for example. The module documentation there is currently just “The implementation of the DOM.”, but clicking the [src] link shows a much larger doc-comment.
The correct invocation is to use `--passes` multiple times.
https://github.com/rust-lang/rust/issues/15347#issuecomment-122785714
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6668 )
<!-- Reviewable:end -->
2015-07-19 19:32:41 -06:00
Simon Sapin
bf2dfaf60e
Make doc comments not truncated again.
...
`rustdoc --passes "collapse-docs unindent-comments"` doesn’t work is intended.
It still generate HTML files that look alright at a glance,
but all doc-comments are truncated to their first line
for some reason I don’t understand.
See http://doc.servo.org/script/dom/index.html for example.
The module documentation there is currently just
“The implementation of the DOM.”, but clicking the [src] link
shows a much larger doc-comment.
https://github.com/rust-lang/rust/issues/15347#issuecomment-122785714
The correct invokation is to use `--passes` multiple times.
2015-07-20 09:30:31 +02:00
Glenn Watson
4f28c93f40
Restore exit after load command line flag.
...
Also updates glutin with a crash fix that was exposed by this patch.
2015-07-20 11:19:13 +10:00
bors-servo
93a0c29ad4
Auto merge of #6392 - jgraham:webdriver_get_url_refresh, r=jdm
...
Implement support for Get URL and Refresh in WebDriver server.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6392 )
<!-- Reviewable:end -->
2015-07-19 15:03:36 -06:00
James Graham
f44470ef52
Ensure we get the post-redirect url
2015-07-19 20:40:55 +01:00
James Graham
2a701cc339
Fixup rebase issues
2015-07-19 20:40:12 +01:00
Till Schneidereit
317d2ac547
Add display: none test
2015-07-19 18:59:54 +02:00
Till Schneidereit
162ecd0aac
Implement client{Top, Left, Height, Width} element properties
2015-07-19 15:04:50 +02:00
James Graham
512ba50315
Add some more WebDriver capabilities from the spec.
2015-07-19 13:01:09 +01:00
James Graham
f28219b8cb
Implement WebDriver Refresh command
2015-07-19 13:01:08 +01:00
James Graham
9eade19897
Add support for the Get URL WebDriver command.
2015-07-19 12:55:06 +01:00
bors-servo
2f4bdc6ad6
Auto merge of #6593 - pcwalton:constellation-ipc, r=jdm
...
compositing: Make the constellation messages serializable.
Same idea as before. This depends on:
* https://github.com/servo/euclid/pull/94
* https://github.com/hyperium/hyper/pull/603
r? @jdm
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6593 )
<!-- Reviewable:end -->
2015-07-18 07:43:24 -06:00
Patrick Walton
b6485a9eaf
compositing: Make the constellation messages serializable.
2015-07-18 12:43:08 -07:00
bors-servo
a0cf597946
Auto merge of #6625 - dzbarsky:range-clonecontents, r=Ms2ger
...
Implement Range#cloneContents
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6625 )
<!-- Reviewable:end -->
2015-07-18 02:42:29 -06:00
bors-servo
e6538c0f2d
Auto merge of #6650 - Ms2ger:layout-cleanup, r=jdm
...
Various layout cleanup.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6650 )
<!-- Reviewable:end -->
2015-07-17 09:17:41 -06:00
bors-servo
a24783df4b
Auto merge of #6655 - servo:rustdoc-private, r=Manishearth
...
Include private items in `./mach doc` and http://doc.servo.org/
See https://github.com/rust-lang/rust/issues/15347
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6655 )
<!-- Reviewable:end -->
2015-07-17 08:40:27 -06:00
Simon Sapin
c85bfe1350
Include private items in ./mach doc
and http://doc.servo.org/
...
See https://github.com/rust-lang/rust/issues/15347
2015-07-17 22:31:57 +02:00
Ms2ger
5d36fbca29
Reduce the amount of code in the unsafe block in ParallelPostorderFlowTraversal::run_parallel.
2015-07-17 14:52:00 +02:00
Ms2ger
46b36242a3
Use Ref::map to make ThreadSafeLayoutNode::style safe.
2015-07-17 14:51:58 +02:00