Commit graph

37647 commits

Author SHA1 Message Date
bors-servo
e2441b27bb
Auto merge of #23694 - saschanaz:rotate-fix, r=Manishearth
Fix DOMMatrix rotate test failure

<!-- Please describe your changes on the following line: -->

Rotation functions have been working backward because of https://github.com/servo/euclid/issues/354, so this temporarily fixes it.

cc @Manishearth

PS: How can I run bors-servo myself?

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #23688

<!-- Either: -->
- [x] There are tests for these changes OR

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23694)
<!-- Reviewable:end -->
2019-07-03 22:33:22 -04:00
bors-servo
af295bcefe
Auto merge of #23654 - julientregoat:issue-23645, r=jdm
Fix panic when running test-background-fetch-permission.html

<!-- Please describe your changes on the following line: -->
* Propagate `Error::JSFailed` in `Permissions::create_descriptor`
* In `Error::to_jsval`, only check if a JS exception is not pending if `self` is not `Error::JSFailed`

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #23645 (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because it's a test runner, so by nature if the test runs the test runner is also working as expected.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23654)
<!-- Reviewable:end -->
2019-07-03 19:56:29 -04:00
bors-servo
c9d7b4e726
Auto merge of #23701 - servo:jdm-patch-30, r=Manishearth
Don't suppress build errors.

This is a regression from #23676.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23701)
<!-- Reviewable:end -->
2019-07-03 18:05:24 -04:00
Josh Matthews
fc8c428993
Don't suppress build errors. 2019-07-03 15:29:56 -04:00
bors-servo
e382266b22
Auto merge of #23564 - mmiecz:clipboard-refactoring, r=jdm
Clipboard refactoring

<!-- Please describe your changes on the following line: -->
This PR removes clipboard handling from the constellation. Instead, now embedder handles it.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #23440 (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because it is enough to test manually in input box, if copying and pasting still works .

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23564)
<!-- Reviewable:end -->
2019-07-03 15:20:15 -04:00
Michal Mieczkowski
7fb2bbed00 Prefix unused arguments with underscore to prevent warnings 2019-07-03 20:31:20 +02:00
Julien Tregoat
28fcde9e10 Propagate JSFailed error & conditionally execute initial assertion when converting error to JS value. 2019-07-03 13:48:48 -04:00
bors-servo
661170c61c
Auto merge of #23690 - asajeffrey:webxr-script-thread, r=Manishearth
Get a WebXR device registry to each script thread

<!-- Please describe your changes on the following line: -->

This PR gets an XR device registry to each script thread.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because it's all plumbing

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23690)
<!-- Reviewable:end -->
2019-07-03 13:12:14 -04:00
Alan Jeffrey
9eb75d4ea6 Use webxr IPC to get a WebXR device registry to each script thread 2019-07-03 08:53:40 -05:00
bors-servo
fb7aa7ba7c
Auto merge of #23687 - servo-wpt-sync:wpt_update_02-07-2019, r=servo-wpt-sync
Sync WPT with upstream (02-07-2019)

Automated downstream sync of changes from upstream as of 02-07-2019.
[no-wpt-sync]

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23687)
<!-- Reviewable:end -->
2019-07-03 08:47:04 -04:00
Kagami Sascha Rosylight
168d980f9e Fix DOMMatrix rotate test failure 2019-07-03 20:23:52 +09:00
bors-servo
fee1418b43
Auto merge of #23685 - saschanaz:scalenonuniform, r=paulrouget
Add DOMMatrix.prototype.scaleNonUniform

<!-- Please describe your changes on the following line: -->

Implements `scaleNonUniform()` [per the spec](https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-scalenonuniform).

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #23683

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23685)
<!-- Reviewable:end -->
2019-07-03 05:20:14 -04:00
Michał Mieczkowski
775ff3b623 Fix warning about unused result 2019-07-03 10:47:37 +02:00
bors-servo
d08cd5fc1c
Auto merge of #23677 - servo:travis, r=jdm
Move pre-review PR testing from Travis-CI to Taskcluster

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23677)
<!-- Reviewable:end -->
2019-07-03 02:28:24 -04:00
bors-servo
50033878a6
Auto merge of #23676 - servo:check, r=Manishearth
Share more `./mach build` logic with mach check, doc, test-unit

Fixes #23659

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23676)
<!-- Reviewable:end -->
2019-07-02 23:55:44 -04:00
bors-servo
a7ff87f0e9
Auto merge of #23675 - asajeffrey:webxr-initialization, r=Manishearth
WebXR initialization

<!-- Please describe your changes on the following line: -->

Initialize a WebXR device registry in Servo.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because this is hidden plumbing at the moment

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23675)
<!-- Reviewable:end -->
2019-07-02 21:34:49 -04:00
Alan Jeffrey
135ad4a2f4 Use webxr git repo for all webxr dependencies in Cargo.tomls 2019-07-02 18:24:29 -05:00
Alan Jeffrey
91d1b52b38 Initialize a wevxr device registry from Servo 2019-07-02 18:23:56 -05:00
Michal Mieczkowski
1bbe92ff76 Return None instead of panicking 2019-07-02 21:29:45 +02:00
bors-servo
b4ed3b6f3c
Auto merge of #23641 - Manishearth:newtest, r=asajeffrey
Update to newest XRTest API

requires https://github.com/servo/rust-webvr/pull/88 and https://github.com/servo/servo/pull/23575

Incorporates changes from https://github.com/immersive-web/webxr-test-api/pull/10 (and various minor improvements on that, like https://github.com/immersive-web/webxr-test-api/pull/20). Test no longer relies on racy state setting functions.

We're nearing consensus on what the test API should look like, thought I'd implement the updated model so I can start poking at the tests.

Fixes https://github.com/servo/servo/issues/23634 by setting everything at initialization.

This is based on https://github.com/servo/servo/pull/23575, so we can't merge it yet.

r? @asajeffrey (only the last commit)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23641)
<!-- Reviewable:end -->
2019-07-02 15:10:14 -04:00
Manish Goregaokar
480a9988d1 Update requiredness of some fields 2019-07-02 10:10:58 -07:00
Simon Sapin
6609b098d6 Add ./mach check to CI 2019-07-02 18:29:24 +02:00
Simon Sapin
7c85dc09b5 Share more ./mach build logic with mach check, doc, test-unit
Fixes #23659
2019-07-02 18:29:24 +02:00
WPT Sync Bot
2f34737d47 Update web-platform-tests to revision 4beda31498f85ded322ea4d55870973000364ac4 2019-07-02 14:19:34 +00:00
Kagami Sascha Rosylight
9218c535d1 add link to the spec 2019-07-02 18:28:17 +09:00
Kagami Sascha Rosylight
ebdb1067ca Add DOMMatrix.prototype.scaleNonUniform 2019-07-02 18:23:39 +09:00
bors-servo
f4ff9e2eeb
Auto merge of #23673 - servo-wpt-sync:wpt_update_01-07-2019, r=servo-wpt-sync
Sync WPT with upstream (01-07-2019)

Automated downstream sync of changes from upstream as of 01-07-2019.
[no-wpt-sync]

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23673)
<!-- Reviewable:end -->
2019-07-02 01:46:28 -04:00
Manish Goregaokar
c19240a454 Update to latest xrtest api 2019-07-01 17:42:46 -07:00
bors-servo
294d701fda
Auto merge of #23665 - saschanaz:parse-transform, r=Manishearth
Support DOMMatrix string constructor

<!-- Please describe your changes on the following line: -->

Implemented DOMMatrix string constructor per [the spec](https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-dommatrixreadonly).

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #23664, fix #23622

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23665)
<!-- Reviewable:end -->
2019-07-01 19:44:33 -04:00
bors-servo
faea7716cf
Auto merge of #23575 - asajeffrey:webvr-glwindow-eventloop, r=Manishearth
Pass events loop to glwindow test webvr implementation

<!-- Please describe your changes on the following line: -->

Pass the event loop to the glwindow webvr test device, so it can implement keyboard controls. The matching rust-webvr PR is https://github.com/servo/rust-webvr/pull/84

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because this enables testing webvr pose

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23575)
<!-- Reviewable:end -->
2019-07-01 18:15:09 -04:00
Simon Sapin
da766d02eb Move pre-review PR testing from Travis-CI to Taskcluster 2019-07-01 21:55:59 +02:00
Michal Mieczkowski
8da643d998 Add stub for set_clipboard_contents and get_clipboard_contents in libsimpleservo jniapi and libmlservo 2019-07-01 19:16:21 +02:00
Michal Mieczkowski
02d55885c8 Handle get_clipboard_contents and set_clipboard_contents in libsimpleservo capi 2019-07-01 19:12:59 +02:00
Simon Sapin
d9dbcd52c3 Remove ./mach cargo.
Not all cargo subcommands take `--manifest-path`.
Use plain `cargo` instead (rustup reads the `rust-toolchain` file)
or consider adding new mach sub-commands.
2019-07-01 19:04:35 +02:00
Alan Jeffrey
1e5e3c95c9 Pass events loop to glwindow test webvr implementation 2019-07-01 11:55:43 -05:00
Simon Sapin
aa5e5596c0 ./mach clean: cwd is unnecessary when --manifest-path is used 2019-07-01 17:43:07 +02:00
Simon Sapin
9110b25d13 Remove ./mach env as it is a lie.
We stopped overriding `$PATH` since using rustup.
The printed variables are not sufficient to do anything.
2019-07-01 16:44:21 +02:00
WPT Sync Bot
81889f5cfd Update web-platform-tests to revision ff6212c69e2519a94fd62d6f1e06dd0dac6152d3 2019-07-01 14:23:53 +00:00
bors-servo
18477d1e1e
Auto merge of #23574 - asajeffrey:glutin-reduce-borrow-duration, r=paulrouget
Don't process events while borrowing the event loop

<!-- Please describe your changes on the following line: -->

At the moment, the glutin embedder holds onto a borrow of the events loop while processing events, which is dangerous if any of the event handlers end up using the events loop reentrantly. (This caused a panic while integrating https://github.com/servo/rust-webvr/pull/84.)

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because this is low-level embedding code

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23574)
<!-- Reviewable:end -->
2019-07-01 10:01:46 -04:00
Alan Jeffrey
f2a64db151 Dead code elimination 2019-07-01 09:00:59 -05:00
Simon Sapin
acd8454b16 Print an error message if neither Canvas 2D backend is selected 2019-07-01 15:46:36 +02:00
Simon Sapin
1df2605292 Rename {azure,raqote}_backend feature flags to canvas2d-{azure,raqote} 2019-07-01 15:46:33 +02:00
Simon Sapin
bddfe9a468 Remove default-except-unstable
… and use remaining unstable features unconditionally.
This doesn’t actually change the set of crates that can build on the Stable channel.
2019-07-01 15:43:24 +02:00
Simon Sapin
d1efad6763 Turns out that SIMD code was not being compiled at all!? 2019-07-01 15:43:24 +02:00
Simon Sapin
5a31ce52d8 Features used by euclid are stable 2019-07-01 14:55:25 +02:00
Simon Sapin
99669b0831 #[global_allocator] is stable 2019-07-01 14:55:01 +02:00
Simon Sapin
eddfe3af83 impl Trait is stable 2019-07-01 14:54:47 +02:00
bors-servo
da168de296
Auto merge of #23662 - atouchet:test, r=jdm
Remove passing test

<!-- Please describe your changes on the following line: -->
This was added in #23310. Was that a mistake?

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23662)
<!-- Reviewable:end -->
2019-06-30 11:10:45 -04:00
bors-servo
3e446ef718
Auto merge of #23667 - saschanaz:msbuild2019, r=jdm
Support VS Build Tools 2019

<!-- Please describe your changes on the following line: -->

This detects VS Build Tools 2019 installation, which optionally provides VC2017 to be compatible with Servo.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #23666

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23667)
<!-- Reviewable:end -->
2019-06-30 08:50:50 -04:00
Kagami Sascha Rosylight
8cd436c892 Support VS Build Tools 2019 2019-06-30 19:12:47 +09:00