Oriol Brufau
e77dc36842
Pick the first or last baseline as appropriate ( #31705 )
...
The old logic was always picking the last baseline, but this should only
happen for inline-blocks.
Since replaced elements and flex containers aren't currently setting
their baselines, this is only an improvement for inline-tables.
2024-03-25 16:19:06 +00:00
Oluwatobi Sofela
a53632c0e5
clippy: Fix collapsible_if warnings ( #31852 )
2024-03-25 13:55:45 +00:00
Rosemary Ajayi
3d10dbae32
clippy: Fix some clippy warnings in components/script ( #31843 )
...
* deref on an immutable reference
* fix deref on an immutable reference
* fix deref on an immutable reference
2024-03-25 12:57:35 +00:00
Bastiaan van der Plaat
97144ddf71
script: Add pre element obsolete width attribute support ( #31792 )
2024-03-25 11:36:48 +00:00
Aarya Khandelwal
bd39e03eeb
changed match to 'matches!' ( #31850 )
2024-03-25 11:28:12 +00:00
eri
9a76dd9325
clippy: Fix remaining warnings in generated code ( #31844 )
...
* clippy: fix warnings in generated code
* clippy: fix wrap_panic closure warnings
2024-03-25 11:12:36 +00:00
Ekta Siwach
d8adeb1b44
clippy: Fix some warnings in components/script ( #31849 )
...
* clippy: fixed some warnings in components/script
* fixed formatting
* fix formatting
2024-03-25 10:22:21 +00:00
Oriol Brufau
dbe3cb8a3c
Don't update row baseline if cell is empty ( #31831 )
...
Gecko, Blink and WebKit agree that the if a row only has empty cells,
its baseline should be at the bottom, not at the top.
There isn't interoperability when the cells are just empty-ish, so this
patch takes the simplest approach, aligning with Blink: any out-of-flow
or in-flow content other than collapsed whitespace counts as not empty.
2024-03-25 09:39:02 +00:00
Mukilan Thiyagarajan
c50df5ccbe
nix build: replace fetchCargoTarball with importCargoLock ( #31825 )
...
[`importCargoLock`][1] allows us to use the existing Cargo.lock
file. This means we no longer need to update the sha256 hash
whenever the dependencies are upgraded. It also integrates
with nix's rustToolchain support via `cargoSetupHooks` and
automatically vendors the dependencies, allowing us to simplify
the logic for `filterlock` derivation.
[1]: https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/rust.section.md#vendoring-of-dependencies-vendoring-of-dependencies
Signed-off-by: Mukilan Thiyagarajan <mukilan@igalia.com>
2024-03-25 05:32:55 +00:00
eri
58081579e9
WebIDL: Remove JSObject from Document::NamedGetter ( #31841 )
...
* WebIDL: Remove `JSObject` from `Document::NamedGetter`
* fix: update rustdoc comment
2024-03-24 18:04:04 +00:00
Oluwatobi Sofela
1ab38fcd3f
clippy: Fix default_constructed_unit_structs warnings in components ( #31827 )
...
* clippy: Fix default constructed unit structs warnings
* refactor: Allow default constructed unit structs to avoid gfx build error
2024-03-24 17:24:34 +00:00
Rosemary Ajayi
0a771169b8
fix redundant closure ( #31842 )
2024-03-23 16:51:41 +00:00
Aarya Khandelwal
566fd475d9
Clippy: Fixed some clippy warnings ( #31818 )
...
* Fixed clippy warnings
* made changes for lowercase characters.
* changed is_lowercase() to is_ascii_lowercase()
* added std library function `is_ascii_uppercase()` and `is_ascii_lowercase()`
* made recommended changes
2024-03-23 12:48:49 +00:00
Oluwatobi Sofela
3c05b58221
clippy: Fix explicit_auto_deref warnings in components/script ( #31837 )
...
* clippy: Fix explicit auto-deref warnings
* clippy: Fix explicit auto-deref warnings
* refactor: Tidy up code
* refactor: Fix method not found errors
2024-03-23 11:29:20 +00:00
atbrakhi
3fc157338e
remove unused code ( #31826 )
2024-03-23 04:25:52 +00:00
dependabot[bot]
e22b61c935
build(deps): bump libz-sys from 1.1.15 to 1.1.16 ( #31829 )
...
Bumps [libz-sys](https://github.com/rust-lang/libz-sys ) from 1.1.15 to 1.1.16.
- [Release notes](https://github.com/rust-lang/libz-sys/releases )
- [Commits](https://github.com/rust-lang/libz-sys/compare/1.1.15...1.1.16 )
---
updated-dependencies:
- dependency-name: libz-sys
dependency-type: indirect
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-03-22 17:08:31 +00:00
cathiechen
cb275e086c
Implement StaticRange ( #31809 )
...
* Add DOM interface for AbstractRange
* Add DOM interface for StaticRange
* Update WPT tests for StaticRange-constructor.html
* Fix formatting
* Add AbstractRange & StaticRange in interfaces.html
* rebased the code and fixed the failures
Signed-off-by: Cathie Chen <cathiechen@igalia.com>
* update the expected result in idlharness.window.js.ini file
* Addressed the code review comments
* updae the test result of legacy layout
---------
Signed-off-by: Cathie Chen <cathiechen@igalia.com>
Co-authored-by: Nipun Garg <nipung271@gmail.com>
2024-03-22 15:02:01 +00:00
Oluwatobi Sofela
bae77671f8
clippy: Fix unnecessary_cast warnings in components/script ( #31823 )
...
* clippy: Fix unnecessary cast warnings
* clippy: Replace redundant field names with their shorthand alternatives
* clippy: Delete struct pattern dereferencings
2024-03-22 13:48:03 +00:00
Tumuhairwe
3e9b808938
Fix some clippy warnings in components/script/webdriver_handlers.rs ( #31784 )
...
* Fixed some clippy warnings in components/script/webdriver_handlers.rs
* Updated fixes for clippy warnings in components/script/webdriver_handlers.rs
* Updated the formatting of components/script/webdriver_handlers.rs
* Updated components/script/webdriver_handler.rs to fix some clippy warnings.
2024-03-22 11:08:07 +00:00
sandeep
77f5175efc
removed mutable compile warnings ( #31822 )
...
Signed-off-by: Sandeep Pillai <sandeeppillai@Sandeeps-MacBook-Air.local>
Co-authored-by: Sandeep Pillai <sandeeppillai@Sandeeps-MacBook-Air.local>
2024-03-22 09:58:27 +00:00
Jonathan Schwender
99bad9d9b8
Bump fontsan version ( #31821 )
...
Fixes a build regression on Nix-OS reported on zulip.
2024-03-22 09:31:52 +00:00
Martin Robinson
34dd38b4cb
Replace remutex with parking_lot's ReentrantMutex ( #31817 )
...
Many things in Servo depend on `parking_lot`, so we can replace our
homegrown remutex with `parking_lot`'s version.
Fixes #12641 .
2024-03-22 08:16:39 +00:00
Delan Azabani
8882507ad0
Rework “visible” to “throttled” in constellation + script + compositor ( #31816 )
2024-03-22 06:06:28 +00:00
Aarya Khandelwal
9b26dca141
Fixed the .clone() warnings. ( #31819 )
2024-03-22 05:41:17 +00:00
atbrakhi
95e69fe4ff
layout: use Au in BoxFragment ( #31794 )
...
* use au in BoxFragement
* review fix
2024-03-22 04:30:39 +00:00
Delan Azabani
0b863de846
Rework “visible” to “throttled” in embedder-to-constellation + jniapi ( #31815 )
2024-03-21 18:48:17 +00:00
Alex Touchet
49c6f9e463
Update some dependencies ( #31814 )
2024-03-21 18:17:18 +00:00
Oluwatobi Sofela
3e63f8d6ee
clippy: Fix needless borrow warnings ( #31813 )
2024-03-21 17:48:54 +00:00
Oluwatobi Sofela
694e86ecff
clippy: Fix dereferencing a tuple pattern warnings ( #31811 )
2024-03-21 17:04:18 +00:00
Richard Dushime
b22281d94f
Fix WPT reference no_red_3x3_monospace_table-ref.xht ( #31802 )
...
* Fix WPT reference no_red_3x3_monospace_table-ref.xht
* wpt Update manifest.json
2024-03-21 17:03:55 +00:00
Martin Robinson
841bd91784
layout: Take into account text-indent for justification ( #31777 )
...
This change makes it so that when calculating the space added between
words for justification, text-indent is taken into account.
Fixes #31775 .
2024-03-21 15:58:03 +00:00
Martin Robinson
755701f4f6
crown: Do not warn about crown for rustdoc or clippy ( #31805 )
...
Fixes #31804 .
2024-03-21 15:33:06 +00:00
Jonathan Schwender
32a2b06073
Update fontsan to 0.5.2 ( #31810 )
2024-03-21 15:00:21 +00:00
eri
8c7e9a15e1
Remove repeated imports from generated code ( #31711 )
...
* feat: try to deduplicate imports in codegen
* feat: another attempt
* feat: start testing imports
* feat: clean all global imports
* feat: remove shared imports from CGDescriptor
* feat: remove redundant imports from CGDescriptor
* fix: formatting
* fix: remove libc (base level import)
* feat: roll back named path changes
* feat: last changes and tidy
* experiment: move imports into a separate file
* fix: extra parenthesis
* fix: remove repeated allow statement
2024-03-21 13:38:16 +00:00
Jonathan Schwender
f5c4988dcb
Use C-ABI for JNI functions ( #31808 )
...
`#[no_mangle]` alone does not imply "C"-ABI,
however the JNI layer will use the C-ABI to call the function.
See also the relevant [clippy-lint](https://rust-lang.github.io/rust-clippy/master/index.html#/no_mangle )
2024-03-21 13:12:31 +00:00
eri
da696b7e57
clippy: fix result_unit_err warnings ( #31791 )
...
* clippy: fix `result_unit_err` warnings
* feat: fix result warnings in script
* doc: document `generate_key` return type
Co-authored-by: Martin Robinson <mrobinson@igalia.com>
* feat: add back result to RangeRequestBounds::get_final
Co-authored-by: Martin Robinson <mrobinson@igalia.com>
---------
Co-authored-by: Martin Robinson <mrobinson@igalia.com>
2024-03-21 12:51:45 +00:00
Oriol Brufau
ea62a5e24f
Use --locked when building in CI ( #31720 )
...
Thus the build will immediately fail if a PR modifies Cargo.toml but
forgets to include the changes in Cargo.lock
This was previously checked by lockfile_changed.sh after building
normally, wasting resources.
2024-03-21 11:54:02 +00:00
Oriol Brufau
ecabdc2583
Don't trim leading whitespace of anonymous table cells ( #31803 )
...
A sequence of whitespace shouldn't generate an anonymous table row/cell,
but we can't just throw away the leading whitespace, because afterwards
we may encounter some other content, and then the leading whitespace
should appear in the cell (noticeable with e.g. `white-space: pre`).
2024-03-21 11:48:39 +00:00
Rosemary Ajayi
ce0d456469
clipping: Fix some warnings in components/script/dom ( #31799 )
...
* fix clippy websocket errors
* fix clippy window errors
* fix clippy window errors
* fix clippy window errors
2024-03-21 11:46:18 +00:00
Samson
4b408a3724
Update mozjs to use SM 115.9 ( #31757 )
2024-03-21 09:19:49 +00:00
Aarya Khandelwal
7cdff9dd06
Clippy: Fixed warnings in htmlimageelement.rs ( #31800 )
...
* Fixed warnings in htmlimageelement.rs
* making changes for test-tidy to run without errors.
2024-03-21 08:00:24 +00:00
Aarya Khandelwal
da3288dd00
Clippy: Fixed clippy warnings in components/script/dom ( #31801 )
...
* fixed clippy warnings in htmlformelement.rs
* Fixed clippy warnings
* Fixed warnings related to matches!
* made changes to compile "test-tidy" successfully
2024-03-21 07:14:12 +00:00
tannal
5c0199b568
Net: fold websocket and http tokio runtime into one ( #31771 )
...
* net: use the same tokio runtime in websocket loader
#31648
* readability
* license
2024-03-21 06:13:03 +00:00
Oluwatobi Sofela
2789e98876
clippy: Fix redundant field names warnings ( #31793 )
2024-03-20 23:05:29 +00:00
dependabot[bot]
f55d1d288e
build(deps): bump smallvec from 1.13.1 to 1.13.2 ( #31798 )
...
Bumps [smallvec](https://github.com/servo/rust-smallvec ) from 1.13.1 to 1.13.2.
- [Release notes](https://github.com/servo/rust-smallvec/releases )
- [Commits](https://github.com/servo/rust-smallvec/compare/v1.13.1...v1.13.2 )
---
updated-dependencies:
- dependency-name: smallvec
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-03-20 23:04:54 +00:00
sandeep
efba769fa3
fixed unused import warning in minibrowser ( #31797 )
...
Signed-off-by: Sandeep Pillai <sandeeppillai@Sandeeps-MacBook-Air.local>
Co-authored-by: Sandeep Pillai <sandeeppillai@Sandeeps-MacBook-Air.local>
2024-03-20 21:54:26 +00:00
Samson
63d7af54d1
Ignore stylo crates in dependabot.yml ( #31790 )
...
* Ignore stylo crates in dependabot.yml
* Update .github/dependabot.yml
Co-authored-by: Martin Robinson <mrobinson@igalia.com>
---------
Co-authored-by: Martin Robinson <mrobinson@igalia.com>
2024-03-20 20:34:34 +00:00
Rhea-Eve
b3dc5c6958
Attempt using version of Stylo with -x-lang enabled ( #31737 )
...
* Attempt using version of Stylo with -x-lang enabled
Signed-off-by: Rhea Karty <rheakarty@gmail.com>
* Added x-lang to initializer list to address failing tests.
Signed-off-by: Rhea Karty <rheakarty@gmail.com>
* Fix formatting (sorry)
Signed-off-by: Rhea Karty <rheakarty@gmail.com>
* Revert changes in Cargo.toml, update Cargo.lock.
Signed-off-by: Rhea Karty <rheakarty@gmail.com>
* Removed .git suffix from Stylo
Signed-off-by: Rhea Karty <rheakarty@gmail.com>
---------
Signed-off-by: Rhea Karty <rheakarty@gmail.com>
2024-03-20 18:52:06 +00:00
Rosemary Ajayi
058319aa0b
clippy: Fix some clippy problems in components/script ( #31778 )
...
* fix clippy problems in stylesheet
* fix clippy problems in task_manager
* fix clippy problems in task_queue
* fix clippy problems in task_queue
* fix clippy problems in file_reading
* fix clippy problems in dom_manipulation
* fix clippy problems in gamepad
* fix clippy problems in networking
* fix clippy problems in performance
* fix clippy problems in port_message
* fix clippy problems in port_message
* fix clippy problems in timer
* fix clippy problems in stylesheet
* fix clippy problems
* fix clippy problems
* fix clippy problems
2024-03-20 18:41:07 +00:00
dependabot[bot]
3651b650c4
build(deps): bump rustix from 0.38.31 to 0.38.32 ( #31788 )
...
Bumps [rustix](https://github.com/bytecodealliance/rustix ) from 0.38.31 to 0.38.32.
- [Release notes](https://github.com/bytecodealliance/rustix/releases )
- [Commits](https://github.com/bytecodealliance/rustix/compare/v0.38.31...v0.38.32 )
---
updated-dependencies:
- dependency-name: rustix
dependency-type: indirect
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2024-03-20 18:35:37 +00:00
