Commit graph

35536 commits

Author SHA1 Message Date
bors-servo
eab848df3e
Auto merge of #22433 - ferjm:player.eos.size, r=ceyusa
Improve implementation of media resource fetch algorithm

I have been observing inconsistent behaviors with my local tests depending of the media asset being played. I figured that we had these issues:

- We were setting the player EOS as soon as we got the first [process_response_eof](1046ae58a1/components/script/dom/htmlmediaelement.rs (L1596)). This is fine only if there is a single request. But that's not the case for multiple range requests or for seeks. Setting the player EOS makes the player appsrc reject any new buffers, and that breaks playback. Figuring out when is the right time to set the player EOS won't be a straight forward task, so my suggested fix for now is to simply not set it for now. It is a cleanup step that it would be nice to have but it is not mandatory.

- We were setting the input size more than once for multiple range requests and with the incorrect value. The fix uses the `content-length` or the `content-range` headers for single and range requests respectively.

- We were moving to the HaveEnoughData state if a fetch request succeded but no data was fetched from the network.

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22433)
<!-- Reviewable:end -->
2018-12-12 18:38:25 -05:00
bors-servo
ef8be44e46
Auto merge of #22435 - servo:tc-wpt-linux, r=jdm
Move Linux WPT from Buildbot to Taskcluster

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22435)
<!-- Reviewable:end -->
2018-12-12 16:58:12 -05:00
bors-servo
2e01a23bad
Auto merge of #22432 - servo:encoding, r=SimonSapin
Make the parser decode input from document's encoding

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22432)
<!-- Reviewable:end -->
2018-12-12 15:17:32 -05:00
Simon Sapin
e60e534d23 Move linux WPT from Buildbot to Taskcluster 2018-12-12 20:02:44 +01:00
Simon Sapin
9ab2606a54 Fix ./mach filter_intermittents in shallow git clones.
`git log --merges` only shows commits with at least two parents.
Presumably, this only works when the parent commits are in the local repository.
In a shallow clone (`--depth 1`), on the HEAD commit is fetched.

This commit removes the `--merges` filter.
This shouldn’t affect the behavior,
since CI always runs with a merge commit as HEAD.
2018-12-12 20:02:44 +01:00
Simon Sapin
e680c5be80 Taskcluster: align Linux WPT task with what’s now on Buildbot 2018-12-12 20:02:44 +01:00
bors-servo
d5c1690cb4
Auto merge of #22324 - lucasfantacuci:implement_html_media_element_volume_attribute, r=ferjm
Implementing HTMLMediaElement.volume attribute

<!-- Please describe your changes on the following line: -->
This P.R. is going to implement the volume attribute to the HTMLMediaElement

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22292.
<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22324)
<!-- Reviewable:end -->
2018-12-12 13:54:55 -05:00
Fernando Jiménez Moreno
8818898240 Do not move to HaveEnoughData state if no media data is fetched from the network 2018-12-12 18:08:40 +01:00
Fernando Jiménez Moreno
707b490c0f Signal EOS if media request fails 2018-12-12 16:52:37 +01:00
Lucas Fantacuci
ad3ec61d2f Implementing volume attribute into HTMLMediaElement 2018-12-12 11:50:35 -02:00
Anthony Ramine
a2abfc6301 Make the parser decode input from document's encoding
The document's encoding is only computed from the Content-Type header for now,
with no sniffing at all.
2018-12-12 13:50:27 +01:00
bors-servo
a86c23cdca
Auto merge of #22381 - servo:tc-rustdoc, r=nox
Build docs and upload to doc.servo.org on Taskcluster, add support for trychoosers

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22381)
<!-- Reviewable:end -->
2018-12-12 07:20:54 -05:00
Fernando Jiménez Moreno
243b4e1a39 Do not set player EOS. Set input size only if it changes 2018-12-12 13:06:52 +01:00
Simon Sapin
e7b493df18 Taskcluster: Add support for trychoosers 2018-12-12 12:46:55 +01:00
Anthony Ramine
848a4e256a Fix an ignore_malloc_size_of comment 2018-12-12 11:29:14 +01:00
Anthony Ramine
dbef324e48 Use Mime::get_param 2018-12-12 11:29:14 +01:00
Anthony Ramine
d1d79bf947 Remove an argument to ServoParser::parse_html_script_input
Since the spec of document.open was updated, this argument became useless.
2018-12-12 11:29:14 +01:00
bors-servo
1046ae58a1
Auto merge of #22081 - KiChjang:onmessageerror, r=jdm
Add onmessageerror to WindowEventHandler

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22081)
<!-- Reviewable:end -->
2018-12-12 02:49:04 -05:00
Keith Yeung
3ee5a63199 Add onmessageerror to WindowEventHandler 2018-12-11 23:48:46 -08:00
Simon Sapin
8588e928e7 Remove Buildbot script for docs upload 2018-12-12 08:28:59 +01:00
Simon Sapin
eb21ceaf98 Upload to doc.servo.org when merging to master 2018-12-12 08:28:58 +01:00
Simon Sapin
a35d16a09c Taskcluster: build docs 2018-12-12 08:28:57 +01:00
Simon Sapin
e5ae3464cc Shorter Treeherder "symbols" 2018-12-12 08:28:15 +01:00
Simon Sapin
00a1e9391c Generate apis.html in ./mach doc 2018-12-12 08:28:15 +01:00
Simon Sapin
98c5710135 Generate CSS properties docs in ./mach doc 2018-12-12 08:28:15 +01:00
Simon Sapin
e2c3acf4d5 Copy from etc/doc.servo.org in ./mach doc 2018-12-12 08:28:14 +01:00
bors-servo
4ef1db879c
Auto merge of #22419 - servo:tc-dev, r=jdm
Buildbot: disable jobs that have moved to Taskcluster

For now the Buildbot jobs are made no-ops. A separate PR to https://github.com/servo/saltfs will disable them.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22419)
<!-- Reviewable:end -->
2018-12-12 01:18:54 -05:00
bors-servo
aab239c27b
Auto merge of #22426 - servo:choosers, r=SimonSapin
Taskcluster: start a decision task for all try-* branches

This is an alternative fix for https://github.com/servo/saltfs/issues/903, and anticipates adding trychooser support to Taskcluster.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22426)
<!-- Reviewable:end -->
2018-12-11 23:44:57 -05:00
bors-servo
67a70f49ab
Auto merge of #22424 - servo:tc-docs, r=Manishearth
Add documentation on Treeherder

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22424)
<!-- Reviewable:end -->
2018-12-11 21:25:00 -05:00
Simon Sapin
fdb2a66261 Taskcluster: start a decision task for all try-* branches
This is an alternative fix for https://github.com/servo/saltfs/issues/903,
and anticipates adding trychooser support to Taskcluster
2018-12-11 23:43:14 +01:00
Simon Sapin
1b9de89b15 Add documentation on Treeherder 2018-12-11 22:51:21 +01:00
bors-servo
90fc9e22b3
Auto merge of #22392 - dlrobertson:add_text_track, r=ferjm
Add the basics of TextTrack

## Summary

Implement the basics of the TextTrack elements:
  - TextTrack
  - TextTrackCue
  - TextTrackCueList
  - TextTrackList

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes is related to #22311
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22392)
<!-- Reviewable:end -->
2018-12-11 16:50:07 -05:00
Dan Robertson
eb531f6755
update-wpt: TextTrack tests
Update the expectations of TextTrack related tests.
2018-12-11 20:14:04 +00:00
Dan Robertson
62a9bfa0c5
script: Create structures for TextTrack API
Fill out the basics for the WebIDLs for the following:

  - TextTrack
  - TextTrackCue
  - TextTrackCueList
  - TextTrackList
2018-12-11 20:14:00 +00:00
Simon Sapin
e6d6bd7d03 Buildbot: disable jobs that have moved to Taskcluster 2018-12-11 20:11:12 +01:00
Simon Sapin
72492b58db Taskcluster: Add Buildbot-equivalent Android x86 task
CC https://github.com/servo/servo/issues/22187, https://github.com/servo/servo/pull/22257
2018-12-11 20:10:50 +01:00
Simon Sapin
554ee4e59d Fix Terraform scripts for Packet.net deployment 2018-12-11 20:10:50 +01:00
bors-servo
92962de76c
Auto merge of #22411 - jdm:fix-webdriver, r=SimonSapin
Make desktop webdriver WPT harness work

This change allows me to run `./mach test-wpt --product servodriver --no-pause-after-test tests/wpt/mozilla/tests/mozilla/DOMParser.html` successfully again.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22409
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22411)
<!-- Reviewable:end -->
2018-12-11 13:03:52 -05:00
Simon Sapin
0619541004 Taskcluster: add android-dev task 2018-12-11 19:01:09 +01:00
Simon Sapin
ac9a72aed5 Remove daily no-op Android task.
Because `find_or_create` is used, it never actually runs!
The corresponding pre-merge task is always found.
2018-12-11 19:01:09 +01:00
Josh Matthews
6ab475b0f4 Make SSL tests work in servodriver. 2018-12-11 12:51:36 -05:00
Simon Sapin
6de65556b4 Taskcluster: add libsimpleservo and less-unstable builds to linux-dev task 2018-12-11 18:47:26 +01:00
Simon Sapin
e576e3d79e Add some documentation on the various Taskcluster worker types 2018-12-11 18:40:39 +01:00
bors-servo
0375cbcbc0
Auto merge of #22415 - servo-wpt-sync:wpt_update_10-12-2018, r=jdm
Sync WPT with upstream (10-12-2018)

Automated downstream sync of changes from upstream as of 10-12-2018.
[no-wpt-sync]

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22415)
<!-- Reviewable:end -->
2018-12-10 23:56:47 -05:00
WPT Sync Bot
a44e48301c Update web-platform-tests to revision 912d5081b62d6e6a2f847935c82722e31cca7a1f 2018-12-10 23:19:57 -05:00
bors-servo
5d9e0b59da
Auto merge of #22414 - sinkuu:redundant_clone, r=emilio
Remove redundant `.clone()`s

<!-- Please describe your changes on the following line: -->
Removes `clone()`s of values unused after cloning.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because this is trivial cleanup

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22414)
<!-- Reviewable:end -->
2018-12-10 22:42:58 -05:00
bors-servo
af1ced3148
Auto merge of #22408 - technicalguy:linux-mint-build-info-readme, r=jdm
Add info about building on Linux Mint to README.md

Linux Mint 19.* is based on Ubuntu 16.04 packages.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because they are documentation changes in the `README.md`

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22408)
<!-- Reviewable:end -->
2018-12-10 20:57:03 -05:00
Shotaro Yamada
c44a2febe6 Remove redundant .clone()s 2018-12-11 10:43:51 +09:00
bors-servo
9980d6a8c5
Auto merge of #22356 - jdm:image-reload-test, r=Manishearth
Add missing test for image reloading bug

This adds an automated test for #22336.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22356)
<!-- Reviewable:end -->
2018-12-10 19:41:52 -05:00
Josh Matthews
08b76ee73f Add automated test for servodriver harness. 2018-12-10 19:07:06 -05:00