Commit graph

39349 commits

Author SHA1 Message Date
bors-servo
ef192c6b36
Auto merge of #24811 - servo:fail-fast, r=jdm
Fix updating the GitHub Status as soon as any TC task fails

… rather than only when the entire task group is resolved. This allows Homu to more quickly be notified of a failure, and move on to the next PR in the queue sooner.

(Plus drive-by Brewfile fix.)
2019-11-22 14:58:40 -05:00
bors-servo
10a63cc9d4
Auto merge of #24668 - tuncer:configure-media-stack-v2, r=asajeffrey
Allow build to explicitly set the media stack

<!-- Please describe your changes on the following line: -->
_[This is based on @asajeffrey's work in #23423, and is a rebase and continuation of that branch]_

This allows `./mach build` to override the media stack, which is currently hard-wired based on the target. To skip gstreamer, run `./mach build -d --media-stack=dummy`.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #23050 (GitHub issue number if applicable)
<!-- Either: -->
- [x] These changes do not require tests because it's build infra

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2019-11-22 13:26:07 -05:00
Simon Sapin
77089ef44e Fix updating the GitHub Status as soon as any TC task fails
… rather than only when the entire task group is resolved.
This allows Homu to more quickly be notified of a failure,
and move on to the next PR in the queue sooner.
2019-11-22 18:14:27 +01:00
Simon Sapin
4dbdd255a1 Remove support for shallow clones. The bundle is already shallow. 2019-11-22 18:14:26 +01:00
Simon Sapin
3a8bb531a0 Fetch repository from artifacts rather than GitHub 2019-11-22 18:14:26 +01:00
Simon Sapin
55a8158d17 Decision taks: add artifacts of the repository’s contents 2019-11-22 16:09:03 +01:00
Simon Sapin
a11dc7006f Add Windows support to with_curl_artifact_script 2019-11-22 16:09:03 +01:00
Simon Sapin
b96a36c131 Move mkdir call out of with_curl_script 2019-11-22 16:09:02 +01:00
Simon Sapin
83921dbc99 Deduplicate task dependencies 2019-11-22 16:09:02 +01:00
Simon Sapin
203a06ff24 Fix Brewfile’s for running Servo without bulding it 2019-11-22 16:09:02 +01:00
bors-servo
1b524ead1e
Auto merge of #24818 - gterzian:fix_panic_on_finish_load, r=jdm
Prevent panic on layout send in finish-load

<!-- Please describe your changes on the following line: -->

Do not run the finish load steps if the pipeline has been discarded by the time the parser finishes.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #22955 (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2019-11-22 03:12:59 -05:00
Gregory Terzian
f28ffaca59 abort parser before shutting down layout in exit pipeline 2019-11-22 14:45:23 +08:00
bors-servo
c060f00535
Auto merge of #24789 - gterzian:fix_unloading, r=jdm
Fix unloading, active BC, and clearing js runtime

<!-- Please describe your changes on the following line: -->

Do not set the window to be the currently active one for the windowproxy as part of `load`, as it will be done later when the document activity is set. And doing it later means that when unload runs, it is with the unloaded pipeline as the active window.

Only nullify the window proxy if it's not used by another (currently-active) window.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #24591 (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2019-11-22 01:28:36 -05:00
bors-servo
49f47ea09f
Auto merge of #24816 - saschanaz:promiserejection, r=jdm
Require PromiseRejectionEventInit dictionary

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22670

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2019-11-21 21:39:44 -05:00
Kagami Sascha Rosylight
22278a8895 Require PromiseRejectionEventInit dictionary 2019-11-22 10:18:11 +09:00
bors-servo
fdd5dadc3a
Auto merge of #24817 - servo:jdm-patch-31, r=Manishearth
Unindent Document::set_activity

I was reading this method while reviewing some code and I find the early-return version easier to read.
2019-11-21 19:56:21 -05:00
Tuncer Ayaz
81c439a899 Extract media_stack pick into CommandBase 2019-11-21 20:08:04 +00:00
Tuncer Ayaz
6d8f35c590 Allow media_stack in run_cargo_build_like_command 2019-11-21 20:08:04 +00:00
Tuncer Ayaz
d641585679 Implement ./mach check --media-stack
While at it, extract --media-stack flag into command_base.py.
2019-11-21 20:08:03 +00:00
Tuncer Ayaz
ba3169e65d Implement ./mach doc --media-stack={dummy|gstreamer} 2019-11-21 20:08:03 +00:00
Tuncer Ayaz
01a99b5cbe Make gstreamer(-sys) optional 2019-11-21 20:08:03 +00:00
Tuncer Ayaz
c7ac4bbb19 simpleservo: add media-{dummy,gstreamer} features 2019-11-21 20:08:02 +00:00
Tuncer Ayaz
528322cfed Fix needs_gstreamer_env() signature
Use iterable default value for `features`.
2019-11-21 20:08:01 +00:00
Tuncer Ayaz
a3ef594470 Pass feature list to build_env() 2019-11-21 20:08:01 +00:00
Alan Jeffrey
4e3f164f7b Allow mach build to explicitly set the media stack
You can select the media backend by building as follows:

$ ./mach build -d --media-stack=dummy
or
$ ./mach build -d --media-stack=gstreamer
2019-11-21 20:08:01 +00:00
bors-servo
91b612f8df
Auto merge of #24692 - paulrouget:checkcpp-tc, r=jdm
Run test-tidy with CPP files check on Windows
2019-11-21 12:11:37 -05:00
Gregory Terzian
1fab2416d7 abort parser, if any, when pipeline exits 2019-11-21 23:58:03 +08:00
Josh Matthews
aa7a52c05e
dom: Unindent Document::set_activity. 2019-11-21 10:14:28 -05:00
Gregory Terzian
a21c0bfd1a ensure unload run with old pipeline as currently-active, do not nullify proxy unless currently-active 2019-11-21 22:30:08 +08:00
Paul Rouget
b71774d8fe Run test-tidy on Windows 2019-11-21 09:56:39 +01:00
bors-servo
47e39af0f3
Auto merge of #24798 - tmiasko:jemalloc, r=jdm
Update jemalloc-sys to 0.3.2

Update jemalloc-sys to 0.3.2 to avoid issue where jemalloc occasionally keeps
spinning in `je_spin_adaptive`.

- [X] `./mach build --release` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #24791
2019-11-20 20:35:33 -05:00
bors-servo
eb363ec8ae
Auto merge of #24777 - servo:jdm-patch-34, r=Manishearth
Enable webxr by default

This changes two things:
* enable WebXR by default, since it's not exactly an experimental technology in Servo anymore
* enable the glwindow webxr backend by default so it's easier to test WebXR on desktop nightlies

Since the glwindow pref is only checked in the glutin desktop port, enabling it for other ports does not hurt us at all and it removes a papercut for testing WebXR content on desktop.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24777)
<!-- Reviewable:end -->
2019-11-20 16:37:35 -05:00
bors-servo
dc22a78cc2
Auto merge of #24757 - Akash-Pateria:async-wasm-compilation-subsequent, r=jdm
Async wasm compilation event loop integration

The PR contains changes related to binding the runnable dispatching in script_runtime and is part of the Asynchronous WebAssembly Compilation fix. This is the first step in the subsequent steps mentioned in the [wiki](https://github.com/servo/servo/wiki/Asynchronous-WebAssembly-compilation-project).

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes are part of #21476 fix
2019-11-20 16:16:13 -05:00
Josh Matthews
b816c0ff68 Enable webxr by default. 2019-11-20 15:43:06 -05:00
bors-servo
f6348b8b54
Auto merge of #24499 - ferjm:media.session.api, r=Manishearth
Media Session API

- [X] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24172
- [x] There are tests for these changes

This PR introduces all the pieces required to prove an end to end media session flow with Android as a test platform.
2019-11-20 12:31:29 -05:00
Fernando Jimenez Moreno
9f77ea1165 Mach fmt, this time including C++ files 2019-11-20 13:40:21 +01:00
Fernando Jiménez Moreno
6dcdfefd72 Fix simpleservo build 2019-11-20 13:34:54 +01:00
Fernando Jiménez Moreno
ca1a2e0525 Update test expectations 2019-11-20 13:34:54 +01:00
Fernando Jiménez Moreno
ba48e542e4 Enable MediaSession WPT 2019-11-20 13:34:31 +01:00
Fernando Jiménez Moreno
59f22abb3e Remove stop button for now and show play/pause in compact mode 2019-11-20 13:34:31 +01:00
Fernando Jiménez Moreno
35c4c35416 Fix metadata update 2019-11-20 13:34:31 +01:00
Fernando Jiménez Moreno
f65c400828 Update media session metadata and show content text with artist and album 2019-11-20 13:34:30 +01:00
Fernando Jiménez Moreno
d33c96b31e Fallback to current url as metadata title 2019-11-20 13:34:30 +01:00
Fernando Jiménez Moreno
6ee21af0c4 Update media session metadata according to media player 2019-11-20 13:34:30 +01:00
Fernando Jiménez Moreno
caedc28118 Do not play notification sound when creating media session on Android 2019-11-20 13:34:29 +01:00
Fernando Jiménez Moreno
7b5b46f560 Fix play action 2019-11-20 13:34:29 +01:00
Fernando Jiménez Moreno
07483f1d44 Switch play and pause buttons according to playback state 2019-11-20 13:34:29 +01:00
Fernando Jiménez Moreno
b5b8c6c2a8 Remove prev and next track action buttons for now 2019-11-20 13:34:29 +01:00
Fernando Jiménez Moreno
b048d7faf7 Fix media session action handling 2019-11-20 13:34:29 +01:00
Fernando Jiménez Moreno
9da1dd3592 Default media session actions 2019-11-20 13:34:29 +01:00