Commit graph

18927 commits

Author SHA1 Message Date
Josh Matthews
f95613e320 Enable more DOM bindings inlining opportunities. 2016-07-13 15:01:00 -04:00
bors-servo
27542e4165 Auto merge of #12371 - stshine:flex-block-flow, r=notriddle
Treat flex flow as block in float calculation

<!-- Please describe your changes on the following line: -->
This is on of my pull requests that implement basic flexible box layout.
Currently call `is_block_like()` on flex flow returns false. This would fix some errors in tests, for example 'flexbox-justify-content-horiz-001b.htm'.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because flexbox is not implemented yet.

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12371)
<!-- Reviewable:end -->
2016-07-11 09:31:03 -07:00
bors-servo
9e010a8aec Auto merge of #12383 - zeusintuivo:feature/11611, r=nox
Rename SharedKeyboardAndMouseEventInit to EventModifierInit

<!-- Please describe your changes on the following line: -->
- [X] renamed file SharedMouseAndKeyboardEventInit,
- [X] changed SharedKeyboardAndMouseEventInit to EventModifierInit.
- [X] Rebased mozilla/master into it.
- [x] Ran build and tidy test without errors

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #11611 (github issue number if applicable).

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12383)
<!-- Reviewable:end -->
2016-07-11 08:25:45 -07:00
zeusintuivo
d26bb29bb2 Rename SharedKeyboardAndMouseEventInit to EventModifierInit 2016-07-11 16:39:59 +02:00
bors-servo
3ad7261e29 Auto merge of #12386 - servo:geckolib-travis, r=nox
Build geckolib on travis.

This adds about two minutes to the twenty-minute build.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12386)
<!-- Reviewable:end -->
2016-07-11 06:06:06 -07:00
Ms2ger
04f1b28d45 Build geckolib on travis.
This adds about two minutes to the twenty-minute build.
2016-07-11 14:26:37 +02:00
bors-servo
c3a8cbbd38 Auto merge of #12385 - Ms2ger:arc_ptr_eq, r=SimonSapin
Move arc_ptr_eq to style.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12385)
<!-- Reviewable:end -->
2016-07-11 05:11:48 -07:00
bors-servo
1c7bec4b49 Auto merge of #12381 - Ms2ger:units, r=nox
Move some unit type definitions to style_traits.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12381)
<!-- Reviewable:end -->
2016-07-11 03:17:55 -07:00
Ms2ger
cbfe77cee1 Move some unit type definitions to style_traits. 2016-07-11 12:14:27 +02:00
Ms2ger
9f13278b77 Move arc_ptr_eq to style. 2016-07-11 12:13:12 +02:00
bors-servo
8ded106186 Auto merge of #12370 - emilio:wrap, r=mbrubeck
Fix line-breaking with white-space: pre-wrap/pre-line;

<!-- Please describe your changes on the following line: -->

Not sure if this is the appropriate fix, but we'll know soon.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #12369

<!-- Either: -->
- [x] There are tests for these changes OR

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

r? @mbrubeck

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12370)
<!-- Reviewable:end -->
2016-07-11 01:08:57 -07:00
bors-servo
42e90f7db9 Auto merge of #12378 - izgzhen:blob-url-revocation-fix, r=Manishearth
Add FileID validity setting/checking logic to Blob URL implementation

r? @Manishearth

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12378)
<!-- Reviewable:end -->
2016-07-11 00:13:45 -07:00
bors-servo
2239e827bd Auto merge of #12376 - sappharx:master, r=ConnorGBrewster
add Runnable::name() implementation for PlannedNavigation #12333

<!-- Please describe your changes on the following line: -->
implements Runnable::name() for PlannedNavigation
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #12333 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because the issue stated no tests were needed

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12376)
<!-- Reviewable:end -->
2016-07-10 21:14:17 -07:00
bors-servo
1ff8d875dd Auto merge of #11750 - emilio:canvas-leaks, r=glennw
canvas: Deallocate WebRender images on canvas

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #11062.

- [x] These changes do not require tests because it's wr-only.

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

r? @glennw

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11750)
<!-- Reviewable:end -->
2016-07-10 20:09:48 -07:00
Zhen Zhang
0ff6f313e8 Add FileID validity setting/checking logic to Blob URL implementation 2016-07-11 10:51:55 +08:00
Emilio Cobos Álvarez
b7d45fe096
canvas: Deallocate WebRender images on canvas
Fixes #11062

Depends on: #11744, https://github.com/servo/webrender_traits/pull/57, and https://github.com/servo/webrender/pull/292
2016-07-10 19:24:15 -07:00
bors-servo
638eb80110 Auto merge of #12318 - tallowen:tidy-features, r=frewsxcv
[tidy] prevent duplicate json keys

Throws a tidy error when duplicated keys are present.
![screenshot from 2016-07-07 16-54-17](https://cloud.githubusercontent.com/assets/557689/16658260/fd19cece-4465-11e6-89b1-a79296ba6a72.png)

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #12283 (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12318)
<!-- Reviewable:end -->
2016-07-10 19:15:35 -07:00
Emilio Cobos Álvarez
b54b576202
layout: Add test for pre-line and pre-wrap wrapping not crashing servo. 2016-07-10 17:42:58 -07:00
bors-servo
68aca87e30 Auto merge of #11744 - emilio:wr-default, r=glennw
webgl: Unlock WebRender by default by adding a readback based fallback to WebGL context creation.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [x] These changes do not require tests because refactoring.

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

This should give us the chance to use WebRender by default in OSX.

r? @pcwalton

cc @glennw @larsbergstrom

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11744)
<!-- Reviewable:end -->
2016-07-10 17:25:29 -07:00
sappharx
636e63f166 add Runnable::name() implementation for PlannedNavigation resolve #12333 2016-07-10 17:52:48 -06:00
bors-servo
beaef005c2 Auto merge of #11873 - notriddle:rotate_anim, r=glennw
Rotate animation

Add rotation interpolation code for the case where their direction vectors are equal.
___

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #11808 (github issue number if applicable).
- [X] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11873)
<!-- Reviewable:end -->
2016-07-10 16:30:48 -07:00
Emilio Cobos Álvarez
383ba964ab
layout: text: Don't consider the REQUIRES_LINE_BREAK_AFTERWARD_IF_WRAPPING_ON_NEWLINES if the fragment can wrap text.
This was making us fall in a loop where the start split was empty, but we didn't
ignore it because the current fragment had this flag, but then we treated it
differently depending on the white_space property.

Not totally sure this is the proper fix, but it makes sense to me. In case it
is:

Fixes #12369.
2016-07-10 15:34:57 -07:00
bors-servo
c6827a9e66 Auto merge of #12375 - gpoesia:master, r=KiChjang
Implement Runnable::name() for ImageResponseHandlerRunnable

<!-- Please describe your changes on the following line: -->

Implement the name() method from the Runnable trait for ImageResponseHandlerRunnable.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #12345 (github issue number if applicable).

<!-- Either: -->
- [X] These changes do not require tests because it's stated in the issue (the change is trivial).

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12375)
<!-- Reviewable:end -->
2016-07-10 13:10:37 -07:00
Gabriel Poesia
502497fb1f Implement Runnable::name() for ImageResponseHandlerRunnable 2016-07-10 15:20:41 -03:00
bors-servo
01ec8491d3 Auto merge of #12374 - jdm:jsup, r=Manishearth
Improve performance of HTMLDivElement constructor

These changes address two sources of performance loss seen while profiling in #12354. #12358 and https://github.com/rust-lang/rust/issues/34727 are still the biggest offenders, however.

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because we don't have performance tests and these are only optimizations

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12374)
<!-- Reviewable:end -->
2016-07-10 08:18:27 -07:00
Josh Matthews
d0e3e612ab Avoid memmove in HTMLDivElement constructor. 2016-07-10 10:24:16 -04:00
Josh Matthews
da81464372 Update rust-mozjs for cross-crate inlining fixes. 2016-07-10 10:23:42 -04:00
bors-servo
287969f7bb Auto merge of #12373 - cynicaldevil:impl-runnable, r=KiChjang
Implements name method for FilerReader event from trait Runnable

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #12334

<!-- Either: -->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12373)
<!-- Reviewable:end -->
2016-07-10 05:59:37 -07:00
Nikhil Shagrithaya
48fe15206e Implements name method for FilerReader event from trait Runnable 2016-07-10 15:40:22 +05:30
Pu Xingyu
2aeed833e6 Treat flex flow as block in float calculation 2016-07-10 16:34:12 +08:00
bors-servo
2a60c97f8a Auto merge of #12368 - MovingtoMars:task_name, r=KiChjang
Implement Runnable trait name method for FireSimpleEventTask

<!-- Please describe your changes on the following line: -->

Implement Runnable trait name method for FireSimpleEventTask in `components/script/dom/htmlmediaelement.rs`.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #12346

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because trivial change

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12368)
<!-- Reviewable:end -->
2016-07-10 00:26:53 -07:00
MovingtoMars
673db44402 Implement Runnable trait name method for FireSimpleEventTask 2016-07-10 14:48:37 +12:00
bors-servo
8f13bb24f1 Auto merge of #12360 - pierre-alain-b:master, r=Wafflespeanut
Add name method for Runnable trait in DedicatedMediaSourceFailureTask…

Add name method for Runnable trait in DedicatedMediaSourceFailureTask.

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #12349.
- [X] These changes do not require tests because it is says so in the issue description.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12360)
<!-- Reviewable:end -->
2016-07-09 08:22:40 -07:00
bors-servo
8cb05a36bc Auto merge of #12344 - izgzhen:set-file-js, r=Manishearth
Add ability to WPT-test file uploads and fetches, fixes #12322

Using `inputElem.selectFiles(["path1", "path2"])` in JavaScript with pref `dom.htmlinputelement.select_files.enabled` = `true` will simulate the effect of `inputElem.click()`.

See #12322  for more, also related to #12343.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12344)
<!-- Reviewable:end -->
2016-07-09 02:02:34 -07:00
Pierre-Alain Bandinelli
23ba67662c Implement Runnable trait name method for ResourceSelectionTask, fixing #12348 2016-07-09 09:55:14 +02:00
Zhen Zhang
5e051c08f6 Add ability to WPT-test file uploads and fetches, fixes #12322 2016-07-09 15:31:00 +08:00
Pierre-Alain Bandinelli
5601de0269 Add name method for Runnable trait in DedicatedMediaSourceFailureTask, fixing #12349 2016-07-09 09:30:09 +02:00
bors-servo
c2a22bd05e Auto merge of #12268 - izgzhen:fm-spawn, r=Manishearth
Spawn threads for requests in file manager

r? @Manishearth

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [x] There are tests for these changes OR

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12268)
<!-- Reviewable:end -->
2016-07-08 20:33:26 -07:00
bors-servo
e50e4f99bf Auto merge of #12319 - servo:stable-geckolib, r=larsbergstrom+SimonSapin
Use a stable compiler for build-geckolib

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #11815 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because CI already runs `./mach build-geckolib`

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12319)
<!-- Reviewable:end -->
2016-07-08 16:20:14 -07:00
Simon Sapin
38b6b24a5d Fix #12359: make ensure_bootstrap check for host std if rustc exists. 2016-07-09 00:33:12 +02:00
bors-servo
7afe975281 Auto merge of #12293 - notriddle:margins_in_tables, r=mbrubeck
Correct negative margins in centered table cells

Fixes the cell-filling links on @AelitaBot [queue viewer page](http://ec2-52-26-55-30.us-west-2.compute.amazonaws.com/).

---

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] Couldn't find an applicable issue, and by the time I reduced the test case I'd already found the bug
- [X] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12293)
<!-- Reviewable:end -->
2016-07-08 15:25:07 -07:00
Simon Sapin
e2262882ad Use static-rust-lang-org.s3.amazonaws.com everywhere. 2016-07-08 22:28:54 +02:00
Simon Sapin
24575ff226 Move ports/geckolib/target to target/geckolib 2016-07-08 22:28:53 +02:00
Simon Sapin
846a951155 Remove the empty stable-rust crate. 2016-07-08 22:28:52 +02:00
Simon Sapin
79ef0a5d7f Remove the "./mach build-stable" subcommand
It is replaced by "./mach build-gecklibo" using stable Rust.
2016-07-08 22:28:51 +02:00
Simon Sapin
26a78817c1 Make "./mach geckolib" use the stable Rust compiler 2016-07-08 22:28:48 +02:00
Simon Sapin
6ae5598a5c Fix "looking for rustc at …" message for stable when already bootstrapped
Also always download from static-rust-lang-org.s3.amazonaws.com instead
of static.rust-lang.org. They host the same content, but the latter goes
through a CDN and has a TLS certificate that failed to verify and some
Python versions:

https://github.com/servo/servo/issues/3582
https://github.com/servo/servo/pull/3971
2016-07-08 22:27:20 +02:00
Simon Sapin
a39170728d Remove geckolib’s "servo_features" Cargo feature
We’re about to switch to separate CARGO_TARGET_DIR (and different
compiler version) so we won’t be able to share build output with servo’s
"normal" build anyway.
2016-07-08 22:27:19 +02:00
bors-servo
35a23bfef3 Auto merge of #12338 - upsuper:win-geckolib-fix, r=bholley
Fix geckolib build for Windows

It contains several fixes to make `./mach build-geckolib` work on Windows.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12338)
<!-- Reviewable:end -->
2016-07-08 11:14:48 -07:00
bors-servo
12260b24d0 Auto merge of #12277 - ConnorGBrewster:network_listener_cancellable, r=Manishearth
Make network listener runnable cancellable

<!-- Please describe your changes on the following line: -->
This keeps scripts from executing after its script thread has been shut down.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [x] These changes fix (maybe) #12048 (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12277)
<!-- Reviewable:end -->
2016-07-08 09:56:31 -07:00