Commit graph

32092 commits

Author SHA1 Message Date
Manish Goregaokar
285313f3c7 bail early for initial valued backgrounds 2018-02-21 00:36:35 -08:00
bors-servo
a0fff37de3
Auto merge of #20094 - servo-wpt-sync:wpt_update_20-02-2018, r=jdm
Sync WPT with upstream (20-02-2018)

Automated downstream sync of changes from upstream as of 20-02-2018.
[no-wpt-sync]

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20094)
<!-- Reviewable:end -->
2018-02-21 01:06:32 -05:00
maekawatoshiki
89797c0868 Fix typo 2018-02-21 14:00:06 +09:00
bors-servo
2c060eb81a
Auto merge of #20081 - emilio:more-longhand-stuff, r=nox
style: More serialization tweaks.

This still doesn't fix everything. In particular, we need to check whether the
subproperty will be enabled in Longhands and LonghandsToSerialize too.

I haven't decided yet on what's the best way to do that.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20081)
<!-- Reviewable:end -->
2018-02-20 23:49:19 -05:00
bors-servo
036b9d3139
Auto merge of #20095 - servo:jdm-patch-9, r=jdm
Set CARGO_HOME for Windows builders.

This is a temporary fix to allow reopening the tree. This value belongs in saltfs instead, but it's already late and I don't want to have to wait to deploy the changes.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20095)
<!-- Reviewable:end -->
2018-02-20 22:08:50 -05:00
Josh Matthews
47e0dab42a
Set CARGO_HOME for Windows builders.
This sets it to a directory that all relevant users can manipulate without any issues.
2018-02-20 22:02:01 -05:00
WPT Sync Bot
a57b869a58 Update web-platform-tests to revision 58462b6f92aab3eea03ad1ea70923855889ed1e2 2018-02-20 21:46:54 -05:00
Manish Goregaokar
7de29d0ac4 Update test expectations 2018-02-20 14:00:58 -08:00
Emilio Cobos Álvarez
e47b3b23ab
style: Update bindings. 2018-02-20 21:08:21 +01:00
bors-servo
05b8ba0a48
Auto merge of #20079 - servo:ZEH-INDEX, r=emilio
Replace IntegerOrAuto with ZIndex

It's its only use.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20079)
<!-- Reviewable:end -->
2018-02-20 12:13:40 -05:00
Josh Matthews
e3ab8b6d90
Add debug output to doc build.
This should narrow down the cause of https://github.com/servo/servo/issues/17243.
2018-02-20 12:05:33 -05:00
bors-servo
f5b0a187b0
Auto merge of #20085 - servo:jdm-patch-2, r=emilio
Clean target directories of linux builders.

This should avoid our frequent problems with running out of disk space on the smallest linux build machines. This linux builders are also our fastest ones, so it shouldn't slow down our CI too much.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20085)
<!-- Reviewable:end -->
2018-02-20 10:36:19 -05:00
Emilio Cobos Álvarez
a4c7728062
style: Cleanup PrioritizedPropertyIter. 2018-02-20 16:32:40 +01:00
Emilio Cobos Álvarez
0b1f78275c
style: Remove unneeded whitespace.
I bet it was added when this code was part of a mako file.
2018-02-20 16:32:13 +01:00
Josh Matthews
710baa4f6f
Clean target directories of linux builders.
This should avoid our frequent problems with running out of disk space on the smallest linux build machines.
2018-02-20 10:21:27 -05:00
Anthony Ramine
b44ffcf498 Replace IntegerOrAuto with ZIndex
It's its only use.
2018-02-20 15:18:22 +01:00
bors-servo
8fdcfb2dfe
Auto merge of #20080 - ferjm:innertext.cleanup, r=emilio
Minor cleanup of element.innerText

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20080)
<!-- Reviewable:end -->
2018-02-20 08:43:48 -05:00
Emilio Cobos Álvarez
1359c7c218
style: Don't try to serialize the same shorthand over and over.
I looked at what were we doing in that loop, and we're doing tons of dumb stuff.

In particular, we try to serialize the "all" shorthand all the time. This patch
prevents us from trying to serialize shorthands that we've already tried to
serialize.
2018-02-20 14:21:35 +01:00
Emilio Cobos Álvarez
c09257b540
style: There's no need to check the serialized custom properties.
Given they're not duplicated, and can't be part of a shorthand.
2018-02-20 14:21:34 +01:00
Emilio Cobos Álvarez
4c979a8346
style: Remove a unit test that relies on disabled-by-default properties. 2018-02-20 14:21:34 +01:00
Fernando Jiménez Moreno
ff81707928 Minor cleanup of element.innerText 2018-02-20 13:50:53 +01:00
Emilio Cobos Álvarez
94b687306f
style: Cleanup always-false argument to Servo_ResolveStyleLazily.
I changed this setup in https://bugzilla.mozilla.org/show_bug.cgi?id=1414999,
because it was totally unsound.
2018-02-20 12:59:21 +01:00
bors-servo
4d7383f4f3
Auto merge of #20078 - emilio:decl-block-serialization, r=nox
style: Rejigger serialization of a declaration block to not look at the shorthands length.

This is because I'm going to make shorthands() and longhands() return an
iterator, so that we account for prefs properly
(https://bugzilla.mozilla.org/show_bug.cgi?id=1438234).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20078)
<!-- Reviewable:end -->
2018-02-20 06:40:43 -05:00
Emilio Cobos Álvarez
e46f910b66
style: Rejigger serialization of a declaration block to not look at the shorthands length.
This is because I'm going to make shorthands() and longhands() return an
iterator, so that we account for prefs properly
(https://bugzilla.mozilla.org/show_bug.cgi?id=1438234).
2018-02-20 10:05:58 +01:00
Emilio Cobos Álvarez
c676b52448
style: Sprinkle some #[inline] on trivial methods. 2018-02-20 10:05:12 +01:00
Emilio Cobos Álvarez
f896cb63a6
style: Make DeclarationBlock::get O(1) if we know the longhand isn't there. 2018-02-20 10:04:17 +01:00
bors-servo
6a7ae3b12e
Auto merge of #20077 - servo-wpt-sync:wpt_update_19-02-2018, r=jdm
Sync WPT with upstream (19-02-2018)

Automated downstream sync of changes from upstream as of 19-02-2018.
[no-wpt-sync]

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20077)
<!-- Reviewable:end -->
2018-02-19 23:03:10 -05:00
WPT Sync Bot
8a6476740e Update web-platform-tests to revision 8fed98324bc133df221d778c62cbff210d43b0ce 2018-02-19 21:42:17 -05:00
bors-servo
be902d56c0
Auto merge of #20073 - servo:keywordsize, r=emilio
Remove some useless manual layout optimisation for KeywordSize

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20073)
<!-- Reviewable:end -->
2018-02-19 07:02:45 -05:00
Anthony Ramine
e976955634 Remove some useless manual layout optimisation for KeywordSize 2018-02-19 12:37:46 +01:00
bors-servo
6afdf7c1cb
Auto merge of #20072 - emilio:moz-transform, r=xidorn
style: Unship the legacy syntax for -moz-transform.

Intent to unship link:

  https://groups.google.com/d/msg/mozilla.dev.platform/T3PGm97MPNU/59XUavMlCgAJ

Reviewed-by: xidorn
Bug: 1438297
MozReview-Commit-ID: 6ybGBasPAWU

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20072)
<!-- Reviewable:end -->
2018-02-19 05:46:16 -05:00
Emilio Cobos Álvarez
df132b4954
style: Update bindings. 2018-02-19 11:45:47 +01:00
Emilio Cobos Álvarez
7473796aba
style: Unship the legacy syntax for -moz-transform.
Intent to unship link:

  https://groups.google.com/d/msg/mozilla.dev.platform/T3PGm97MPNU/59XUavMlCgAJ

Reviewed-by: xidorn
Bug: 1438297
MozReview-Commit-ID: 6ybGBasPAWU
2018-02-19 10:46:14 +01:00
bors-servo
a98da8ce93
Auto merge of #20070 - upsuper:authorstyles-size, r=bholley,njn
Add sizeof for AuthorStyles.

This is the Servo side change for [bug 1438497](https://bugzilla.mozilla.org/show_bug.cgi?id=1438497).
2018-02-18 23:13:10 -05:00
Xidorn Quan
f518e55c28 Add sizeof for AuthorStyles. 2018-02-19 15:12:13 +11:00
Manish Goregaokar
c36335e031 Remove table_style; tables already get their backgrounds painted correctly 2018-02-16 16:01:54 -08:00
Manish Goregaokar
180b29ae66 Unconditionally remove repaint damage for table cells/rows/rgs 2018-02-16 16:01:53 -08:00
Manish Goregaokar
c2de3eb9ac Check visibility beforehand 2018-02-16 16:01:52 -08:00
Manish Goregaokar
f796823b94 Handle rowspan 2018-02-16 16:01:51 -08:00
Manish Goregaokar
cfa81e8b79 Refactor column index advancing into its own method 2018-02-16 16:01:50 -08:00
Manish Goregaokar
b72a50d50a Pass down full ComputedValues to TableCellStyleInfo; use for correct color computation 2018-02-16 16:01:49 -08:00
Manish Goregaokar
21140e7a0a Make TableCellStyleIterator operate on immutable flows 2018-02-16 16:01:49 -08:00
Manish Goregaokar
265a2ab2cc Allow for build_display_list to be called immutably 2018-02-16 16:01:48 -08:00
Manish Goregaokar
5cd15eeb54 Don't redraw backgrounds that we've already drawn 2018-02-16 16:01:47 -08:00
Manish Goregaokar
db6ec58e6b Generate display lists for table cells during display list generation for their table parent 2018-02-16 16:01:46 -08:00
Manish Goregaokar
6232846699 Add stacking_relative_border_box_for_display_list 2018-02-16 16:01:46 -08:00
Manish Goregaokar
f7ac5d712f Add build_display_list_for_background_if_applicable_with_background 2018-02-16 16:01:45 -08:00
Manish Goregaokar
f3531d1d35 Factor out BlockFlow::background_border_section() 2018-02-16 16:01:44 -08:00
Manish Goregaokar
836e59e5b6 Handle colspan in TableCellStyleIterator 2018-02-16 16:01:44 -08:00
Manish Goregaokar
6317c44ab4 Add Iterator impl for TableCellStyleIterator 2018-02-16 16:01:43 -08:00