bors-servo
fafc280179
Auto merge of #8430 - jdm:errorhandler, r=Ms2ger
...
Invoke specialized callback behaviour for OnErrorEventHandler.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8430 )
<!-- Reviewable:end -->
2015-11-13 03:54:00 +05:30
Josh Matthews
2340583e56
Differentiate between error and non-error event handlers per the spec.
2015-11-12 16:21:24 -05:00
bors-servo
1e10b67b18
Auto merge of #8485 - hfaulds:make-layout-task-fields-private, r=Ms2ger
...
Make layout task fields private
For https://github.com/servo/servo/issues/8471
The second commit I'm slightly less sure about but with `chan` made private this warning was shown:
```
components/layout/layout_task.rs:152:5: 152:21 warning: struct field is never used: `chan`, #[warn(dead_code)] on by default
```
There might be some cleanup around `layout_chan` in https://github.com/hfaulds/servo/blob/make-layout-task-fields-private/components/layout/layout_task.rs#L244-L261 as well but that was a bit beyond me.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8485 )
<!-- Reviewable:end -->
2015-11-13 02:26:12 +05:30
bors-servo
b40882093a
Auto merge of #8428 - Ms2ger:conversions, r=Manishearth
...
Update js.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8428 )
<!-- Reviewable:end -->
2015-11-13 01:13:52 +05:30
Hayden Faulds
c0f497d4ac
remove unnecessary layout_chan
2015-11-12 13:52:08 +00:00
bors-servo
4848e37e2e
Auto merge of #7844 - Wafflespeanut:requests, r=jdm
...
Cancelable network requests!
fixes #4974
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7844 )
<!-- Reviewable:end -->
2015-11-12 18:59:58 +05:30
Hayden Faulds
5e7bf9cd9c
remove chan from layout task
2015-11-12 13:15:17 +00:00
bors-servo
743ca24819
Auto merge of #8481 - frewsxcv:iterablepage-iter, r=Ms2ger
...
Simplify IterablePage::find
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8481 )
<!-- Reviewable:end -->
2015-11-12 18:29:12 +05:30
Hayden Faulds
66b85fe4fc
make layout task fields private
2015-11-12 12:42:57 +00:00
bors-servo
448c7fb2e6
Auto merge of #8482 - frewsxcv:no-mut, r=Ms2ger
...
Remove unnecessary '*_mut' methods
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8482 )
<!-- Reviewable:end -->
2015-11-12 16:44:09 +05:30
Ms2ger
6d2ae85c1f
Use the conversion traits from js.
2015-11-12 10:48:58 +01:00
Ms2ger
acb24e80b8
Use throw_type_error and throw_range_error from js.
2015-11-12 10:20:19 +01:00
Ms2ger
ddaa1a1960
Update js.
2015-11-12 10:20:13 +01:00
Ravi Shankar
c4cf72db6e
Added support for synchronization along with an unit test for cancellation listener
2015-11-12 14:04:38 +05:30
Ravi Shankar
10f5584f78
Implement cancellation listener for cancelling network requests
2015-11-12 14:02:59 +05:30
bors-servo
efc31e619d
Auto merge of #8376 - mrobinson:fix-inlines, r=pcwalton
...
Properly make stacking contexts for inlines
Instead of making a stacking context out of inline fragments parent
flow, make the inline fragment itself the stacking context. This fixes
positioning and rendering of these sort of fragments and prevents
over-layerization.
Fixes #7424 .
Fixes #5812 .
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8376 )
<!-- Reviewable:end -->
2015-11-12 12:26:39 +05:30
Corey Farwell
bfc4ed4cac
Cleanup PageIterator::next
2015-11-12 00:24:19 -05:00
Corey Farwell
1e6d95f750
Remove unnecessary '*_mut' methods
2015-11-12 00:12:39 -05:00
Corey Farwell
94f0478f51
Simplify IterablePage::find
2015-11-12 00:03:53 -05:00
bors-servo
1b20bc90ee
Auto merge of #8476 - frewsxcv:unnecessary-document-notification, r=nox
...
Remove unnecessary 'node changed' notification
This same notification already happens in `CharacterData::SetData`
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8476 )
<!-- Reviewable:end -->
2015-11-12 05:33:19 +05:30
Corey Farwell
1789405883
Remove unnecessary 'node changed' notification
...
This same notification already happens in `CharacterData::SetData`
2015-11-11 17:53:38 -05:00
Martin Robinson
d572f1ca05
Properly make stacking contexts for inlines
...
Instead of making a stacking context out of inline fragments parent
flow, make the inline fragment itself the stacking context. This fixes
positioning and rendering of these sort of fragments and prevents
over-layerization.
Fixes #7424 .
Fixes #5812 .
2015-11-11 14:42:18 -08:00
benshu
7623e89506
Execute XHR timeout callbacks directly. (Fixes #8468.)
2015-11-11 23:12:07 +01:00
bors-servo
12f6ba29a7
Auto merge of #8412 - ecoal95:webidl-sequence-return, r=jdm
...
Add WebIDL sequence return values
And use it for `WebGLRenderingContext::getSupportedExtensions`.
Part of #544
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8412 )
<!-- Reviewable:end -->
2015-11-11 23:15:15 +05:30
Emilio Cobos Álvarez
e33330db4e
Implement WebIDL sequence return value using JS_NewArrayObject1
...
This commits changes the creation of the array to use the length, and
sets the elements later.
Reference implementation:
07ed19e582/js/xpconnect/public/nsTArrayHelpers.h (L16)
2015-11-11 18:30:34 +01:00
Emilio Cobos Álvarez
b740b90b8d
webgl: Implement getSupportedExtensions
2015-11-11 17:13:59 +01:00
Emilio Cobos Álvarez
63aa6862b4
Implement WebIDL sequence return values
2015-11-11 17:13:59 +01:00
bors-servo
01ff78b438
Auto merge of #8466 - frewsxcv:node-value, r=nox
...
Simplify script::dom::node NodeValue implementations
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8466 )
<!-- Reviewable:end -->
2015-11-11 21:43:21 +05:30
bors-servo
5e6efd62c1
Auto merge of #8459 - frewsxcv:namednodemap-iter, r=Ms2ger
...
Simplify iterating over Element attributes
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8459 )
<!-- Reviewable:end -->
2015-11-11 20:19:49 +05:30
Corey Farwell
261ce49423
Simplify script::dom::node NodeValue implementations
2015-11-11 08:53:53 -05:00
Anthony Ramine
acb13dc899
Support variadic interface arguments ( fixes #8159 )
...
We use a RootedVec value in codegen, of which we use the `r()` method to
pass `&[&T]` to the interface methods.
2015-11-11 14:52:21 +01:00
Anthony Ramine
e66a361e08
Do not import union constructors in dom::testbinding
2015-11-11 14:19:36 +01:00
Anthony Ramine
6d72293681
Remove TestBinding::global
...
Use global_root_from_reflector() instead.
2015-11-11 14:19:35 +01:00
Anthony Ramine
f84f16384d
Remove unused parameter in instantiateJSToNativeConversionTemplate()
2015-11-11 14:19:34 +01:00
Anthony Ramine
b290a3161d
Clean up the conversion routines
...
Functions returning `Root<T>` are prefixed by "root_" and the ones returning
`*const T` by "native_".
Functions taking `*mut JSObject` are now suffixed by "_from_object" and the ones
taking `&T` by "_from_reflector".
2015-11-11 14:19:30 +01:00
Corey Farwell
a7c470de09
Simplify iterating over Element attributes
2015-11-10 21:42:48 -05:00
bors-servo
fd5540df62
Auto merge of #8453 - frewsxcv:atoms, r=jdm
...
Prefer Atoms over strs for comparison
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8453 )
<!-- Reviewable:end -->
2015-11-11 06:55:39 +05:30
bors-servo
df81cd7ce9
Auto merge of #8168 - benschulz:xhr-timeout-ordering, r=jdm
...
XHR timeouts use same abstraction as scripts timers. (fixes #3396 )
Alright, this is it. Finally the fix for #3396 . :D
I'll add two comments via reviewable in a second.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8168 )
<!-- Reviewable:end -->
2015-11-11 06:08:28 +05:30
benshu
d27a3244f2
XHR timeouts use same abstraction as scripts timers. ( fixes #3396 )
2015-11-11 00:52:34 +01:00
Michael Howell
d32a2d6cfc
Write reflow results, even with no root node.
...
Fixes #8240
2015-11-10 15:01:46 -07:00
bors-servo
13226f8472
Auto merge of #8381 - bholley:attr_restyle_hints, r=pcwalton
...
Implement attribute restyle hints
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8381 )
<!-- Reviewable:end -->
2015-11-11 01:27:45 +05:30
Bobby Holley
b29369296c
Add ::from_layout_js factory to LayoutNode, LayoutElement, and LayoutDocument.
2015-11-10 11:57:25 -08:00
Bobby Holley
7fa7936657
Implement attribute restyle hints.
...
Fixes #6942 .
2015-11-10 11:57:24 -08:00
Bobby Holley
47744d95ad
Make RESTYLE_SELF imply RESTYLE_DESCENDANTS.
...
This is a temporary workaround for #8438 .
2015-11-10 11:41:28 -08:00
Corey Farwell
55477eb618
Prefer Atoms over strs for comparison
2015-11-10 08:58:57 -05:00
bors-servo
81f094b129
Auto merge of #8447 - frewsxcv:htmltableelement-width-idl-attribute, r=eefriedman
...
Implement 'width' IDL attribute on <table>
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8447 )
<!-- Reviewable:end -->
2015-11-10 12:54:30 +05:30
bors-servo
32a91bc656
Auto merge of #8444 - rilut:patch-2, r=frewsxcv
...
refactor(htmlhrelement.rs): color setter now uses macro
Changed the function in #L44-47 to a macro usage. Fixes #8433 .
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8444 )
<!-- Reviewable:end -->
2015-11-10 12:12:25 +05:30
Bobby Holley
c9704992a9
Factor the name-related fields of Attr into a struct and move it to style.
2015-11-09 21:40:22 -08:00
Bobby Holley
488c1291d4
Hoist AttrValue into style.
2015-11-09 21:40:22 -08:00
Corey Farwell
575b3c3d4b
Implement 'width' IDL attribute on <table>
2015-11-09 23:31:25 -05:00