Commit graph

12153 commits

Author SHA1 Message Date
João Oliveira
fd87c8cb3e make dom_struct derive HeapSizeOf,
closes #7357
2015-08-27 01:17:48 +01:00
bors-servo
af4c3901d8 Auto merge of #7399 - frewsxcv:document.all-tracking-issue, r=jdm
Mention tracking issue for implementing document.all



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7399)
<!-- Reviewable:end -->
2015-08-26 16:43:18 -06:00
Corey Farwell
6650636063 Mention tracking issue for implementing document.all 2015-08-26 18:19:26 -04:00
bors-servo
48945b0fc1 Auto merge of #7397 - Manishearth:doublepointer-meet-fire, r=nox
Remove doublepointer in VirtualMethods, and from_borrowed_ref



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7397)
<!-- Reviewable:end -->
2015-08-26 15:01:12 -06:00
Manish Goregaokar
4678ec16bb remove to_borrowed_ref, fix Activatable 2015-08-27 02:27:42 +05:30
Manish Goregaokar
b33c5427bc Remove doublepointer in VirtualMethods, and from_borrowed_ref
Most of the heavy lifting done by:

```
$ ls *rs | xargs gawk -i inplace '/let .*: &&.*from_borrowed_ref/{sub("&&", "\\&");sub("_borrowed_","_");} {print $0}'
$ ls *rs | xargs gawk -i inplace "/impl.*VirtualMethods/{in_vm=1; sub(/<'a>/,\"\");sub(/&'a /,\"\")} /^}\$/{in_vm=0;} in_vm{\$0=gensub(/\\*self([^.])/,\"self\\\1\",\"g\"); sub(/from_borrowed_ref/,\"from_ref\")} {print}"
```
2015-08-27 02:14:48 +05:30
bors-servo
fa5ad1c6b4 Auto merge of #7392 - mrobinson:layered-separate, r=pcwalton
Split out layered child stacking contexts in display lists

This patch is in preparation for more dynamic layerization of the
pieces of display lists. It also prevents having to sort the children
by z-index multiple times.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7392)
<!-- Reviewable:end -->
2015-08-26 11:38:34 -06:00
Martin Robinson
1c09b1d8aa Split out layered child stacking contexts in display lists
This patch is in preparation for more dynamic layerization of the
pieces of display lists. It also prevents having to sort the children
by z-index multiple times.
2015-08-26 10:20:28 -07:00
bors-servo
98d9203d1c Auto merge of #7032 - Yoric:issue-7031, r=jdm
Issue 7031



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7032)
<!-- Reviewable:end -->
2015-08-26 09:34:42 -06:00
bors-servo
0e78815242 Auto merge of #7386 - Ms2ger:emitter, r=jdm
Remove Emitter::markers.

The vector is filled in and immediately emptied again. It is clearer to
keep the vector in the caller instead.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7386)
<!-- Reviewable:end -->
2015-08-26 08:52:16 -06:00
David Rajchenbach-Teller
ec9502b0de Resolves #7031 - Fix warnings in ./mach test-ref 2015-08-26 16:37:50 +02:00
Ms2ger
18b9532b25 Remove Emitter::markers.
The vector is filled in and immediately emptied again. It is clearer to
keep the vector in the caller instead.
2015-08-26 16:19:01 +02:00
bors-servo
186c1d14d5 Auto merge of #6880 - dzbarsky:rAF, r=jdm
Don't try to unwrap the result of requestAnimationFrame callback



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6880)
<!-- Reviewable:end -->
2015-08-26 08:13:11 -06:00
bors-servo
9e52dd8cee Auto merge of #7378 - Ms2ger:url, r=SimonSapin
Update url.



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7378)
<!-- Reviewable:end -->
2015-08-26 07:18:34 -06:00
bors-servo
5f9097c0b4 Auto merge of #7368 - mbrubeck:closed, r=jdm
Quit when the glutin window closes

Fixes a regression from #7096.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7368)
<!-- Reviewable:end -->
2015-08-26 06:32:27 -06:00
bors-servo
78d72f6a9b Auto merge of #7352 - saratang:issue_7347, r=Ms2ger
BinaryOrPlaintextClassifier::classify_impl does not need to return Option

Fixes for Issue #7347, though I wasn't sure how to test my code afterwards.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7352)
<!-- Reviewable:end -->
2015-08-26 05:53:38 -06:00
bors-servo
06ba2167ba Auto merge of #7360 - wilmoz:ErgonomicSignature, r=Ms2ger
Make handle_potential_webgl_error more ergonomic

https://github.com/servo/servo/issues/7358

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7360)
<!-- Reviewable:end -->
2015-08-26 05:21:42 -06:00
Ms2ger
d75ba49034 Update url. 2015-08-26 13:17:45 +02:00
bors-servo
e1122313f9 Auto merge of #7376 - servo:wpt_20150826, r=Ms2ger
Update web-platform-tests to revision acd60f9e55532f03fc905e61591b7fd7db2f08d1



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7376)
<!-- Reviewable:end -->
2015-08-26 04:19:24 -06:00
Ms2ger
be4f0ad8de Update web-platform-tests to revision acd60f9e55532f03fc905e61591b7fd7db2f08d1 2015-08-26 12:14:08 +02:00
bors-servo
def249b67a Auto merge of #7371 - frewsxcv:enable-ref-test, r=SimonSapin
Enable commented out inline_text_align_* ref test

At some point this test did not work, but now it does

Closes #1575

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7371)
<!-- Reviewable:end -->
2015-08-26 03:20:58 -06:00
Corey Farwell
574e11d70a Enable commented out inline_text_align_* ref test
At some point this test did not work, but now it does

Closes #1575
2015-08-25 23:25:23 -04:00
bors-servo
a1cd27e6a3 Auto merge of #7369 - pcwalton:relative-layer-overflow, r=glennw
layout: Fix calculation of overflow for stacking contexts that contain `position: relative` fragments.

Fixes placement of the header on espn.go.com.

r? @glennw

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7369)
<!-- Reviewable:end -->
2015-08-25 17:16:34 -06:00
Patrick Walton
5c51a6214e layout: Fix calculation of overflow for stacking contexts that contain
`position: relative` fragments.

Fixes placement of the header on espn.go.com.
2015-08-25 15:08:28 -07:00
Matt Brubeck
54e8374b6c Quit when the glutin window closes 2015-08-25 13:32:35 -07:00
bors-servo
ab55e3ec10 Auto merge of #7364 - aweinstock314:update-clipboard-20140825, r=jdm
Update rust-clipboard to a version that works on Windows and Mac.

Possibly completes #5376.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7364)
<!-- Reviewable:end -->
2015-08-25 13:59:45 -06:00
Avi Weinstock
09a20bb0a5 Update rust-clipboard to a version that works on Windows and Mac. 2015-08-25 15:29:29 -04:00
wilmoz
363183d12a Make handle_potential_webgl_error more ergonomic 2015-08-25 13:04:55 -05:00
bors-servo
121110a52a Auto merge of #7362 - wilmoz:ForbidMultilineImports, r=jdm
Forbid multiline imports

https://github.com/servo/servo/issues/7356
2015-08-25 11:29:56 -06:00
wilmoz
63851f2650 Forbid multiline imports 2015-08-25 12:27:42 -05:00
bors-servo
f79220f1a8 Auto merge of #7355 - servo:iframe_size_attributes_vertical_writing_mode, r=pcwalton
Refactor tests/ref/iframe/size_attributes_vertical_writing_mode.html

… to not use an arbitrary 104px offset that just happens to match the reference and relies on incorrect behavior.

See discussion in #7313.

r? @pcwalton

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7355)
<!-- Reviewable:end -->
2015-08-25 10:04:39 -06:00
bors-servo
a109a333f1 Auto merge of #6770 - ecoal95:webgl-again, r=jdm
Add multiple WebGL calls and improve error detection

Since it probably won't merge until multiprocess lands, I plan to use this PR to keep improving WebGL support until it can land.

Main TODOs are integration of tests, since it seems https://github.com/KhronosGroup/WebGL/issues/1105 is going nowhere, adding missing calls and proper painting via native surfaces instead of readback.

I can't resolve conflicts right now because of time but I will do it soon.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6770)
<!-- Reviewable:end -->
2015-08-25 09:23:00 -06:00
ecoal95
6341c77700 webgl: Implement multiple calls and improve error detection
This commit implements WebGL's:
 * cullFace
 * frontFace
 * enable
 * disable
 * depthMask
 * colorMask
 * clearDepth
 * clearStencil
 * depthFunc
 * depthRange
 * hint
 * lineWidth
 * pixelStorei
 * polygonOffset
 * texParameteri
 * texParameterf
 * texImage2D (partially)

It inlines a lot of OpenGL calls to keep the file
`components/canvas/webgl_paint_task.rs` as small as possible while
keeping readability.

It also improves error detection on previous calls, and sets node damage
on the canvas in the drawing calls.

It adds a `TexImage2D` reftest, even though it's not enabled because:
 * WebGL paints the image when it loads (asynchronously), so the reftest doesn't wait for it and it finishes early
 * If we change the source for the base64 src of the image it works as expected in non-headless mode, but the test harness locks
2015-08-25 17:16:46 +02:00
ecoal95
af3310f149 Update gleam to 0.1.9 2015-08-25 17:16:46 +02:00
bors-servo
4d0b4a7b8c Auto merge of #7359 - servo:build, r=jdm
Fix the build.
2015-08-25 08:34:13 -06:00
Ms2ger
13086abfdc Check the return code of cargo build (except on Android). 2015-08-25 16:32:51 +02:00
Ms2ger
bd53792269 Fix the CEF build. 2015-08-25 16:31:58 +02:00
Simon Sapin
97f71bb257 Refactor tests/ref/iframe/size_attributes_vertical_writing_mode.html
… to not use an arbitrary 104px offset that just happens to match the reference
and relies on incorrect behavior.
2015-08-25 12:39:49 +02:00
Sara Tang
8c39e968cd Fixed mismatched type error 2015-08-24 23:11:31 -04:00
Sara Tang
f80ae3402a Fixes for issue #7347 2015-08-24 21:32:16 -04:00
bors-servo
842112c0f3 Auto merge of #7350 - frewsxcv:fix-tidy, r=mbrubeck
Make tidy search for files recursively again

In #7348 `os.walk` was replaced with `os.listdir`. The latter is not
recursive, which results in only the root directory files getting linted

The changes to `ignored_files` are needed because calling `os.walk(".")`
results in `./` getting prefixed before each path

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7350)
<!-- Reviewable:end -->
2015-08-24 18:39:22 -06:00
Corey Farwell
662b64ffe4 Make tidy search for files recursively again
In #7348 `os.walk` was replaced with `os.listdir`. The latter is not
recursive, which results in only the root directory files getting linted

The changes to `ignored_files` are needed because calling `os.walk(".")`
results in `./` getting prefixed before each path
2015-08-24 20:34:01 -04:00
bors-servo
e97d8bd25c Auto merge of #7340 - pcwalton:quotes-none-crash, r=mbrubeck
layout: Don't crash if `quotes: none` is specified and generated content uses quotes.

Avoids a crash on The Verge.

r? @mbrubeck

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7340)
<!-- Reviewable:end -->
2015-08-24 18:01:39 -06:00
Patrick Walton
35c67b22e5 layout: Don't crash if quotes: none is specified and generated content
uses quotes.

Avoids a crash on The Verge.
2015-08-24 17:00:23 -07:00
bors-servo
c790c4d4cd Auto merge of #7348 - jxs:master, r=jdm
update tidy.py remove collect_file_names:

call python os functions inline

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7348)
<!-- Reviewable:end -->
2015-08-24 17:19:02 -06:00
João Oliveira
69ddedc568 update tidy.py remove collect_file_names:
call python os functions inline
2015-08-25 00:05:37 +01:00
bors-servo
b1f0357fce Auto merge of #7118 - g-k:tidy-check-unused-html-files, r=jdm
Add tidy check for unused reftest html files

Refs: https://github.com/servo/servo/issues/7078

Sample output:

```
$ time ./mach test-tidy
tests/ref/background_image_a.html not used or commented out in basic.list
tests/ref/background_image_ref.html not used or commented out in basic.list
tests/ref/canvas_linear_gradient_a.html not used or commented out in basic.list
tests/ref/canvas_linear_gradient_ref.html not used or commented out in basic.list
tests/ref/canvas_radial_gradient_a.html not used or commented out in basic.list
tests/ref/canvas_radial_gradient_ref.html not used or commented out in basic.list
tests/ref/inline_border_a.html not used or commented out in basic.list
tests/ref/inline_border_b.html not used or commented out in basic.list
tests/ref/inline_text_align_a.html not used or commented out in basic.list
tests/ref/inline_text_align_b.html not used or commented out in basic.list
tests/ref/link_style_dynamic_addition.html not used or commented out in basic.list
tests/ref/link_style_dynamic_addition_ref.html not used or commented out in basic.list
tests/ref/overflow_position_abs_inside_normal_a.html not used or commented out in basic.list
tests/ref/overflow_position_abs_inside_normal_b.html not used or commented out in basic.list
tests/ref/overflow_position_abs_simple_a.html not used or commented out in basic.list
tests/ref/overflow_position_abs_simple_b.html not used or commented out in basic.list
tests/ref/position_fixed_a.html not used or commented out in basic.list
tests/ref/position_fixed_b.html not used or commented out in basic.list
tests/ref/position_fixed_simple_a.html not used or commented out in basic.list
tests/ref/position_fixed_simple_b.html not used or commented out in basic.list
tests/ref/position_fixed_static_y_a.html not used or commented out in basic.list
tests/ref/position_fixed_static_y_b.html not used or commented out in basic.list
tests/ref/style_is_in_doc.html not used or commented out in basic.list
tests/ref/style_is_in_doc_ref.html not used or commented out in basic.list
tests/ref/table_specified_width_a.html not used or commented out in basic.list
tests/ref/table_specified_width_ref.html not used or commented out in basic.list
tests/ref/text_decoration_propagation_a.html not used or commented out in basic.list
tests/ref/text_decoration_propagation_b.html not used or commented out in basic.list
tests/ref/text_shadow_multiple_shadows_a.html not used or commented out in basic.list
tests/ref/text_shadow_multiple_shadows_ref.html not used or commented out in basic.list
tests/ref/viewport_percentage_vmin_vmax_b.html not used or commented out in basic.list
tests/ref/viewport_percentage_vw_vh_b.html not used or commented out in basic.list
tests/ref/white_space_intrinsic_sizes_a.html not used or commented out in basic.list
tests/ref/white_space_intrinsic_sizes_ref.html not used or commented out in basic.list
tests/ref/fonts/takao-p-gothic/COPYING.html not used or commented out in basic.list
tests/ref/iframe/multiple_external_child.html not used or commented out in basic.list
...
```

I thought it might be helpful to say which files aren't used in `basic.list`.

`./mach test-tidy` is a second or two slower on my laptop.
Not sure if this counts as a warning or an error that should return 1.
Not sure whether unused file output should go before or after the line specific errors.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7118)
<!-- Reviewable:end -->
2015-08-24 16:03:05 -06:00
bors-servo
abb57c3579 Auto merge of #7342 - connorimes:fix-heartbeats-build, r=larsbergstrom
Fix heartbeats build with new -sys version. Fixes #7328

Updated -sys packages to build from a local copy of the native library source rather than using git submodules.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7342)
<!-- Reviewable:end -->
2015-08-24 15:05:56 -06:00
Connor Imes
bb96710cbf Fix heartbeats build with new -sys version. Fixes #7328 2015-08-24 15:38:45 -05:00
bors-servo
9bb97319a2 Auto merge of #7338 - jxs:master, r=Ms2ger
Move RegisterBindings::RegisterProxyHandlers call into script::init

closes #7336
2015-08-24 11:52:03 -06:00