mirror of
https://github.com/servo/servo.git
synced 2025-06-06 16:45:39 +00:00
18b37e676b
Remove the use of unsafe code in the layout wrappers of the DOM. The main change here is that `unsafe_get()` no longer needs to be an unsafe method, which allows us to transitively remove or reduce unsafe blocks from callers. The function itself is not renamed, because it's still a bit dangerous to start removing the layers of abstraction from actual DOM nodes. In addition `init_style_and_opaque_layout_data` can be merged into `initialize_data`, which removes one more unsafe method. Finally, a "Safety" section is added to some unsafe methods.
113 lines
3.5 KiB
Rust
113 lines
3.5 KiB
Rust
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at https://mozilla.org/MPL/2.0/. */
|
|
|
|
use std::marker::PhantomData;
|
|
|
|
use script_layout_interface::wrapper_traits::LayoutDataTrait;
|
|
use selectors::matching::QuirksMode;
|
|
use style::dom::{TDocument, TNode};
|
|
use style::shared_lock::{
|
|
SharedRwLock as StyleSharedRwLock, SharedRwLockReadGuard as StyleSharedRwLockReadGuard,
|
|
};
|
|
use style::stylist::Stylist;
|
|
|
|
use crate::dom::bindings::root::LayoutDom;
|
|
use crate::dom::document::{Document, LayoutDocumentHelpers};
|
|
use crate::dom::node::{LayoutNodeHelpers, Node, NodeFlags};
|
|
use crate::layout_dom::{ServoLayoutElement, ServoLayoutNode, ServoShadowRoot};
|
|
|
|
// A wrapper around documents that ensures ayout can only ever access safe properties.
|
|
pub struct ServoLayoutDocument<'dom, LayoutDataType: LayoutDataTrait> {
|
|
/// The wrapped private DOM Document
|
|
document: LayoutDom<'dom, Document>,
|
|
|
|
/// A PhantomData that is used to track the type of the stored layout data.
|
|
phantom: PhantomData<LayoutDataType>,
|
|
}
|
|
|
|
impl<'dom, LayoutDataType: LayoutDataTrait> Clone for ServoLayoutDocument<'dom, LayoutDataType> {
|
|
fn clone(&self) -> Self {
|
|
*self
|
|
}
|
|
}
|
|
impl<'dom, LayoutDataType: LayoutDataTrait> Copy for ServoLayoutDocument<'dom, LayoutDataType> {}
|
|
|
|
impl<'ld, LayoutDataType: LayoutDataTrait> ::style::dom::TDocument
|
|
for ServoLayoutDocument<'ld, LayoutDataType>
|
|
{
|
|
type ConcreteNode = ServoLayoutNode<'ld, LayoutDataType>;
|
|
|
|
fn as_node(&self) -> Self::ConcreteNode {
|
|
ServoLayoutNode::from_layout_js(self.document.upcast())
|
|
}
|
|
|
|
fn quirks_mode(&self) -> QuirksMode {
|
|
self.document.quirks_mode()
|
|
}
|
|
|
|
fn is_html_document(&self) -> bool {
|
|
self.document.is_html_document_for_layout()
|
|
}
|
|
|
|
fn shared_lock(&self) -> &StyleSharedRwLock {
|
|
self.document.style_shared_lock()
|
|
}
|
|
}
|
|
|
|
impl<'ld, LayoutDataType: LayoutDataTrait> ServoLayoutDocument<'ld, LayoutDataType> {
|
|
pub fn root_element(&self) -> Option<ServoLayoutElement<'ld, LayoutDataType>> {
|
|
self.as_node()
|
|
.dom_children()
|
|
.flat_map(|n| n.as_element())
|
|
.next()
|
|
}
|
|
|
|
pub fn needs_paint_from_layout(&self) {
|
|
self.document.needs_paint_from_layout()
|
|
}
|
|
|
|
pub fn will_paint(&self) {
|
|
self.document.will_paint()
|
|
}
|
|
|
|
pub fn style_shared_lock(&self) -> &StyleSharedRwLock {
|
|
self.document.style_shared_lock()
|
|
}
|
|
|
|
pub fn shadow_roots(&self) -> Vec<ServoShadowRoot<LayoutDataType>> {
|
|
unsafe {
|
|
self.document
|
|
.shadow_roots()
|
|
.iter()
|
|
.map(|sr| {
|
|
debug_assert!(sr.upcast::<Node>().get_flag(NodeFlags::IS_CONNECTED));
|
|
ServoShadowRoot::from_layout_js(*sr)
|
|
})
|
|
.collect()
|
|
}
|
|
}
|
|
|
|
pub fn flush_shadow_roots_stylesheets(
|
|
&self,
|
|
stylist: &mut Stylist,
|
|
guard: &StyleSharedRwLockReadGuard,
|
|
) {
|
|
unsafe {
|
|
if !self.document.shadow_roots_styles_changed() {
|
|
return;
|
|
}
|
|
self.document.flush_shadow_roots_stylesheets();
|
|
for shadow_root in self.shadow_roots() {
|
|
shadow_root.flush_stylesheets(stylist, guard);
|
|
}
|
|
}
|
|
}
|
|
|
|
pub fn from_layout_js(doc: LayoutDom<'ld, Document>) -> Self {
|
|
ServoLayoutDocument {
|
|
document: doc,
|
|
phantom: PhantomData,
|
|
}
|
|
}
|
|
}
|