Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-07-03 05:23:38 +01:00
Code Issues Projects Releases Packages Wiki Activity
servo/components
History
bors-servo 2bc70e738b
Auto merge of #21139 - kleinph:move-float-clear-outside-mako, r=emilio 
style: Move `float` CSS property outside mako

Hi, I am fairly new to Rust and this is my first contribution to a Rust project.

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21130

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

I'm not sure if the approach with the two enums is good. Please let me know if this can be improved.
Regarding the tests I'm unsure: `tests/wpt/web-platform-tests/css/css-display/display-contents-float-001.html` seems to fail already before this PR, (and the cause is maybe not related to the style property definition).

Also I would like to add some docs, is it allowed to use the descriptions from MDN (https://developer.mozilla.org/en-US/docs/Web/CSS/float).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21139)
<!-- Reviewable:end -->
2018-07-09 22:00:25 -04:00
..
allocator Upgrade to rustc 1.28.0-nightly (b68432d56 2018-06-12) 2018-06-14 04:19:17 +02:00
atoms atoms: Add scroll-position as a static atom. 2018-06-02 12:19:32 +02:00
bluetooth move top_level_browsing_context_id out of embedder msg 2018-05-23 21:46:05 +08:00
bluetooth_traits Update regex to 1.0 2018-07-07 12:03:17 +02:00
canvas Implement instanced WebGL drawing calls (part of #20791) 2018-07-08 10:44:45 +02:00
canvas_traits Implement instanced WebGL drawing calls (part of #20791) 2018-07-08 10:44:45 +02:00
compositing Remove components/nonzero, use std::num::NonZero instead 2018-06-16 00:14:41 +02:00
config Automatically provide a resource reader for tests 2018-04-30 22:19:33 +08:00
constellation Auto merge of #20891 - KiChjang:reversed-bc-iter, r=asajeffrey 2018-06-13 15:06:46 -04:00
debugger Bump env_logger to 0.5 and log to 0.4 in every servo crate 2018-03-28 19:50:58 +02:00
deny_public_fields Update Webrender 2018-04-25 10:25:21 +02:00
devtools Bump env_logger to 0.5 and log to 0.4 in every servo crate 2018-03-28 19:50:58 +02:00
devtools_traits Bump ipc-channel and bincode 2018-03-21 13:05:47 +01:00
dom_struct Assert that DOM structs have the correct first field 2018-07-03 09:39:29 -07:00
domobject_derive Update Webrender 2018-04-25 10:25:21 +02:00
embedder_traits improve spec compliance of window.close 2018-06-04 15:02:23 +08:00
fallible
geometry alias some euclid types 2018-03-16 14:34:29 +08:00
gfx Remove debugging println from a year ago 2018-07-02 13:25:44 +02:00
gfx_traits
hashglobe Bump ipc-channel and bincode 2018-03-21 13:05:47 +01:00
jstraceable_derive Update Webrender 2018-04-25 10:25:21 +02:00
layout Fix servo build. 2018-07-01 00:54:30 +02:00
layout_thread layout: script: Fix build. 2018-06-23 20:34:10 +02:00
layout_traits Bump ipc-channel and bincode 2018-03-21 13:05:47 +01:00
malloc_size_of style: Upgrade cssparser. 2018-07-01 00:07:36 +02:00
malloc_size_of_derive Update Webrender 2018-04-25 10:25:21 +02:00
metrics added spec comments 2018-04-11 21:29:03 +01:00
msg Remove components/nonzero, use std::num::NonZero instead 2018-06-16 00:14:41 +02:00
net Auto merge of #20892 - gw3583:update-wr, r=mbrubeck 2018-06-26 17:27:31 -04:00
net_traits move msg to embedder_traits, use in script, handle send error in embedder 2018-05-23 21:45:57 +08:00
profile Update regex to 1.0 2018-07-07 12:03:17 +02:00
profile_traits Measure cache memory usage (#19251): 2018-04-01 13:30:57 -04:00
rand Bump env_logger to 0.5 and log to 0.4 in every servo crate 2018-03-28 19:50:58 +02:00
range
remutex Remove components/nonzero, use std::num::NonZero instead 2018-06-16 00:14:41 +02:00
script Auto merge of #21120 - paavininanda:HTMLSourceElementIDL_attributes, r=jdm 2018-07-09 20:47:09 -04:00
script_layout_interface Fix servo build. 2018-07-01 00:54:30 +02:00
script_plugins Upgrade to rustc 1.29.0-nightly (e06c87544 2018-07-06) 2018-07-07 12:53:39 +02:00
script_traits improve spec compliance of window.close 2018-06-04 15:02:23 +08:00
selectors style: Make :host() and ::slotted() account for the inner selector's specificity. 2018-07-01 00:09:08 +02:00
servo Remove components/nonzero, use std::num::NonZero instead 2018-06-16 00:14:41 +02:00
servo_arc style: Fix tidy issues and Servo build. 2018-04-29 05:09:43 +02:00
size_of_test
style Auto merge of #21139 - kleinph:move-float-clear-outside-mako, r=emilio 2018-07-09 22:00:25 -04:00
style_derive style: Better debugging for media-query related code and ua-cache. 2018-06-23 20:37:16 +02:00
style_traits style: Upgrade cssparser. 2018-07-01 00:07:36 +02:00
url Fix building servo_url by itself 2018-04-19 17:01:14 +02:00
webdriver_server Update regex to 1.0 2018-07-07 12:03:17 +02:00
webvr Bump env_logger to 0.5 and log to 0.4 in every servo crate 2018-03-28 19:50:58 +02:00
webvr_traits Bump ipc-channel and bincode 2018-03-21 13:05:47 +01:00