Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-07-02 13:03:43 +01:00
Code Issues Projects Releases Packages Wiki Activity
servo/components/style
History
bors-servo 2bc70e738b
Auto merge of #21139 - kleinph:move-float-clear-outside-mako, r=emilio 
style: Move `float` CSS property outside mako

Hi, I am fairly new to Rust and this is my first contribution to a Rust project.

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21130

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

I'm not sure if the approach with the two enums is good. Please let me know if this can be improved.
Regarding the tests I'm unsure: `tests/wpt/web-platform-tests/css/css-display/display-contents-float-001.html` seems to fail already before this PR, (and the cause is maybe not related to the style property definition).

Also I would like to add some docs, is it allowed to use the descriptions from MDN (https://developer.mozilla.org/en-US/docs/Web/CSS/float).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21139)
<!-- Reviewable:end -->
2018-07-09 22:00:25 -04:00
..
counter_style style: Move the error reporter into ParserContext. 2018-06-23 20:36:23 +02:00
gecko style: Cap the number of style threads at six. 2018-07-09 03:04:01 +02:00
gecko_bindings style: Change nscolor to StyleComplexColor in nsCSSShadowItem. 2018-07-01 00:03:11 +02:00
gecko_string_cache Store nsDynamicAtom's chars after the end of the object. 2018-06-23 20:36:41 +02:00
invalidation Run rustfmt on selectors, servo_arc, and style. 2018-04-10 17:35:15 -07:00
media_queries style: Appease tidy. 2018-07-01 01:01:46 +02:00
properties Auto merge of #21139 - kleinph:move-float-clear-outside-mako, r=emilio 2018-07-09 22:00:25 -04:00
rule_tree style: Update StyleSource to use ArcUnion. 2018-04-29 03:28:32 +02:00
servo style: Fix build / unit tests. 2018-07-01 00:54:30 +02:00
sharing style: Fix the broken invariants of the rule node cache. 2018-06-23 20:34:50 +02:00
stylesheets style: Remove location from preludes and take it from argument. 2018-07-01 00:07:20 +02:00
values style: Move float CSS property outside mako 2018-07-09 12:47:07 +02:00
animation.rs style: Move TransitionProperty where it belongs. 2018-06-12 12:15:05 -07:00
applicable_declarations.rs style: Update StyleSource to use ArcUnion. 2018-04-29 03:28:32 +02:00
attr.rs Run rustfmt on selectors, servo_arc, and style. 2018-04-10 17:35:15 -07:00
author_styles.rs Run rustfmt on selectors, servo_arc, and style. 2018-04-10 17:35:15 -07:00
bezier.rs Run rustfmt on selectors, servo_arc, and style. 2018-04-10 17:35:15 -07:00
bloom.rs Run rustfmt on selectors, servo_arc, and style. 2018-04-10 17:35:15 -07:00
build.rs Run rustfmt on selectors, servo_arc, and style. 2018-04-10 17:35:15 -07:00
build_gecko.rs style: Use RUSTFMT env in stylo build script. 2018-07-01 00:07:01 +02:00
Cargo.toml Update regex to 1.0 2018-07-07 12:03:17 +02:00
context.rs Run rustfmt on selectors, servo_arc, and style. 2018-04-10 17:35:15 -07:00
custom_properties.rs Run rustfmt on selectors, servo_arc, and style. 2018-04-10 17:35:15 -07:00
data.rs Run rustfmt on selectors, servo_arc, and style. 2018-04-10 17:35:15 -07:00
dom.rs style: Make element-backed pseudos inherit from NAC subtree roots and other NAC inherit from their parents. 2018-06-02 12:07:07 +02:00
dom_apis.rs style: Optimize QuerySelector in shadow trees. 2018-05-28 16:02:31 +02:00
driver.rs Run rustfmt on selectors, servo_arc, and style. 2018-04-10 17:35:15 -07:00
element_state.rs style: Appease tidy. 2018-07-01 01:01:46 +02:00
encoding_support.rs style: Fix servo build. 2018-06-23 20:34:10 +02:00
error_reporting.rs style: Better debugging for stylesheets and URLs. 2018-06-23 20:37:03 +02:00
font_face.rs style: Move the error reporter into ParserContext. 2018-06-23 20:36:23 +02:00
font_metrics.rs Run rustfmt on selectors, servo_arc, and style. 2018-04-10 17:35:15 -07:00
hash.rs Run rustfmt on selectors, servo_arc, and style. 2018-04-10 17:35:15 -07:00
lib.rs style: Remove some unneeded cfg(..). 2018-05-05 17:53:22 +02:00
logical_geometry.rs Run rustfmt on selectors, servo_arc, and style. 2018-04-10 17:35:15 -07:00
macros.rs style: Add a ValueInfo trait for exposing types needed by devtools. 2018-04-29 03:28:34 +02:00
matching.rs style: Make element-backed pseudos inherit from NAC subtree roots and other NAC inherit from their parents. 2018-06-02 12:07:07 +02:00
parallel.rs Run rustfmt on selectors, servo_arc, and style. 2018-04-10 17:35:15 -07:00
parser.rs style: Move the error reporter into ParserContext. 2018-06-23 20:36:23 +02:00
README.md
rule_cache.rs style: Update StyleSource to use ArcUnion. 2018-04-29 03:28:32 +02:00
scoped_tls.rs
selector_map.rs style: Add namespace bucket for the selector map. 2018-07-01 00:05:12 +02:00
selector_parser.rs Run rustfmt on selectors, servo_arc, and style. 2018-04-10 17:35:15 -07:00
shared_lock.rs style: Remove ServoStyleSheet usage. 2018-05-05 16:22:47 +02:00
str.rs Run rustfmt on selectors, servo_arc, and style. 2018-04-10 17:35:15 -07:00
style_adjuster.rs style: Make StyleStruct.name_lower snake case. 2018-06-23 20:35:49 +02:00
style_resolver.rs style: Make element-backed pseudos inherit from NAC subtree roots and other NAC inherit from their parents. 2018-06-02 12:07:07 +02:00
stylesheet_set.rs style: Allow placeholder import sheets. 2018-04-17 20:01:27 +02:00
stylist.rs style: Better debugging for media-query related code and ua-cache. 2018-06-23 20:37:16 +02:00
thread_state.rs Bump bitflags to 1.0 in every servo crate 2017-10-30 23:36:06 +01:00
timer.rs Run rustfmt on selectors, servo_arc, and style. 2018-04-10 17:35:15 -07:00
traversal.rs style: Make element-backed pseudos inherit from NAC subtree roots and other NAC inherit from their parents. 2018-06-02 12:07:07 +02:00
traversal_flags.rs style: Get rid of unstyled children only traversals. 2017-11-20 08:24:08 +01:00

README.md

servo-style

Style system for Servo, using rust-cssparser for parsing.