mirror of
https://github.com/servo/servo.git
synced 2025-08-04 21:20:23 +01:00
c8d9aad3e3
Fix absolute descendents being replaced when retreiving root <!-- Please describe your changes on the following line: --> The cause of #16410 is because calling `try_get_layout_root` will replace its `abs_descendants` even itself isn't absolute positioned. So I pushed them instead if the root isn't absolute. Also add a few docs and comments to help understand how block size of absolute flow is being calculated. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #16410 (GitHub issue number if applicable) <!-- Either: --> - [x] There are tests for these changes: Reduced testcase from the issue. ```html <style> html { min-height: 100%; position: relative; } div { position: absolute; bottom: 0; width: 100%; height: 25px; border: 1px solid black; } </style> <div> </div> ``` <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> |
||
|---|---|---|
| .. | ||
| allocator | ||
| atoms | ||
| background_hang_monitor | ||
| bluetooth | ||
| bluetooth_traits | ||
| canvas | ||
| canvas_traits | ||
| compositing | ||
| config | ||
| config_plugins | ||
| constellation | ||
| deny_public_fields | ||
| derive_common | ||
| devtools | ||
| devtools_traits | ||
| dom_struct | ||
| domobject_derive | ||
| embedder_traits | ||
| fallible | ||
| geometry | ||
| gfx | ||
| gfx_traits | ||
| hashglobe | ||
| jstraceable_derive | ||
| layout | ||
| layout_2020 | ||
| layout_thread | ||
| layout_thread_2020 | ||
| layout_traits | ||
| malloc_size_of | ||
| media | ||
| metrics | ||
| msg | ||
| net | ||
| net_traits | ||
| pixels | ||
| profile | ||
| profile_traits | ||
| rand | ||
| range | ||
| remutex | ||
| script | ||
| script_layout_interface | ||
| script_plugins | ||
| script_traits | ||
| selectors | ||
| servo | ||
| servo_arc | ||
| size_of_test | ||
| std_test_override | ||
| style | ||
| style_derive | ||
| style_traits | ||
| to_shmem | ||
| to_shmem_derive | ||
| url | ||
| webdriver_server | ||
| webgpu | ||
| webrender_surfman | ||
| webrender_traits | ||