mirror of
https://github.com/servo/servo.git
synced 2025-06-06 16:45:39 +00:00
c8d9aad3e3
Fix absolute descendents being replaced when retreiving root <!-- Please describe your changes on the following line: --> The cause of #16410 is because calling `try_get_layout_root` will replace its `abs_descendants` even itself isn't absolute positioned. So I pushed them instead if the root isn't absolute. Also add a few docs and comments to help understand how block size of absolute flow is being calculated. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #16410 (GitHub issue number if applicable) <!-- Either: --> - [x] There are tests for these changes: Reduced testcase from the issue. ```html <style> html { min-height: 100%; position: relative; } div { position: absolute; bottom: 0; width: 100%; height: 25px; border: 1px solid black; } </style> <div> </div> ``` <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> |
||
|---|---|---|
| .. | ||
| display_list | ||
| tests | ||
| block.rs | ||
| Cargo.toml | ||
| construct.rs | ||
| context.rs | ||
| data.rs | ||
| flex.rs | ||
| floats.rs | ||
| flow.rs | ||
| flow_list.rs | ||
| flow_ref.rs | ||
| fragment.rs | ||
| generated_content.rs | ||
| incremental.rs | ||
| inline.rs | ||
| layout_debug.rs | ||
| lib.rs | ||
| linked_list.rs | ||
| list_item.rs | ||
| model.rs | ||
| multicol.rs | ||
| opaque_node.rs | ||
| parallel.rs | ||
| persistent_list.rs | ||
| query.rs | ||
| sequential.rs | ||
| table.rs | ||
| table_caption.rs | ||
| table_cell.rs | ||
| table_colgroup.rs | ||
| table_row.rs | ||
| table_rowgroup.rs | ||
| table_wrapper.rs | ||
| text.rs | ||
| traversal.rs | ||
| wrapper.rs | ||