mirror of
https://github.com/servo/servo.git
synced 2025-07-24 15:50:21 +01:00
e2d980a071
Prefix `on` for function name of inline events While checking what needs to be done for the spec-update, I've noticed the logic of checking `is window-reflecting element (e.g. body and frameset)` is already handled by the `is` casting function. However, we still failed to pass the tests because we're missing `on` prefix for inline functions. I'm not sure if this patch is good enough (or maybe at least I need to add a comment for why adding `on` prefix?). Besides, I checked [how Gecko handles](https://searchfox.org/mozilla-central/rev/8bc4e35c9bb47c1fe3131e6155d9f482e1efef9a/dom/events/EventListenerManager.cpp#1012-1022) and looks like they also just pass the atom directly. But, the [generated atom](https://searchfox.org/mozilla-central/source/__GENERATED__/xpcom/ds/nsGkAtomList.h#775) is prefixed with `on` which is correct to just pass it into the `CompileFunction`. --- <!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: --> - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #26479 - [x] There are tests for these changes <!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.--> <!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. --> |
||
|---|---|---|
| .. | ||
| docs | ||
| dom | ||
| task_source | ||
| animation_timeline.rs | ||
| animations.rs | ||
| body.rs | ||
| build.rs | ||
| canvas_state.rs | ||
| Cargo.toml | ||
| clipboard_provider.rs | ||
| devtools.rs | ||
| document_loader.rs | ||
| euclidext.rs | ||
| fetch.rs | ||
| image_listener.rs | ||
| init.rs | ||
| layout_image.rs | ||
| lib.rs | ||
| mem.rs | ||
| microtask.rs | ||
| network_listener.rs | ||
| realms.rs | ||
| script_module.rs | ||
| script_runtime.rs | ||
| script_thread.rs | ||
| serviceworker_manager.rs | ||
| stylesheet_loader.rs | ||
| stylesheet_set.rs | ||
| task.rs | ||
| task_manager.rs | ||
| task_queue.rs | ||
| test.rs | ||
| textinput.rs | ||
| timers.rs | ||
| unpremultiplytable.rs | ||
| webdriver_handlers.rs | ||