Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-02 20:20:14 +01:00
Code Issues Projects Releases Packages Wiki Activity
servo/components
History
bors-servo f65cb94b9e
Auto merge of #24674 - servo:jdm-patch-34, r=nox 
Correct inverted logic for available image checks.

From https://html.spec.whatwg.org/multipage/images.html#updating-the-image-data:
Step 3 says to initialize selected source to null.
Step 4 says to set the selected source to the image element's src value if it's not using responsive images and it has a non-empty src value.
Step 6 performs some steps if selected source is not null.

The existing code tried to do the step 6 check in a roundabout way which caused us to always check for an available image when using responsive images, which is incorrect. The new code is easier to read and matches the specification text.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests because it's not worth writing a test to verify that an image cache check that would always fail does not happen.
2019-11-13 19:19:59 -05:00
..
allocator
atoms Update rand to 0.7 (fixes #24448) 2019-10-23 15:34:48 +02:00
background_hang_monitor Use surfman for managing GL surfaces 2019-11-01 08:47:11 -05:00
bluetooth Update rand to 0.7 (fixes #24448) 2019-10-23 15:34:48 +02:00
bluetooth_traits Update ipc-channel and related dependencies 2019-08-27 23:44:04 +02:00
canvas Auto merge of #24676 - Manishearth:unpatch, r=jdm 2019-11-11 19:25:22 -05:00
canvas_traits Addresses issues raised in #24465; removes redundancy in set_bitmap_dimensions 2019-11-10 18:37:14 -05:00
compositing Properly set event.buttons value on mousemove 2019-11-11 16:00:44 +01:00
config Allow setting Visual Studio logger level from cli arg 2019-10-28 17:29:20 +01:00
config_plugins Bump all in-tree components to syn 1 2019-09-27 13:29:55 +02:00
constellation Properly set event.buttons value on mousemove 2019-11-11 16:00:44 +01:00
debugger Update to url 2.0 2019-08-17 10:03:44 +02:00
deny_public_fields Bump all in-tree components to syn 1 2019-09-27 13:29:55 +02:00
derive_common derive_common: Fix example in documentation 2019-11-07 18:52:30 -06:00
devtools Update rand to 0.7 (fixes #24448) 2019-10-23 15:34:48 +02:00
devtools_traits Update ipc-channel and related dependencies 2019-08-27 23:44:04 +02:00
dom_struct Remove redundant webidl_must_inherit compiler plugin lint 2019-09-29 23:11:40 +02:00
domobject_derive Bump all in-tree components to syn 1 2019-09-27 13:29:55 +02:00
embedder_traits Remove unused dependencies 2019-10-01 21:15:53 +09:00
fallible
geometry Fix some warnings new in Rust Nightly 2019-11-08 11:45:16 +01:00
gfx Use xml-rs instead of rcdom for Android font list parsing 2019-10-23 15:34:48 +02:00
gfx_traits Replace DisplayList::is_contentful with tracking during conversion to WR display lists 2019-09-06 17:15:53 +02:00
hashglobe Fix some warnings new in Rust Nightly 2019-11-08 11:45:16 +01:00
jstraceable_derive Bump all in-tree components to syn 1 2019-09-27 13:29:55 +02:00
layout dom: Calculate the viewport size of iframes when they are first added to the tree. 2019-11-06 16:13:55 -05:00
layout_2020 dom: Calculate the viewport size of iframes when they are first added to the tree. 2019-11-06 16:13:55 -05:00
layout_thread Ensure layout/script always have a correct viewport size when a new pipeline is created. 2019-11-06 16:13:55 -05:00
layout_thread_2020 Ensure layout/script always have a correct viewport size when a new pipeline is created. 2019-11-06 16:13:55 -05:00
layout_traits Ensure layout/script always have a correct viewport size when a new pipeline is created. 2019-11-06 16:13:55 -05:00
malloc_size_of Fix Gecko build. 2019-11-04 13:43:20 +01:00
media Remove unused dependencies 2019-10-01 21:15:53 +09:00
metrics Replace DisplayList::is_contentful with tracking during conversion to WR display lists 2019-09-06 17:15:53 +02:00
msg continue messageport, transferable, postmessage options 2019-10-19 14:28:18 +08:00
net Use HSTS preload list for private HttpState, too. 2019-11-10 20:16:53 +01:00
net_traits Update rand to 0.7 (fixes #24448) 2019-10-23 15:34:48 +02:00
pixels Addresses issues raised in #24465; removes redundancy in set_bitmap_dimensions 2019-11-10 18:37:14 -05:00
profile begin messageport, transferable objects, impl 2019-10-19 14:12:22 +08:00
profile_traits begin messageport, transferable objects, impl 2019-10-19 14:12:22 +08:00
rand Update rand to 0.7 (fixes #24448) 2019-10-23 15:34:48 +02:00
range
remutex
script Auto merge of #24674 - servo:jdm-patch-34, r=nox 2019-11-13 19:19:59 -05:00
script_layout_interface Fix some warnings new in Rust Nightly 2019-11-08 11:45:16 +01:00
script_plugins Upgrade to rustc 1.40.0-nightly (246be7e1a 2019-10-25) 2019-10-26 13:03:49 +02:00
script_traits Implement srcdoc support for iframes. 2019-11-12 13:57:54 -05:00
selectors style: Remove some XBL code in the style system. 2019-11-04 13:36:32 +01:00
servo Update surfman to use Git version 2019-11-11 12:29:05 -08:00
servo_arc style: Properly refcount-log UniqueArcs created with new_uninitialized(). 2019-07-24 14:52:53 +02:00
size_of_test
std_test_override
style Fix some warnings new in Rust Nightly 2019-11-08 11:45:16 +01:00
style_derive Bump all in-tree components to syn 1 2019-09-27 13:29:55 +02:00
style_traits style: Use serde to serialize LengthPercentage and StyleRayFunction. 2019-11-04 13:36:32 +01:00
to_shmem Update rand to 0.7 (fixes #24448) 2019-10-23 15:34:48 +02:00
to_shmem_derive Bump all in-tree components to syn 1 2019-09-27 13:29:55 +02:00
url Update rand to 0.7 (fixes #24448) 2019-10-23 15:34:48 +02:00
webdriver_server Update rand to 0.7 (fixes #24448) 2019-10-23 15:34:48 +02:00
webrender_traits
webvr Remove unused dependencies 2019-10-01 21:15:53 +09:00
webvr_traits Replace use of gleam in webgl with sparkle. 2019-09-11 11:40:04 -04:00