mirror of
https://github.com/servo/servo.git
synced 2025-07-28 09:40:33 +01:00
f65cb94b9e
Correct inverted logic for available image checks. From https://html.spec.whatwg.org/multipage/images.html#updating-the-image-data: Step 3 says to initialize selected source to null. Step 4 says to set the selected source to the image element's src value if it's not using responsive images and it has a non-empty src value. Step 6 performs some steps if selected source is not null. The existing code tried to do the step 6 check in a roundabout way which caused us to always check for an available image when using responsive images, which is incorrect. The new code is easier to read and matches the specification text. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes do not require tests because it's not worth writing a test to verify that an image cache check that would always fail does not happen. |
||
|---|---|---|
| .. | ||
| docs | ||
| dom | ||
| task_source | ||
| body.rs | ||
| build.rs | ||
| canvas_state.rs | ||
| Cargo.toml | ||
| clipboard_provider.rs | ||
| compartments.rs | ||
| devtools.rs | ||
| document_loader.rs | ||
| euclidext.rs | ||
| fetch.rs | ||
| image_listener.rs | ||
| init.rs | ||
| layout_image.rs | ||
| lib.rs | ||
| mem.rs | ||
| microtask.rs | ||
| network_listener.rs | ||
| script_runtime.rs | ||
| script_thread.rs | ||
| serviceworker_manager.rs | ||
| serviceworkerjob.rs | ||
| stylesheet_loader.rs | ||
| stylesheet_set.rs | ||
| task.rs | ||
| task_manager.rs | ||
| task_queue.rs | ||
| test.rs | ||
| textinput.rs | ||
| timers.rs | ||
| unpremultiplytable.rs | ||
| webdriver_handlers.rs | ||