Commit graph

30180 commits

Author SHA1 Message Date
bors-servo
0047c77f03 Auto merge of #19126 - emilio:source-size-list, r=nox
style: Introduce SourceSizeList.

This is part of the work for https://bugzilla.mozilla.org/show_bug.cgi?id=1408308.

But this can just land now IMO, before I do the integration bits.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19126)
<!-- Reviewable:end -->
2017-11-06 09:37:14 -06:00
Emilio Cobos Álvarez
3fa75bbdf6
style: Introduce SourceSizeList.
MozReview-Commit-ID: 9QMF45VcBFB
2017-11-06 16:36:41 +01:00
Emilio Cobos Álvarez
001c50bcca
style: Simplify a bit media query construction.
MozReview-Commit-ID: 3eqezFFWgNZ
2017-11-06 13:51:53 +01:00
bors-servo
41a5a8c75f Auto merge of #19115 - tigercosmos:overflow, r=jdm
fix overflow_y_is_visible() in `element.rs`

<!-- Please describe your changes on the following line: -->
I think the original logic of `overflow_y_is_visible()` might be wrong.
So fix it to the correct logic, and also pass more tests.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19115)
<!-- Reviewable:end -->
2017-11-06 06:50:13 -06:00
bors-servo
88505dc2ff Auto merge of #19124 - glennw:update-wr-csg, r=jdm
Update WR (removal of clip-scroll groups and packed layers).

This shouldn't have any visual effect on Servo - it's an
important internal optimization and simplification though.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19124)
<!-- Reviewable:end -->
2017-11-05 21:32:59 -06:00
Glenn Watson
71f8ac2496 Update WR (removal of clip-scroll groups and packed layers).
This shouldn't have any visual effect on Servo - it's an
important internal optimization and simplification though.
2017-11-06 12:32:37 +10:00
tigercosmos
ea3d8972df fix overflow_y_is_visible() 2017-11-06 10:24:00 +08:00
bors-servo
644e574e1b Auto merge of #19123 - glennw:update-wr-border, r=emilio
Update WR (border artifact fix, native font support on Linux).

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19123)
<!-- Reviewable:end -->
2017-11-05 17:11:40 -06:00
Glenn Watson
6623d789ce Update WR (border artifact fix, native font support on Linux). 2017-11-06 06:34:08 +10:00
bors-servo
42c8fd292a Auto merge of #19105 - mstange:move-fsbgcolor, r=emilio`
Bug 1414147 - Move fontSmoothingBackgroundColor from nsStyleUserInterface to nsFont, stylo changes.

<!-- Please describe your changes on the following line: -->

This will need to land in concert with [bug 1414147](https://bugzilla.mozilla.org/show_bug.cgi?id=1414147). Please don't r+ until the patch in that bug has been r+ed.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because they are required to make the Gecko build pass

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19105)
<!-- Reviewable:end -->
2017-11-05 08:22:24 -06:00
bors-servo
8035679858 Auto merge of #19116 - servo:cla-doc-link, r=KiChjang
Fix dead link in COMMAND_LINE_ARGS.md

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19116)
<!-- Reviewable:end -->
2017-11-04 15:58:27 -05:00
Alex Touchet
fefd06da02
Fix dead link in COMMAND_LINE_ARGS.md 2017-11-04 13:07:19 -07:00
Markus Stange
c439475b66 Bug 1414147 - Move fontSmoothingBackgroundColor from nsStyleUserInterface to nsFont, stylo changes. 2017-11-04 12:46:03 -04:00
bors-servo
0f5325d0a7 Auto merge of #19113 - emilio:qsa, r=xidorn,bz
Reland #19108, because it was backed out before its Gecko-side patches could land.
2017-11-04 05:36:17 -05:00
Emilio Cobos Álvarez
72567505d9
style: Update bindings.
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
2017-11-04 11:34:41 +01:00
Emilio Cobos Álvarez
18ac41fe87
style: Inline a bunch of stuff, fixup indentation of a couple things.
MozReview-Commit-ID: CgUNMeBDOCw
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
2017-11-04 11:34:40 +01:00
Emilio Cobos Álvarez
c414e90b20
style: Inline DomDescendants.
MozReview-Commit-ID: HeBxicDHlzt
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
2017-11-04 11:34:40 +01:00
Emilio Cobos Álvarez
f32f09656b
style: Allow disabling invalidation-based querySelector from C++
Rust compile times are hard.

MozReview-Commit-ID: 9Xhtf7f3Vzv
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
2017-11-04 11:34:40 +01:00
Emilio Cobos Álvarez
afb09536f9
style: Remove some unneeded indirections in the invalidation code.
MozReview-Commit-ID: 5h5SE3ieC0A
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
2017-11-04 11:34:39 +01:00
Emilio Cobos Álvarez
f0999365e2
style: Bump the selector length heuristic.
A selector with combinators has to have length > 2 (a component, a combinator,
another component).

MozReview-Commit-ID: GvMEbRdOVi2
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
2017-11-04 11:34:39 +01:00
Emilio Cobos Álvarez
72ec0392a4
style: Add a query-selector fast path for #id foo.
MozReview-Commit-ID: DkrLcfQLPga
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
2017-11-04 11:34:38 +01:00
Emilio Cobos Álvarez
dbfc1eb3e0
style: Extract a bit better the logic for finding elements with an ID under a subtree.
MozReview-Commit-ID: Hj9yxBk1OvS
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
2017-11-04 11:34:38 +01:00
Emilio Cobos Álvarez
0032d04bcf
style: Optimize all ids in the rightmost compound selector.
This is effectively the same optimization Gecko has now.

MozReview-Commit-ID: 21HrjpHdpOz
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
2017-11-04 11:34:38 +01:00
Emilio Cobos Álvarez
60aec43dad
style: Add a fast path for querySelector/All with a single id selector using the doc ID table.
MozReview-Commit-ID: JVnDO890kn4
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
2017-11-04 11:34:37 +01:00
Emilio Cobos Álvarez
f993693eb2
style: Introduce TNode::is_in_document.
MozReview-Commit-ID: BrhhoOghtUL
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
2017-11-04 11:34:37 +01:00
Emilio Cobos Álvarez
93272f46a5
style: Move the single simple selector optimizations to a different function.
MozReview-Commit-ID: EEM3AzW2A9s
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
2017-11-04 11:34:36 +01:00
Emilio Cobos Álvarez
2783297fa9
style: Add a Document::elements_with_id API.
MozReview-Commit-ID: BNtbJp0RI68
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
2017-11-04 11:34:36 +01:00
bors-servo
3b0940342c Auto merge of #19112 - moz-servo-sync:gecko-backout, r=moz-servo-sync
Backed out changeset dbd300f4d75b for build bustage. r=backout on a CLOSED TREE

Backed out changeset dbd300f4d75b for build bustage. r=backout on a CLOSED TREE

Backs out https://github.com/servo/servo/pull/19108

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19112)
<!-- Reviewable:end -->
2017-11-03 22:11:40 -05:00
Gecko Backout
8f8fd517ed Backed out changeset dbd300f4d75b for build bustage. r=backout on a CLOSED TREE
Backs out https://github.com/servo/servo/pull/19108
2017-11-03 23:56:42 +00:00
bors-servo
a0cd781bdc Auto merge of #19108 - emilio:qsa, r=xidorn,bz
stylo: querySelector{,All} optimizations.

Bug: 1410624

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19108)
<!-- Reviewable:end -->
2017-11-03 14:27:34 -05:00
Emilio Cobos Álvarez
15ef6b0d8a
style: Update bindings. 2017-11-03 20:25:01 +01:00
bors-servo
107ead64d0 Auto merge of #19101 - CYBAI:moz-script-level-out-of-mako, r=emilio
style: Move font -moz-script-level outside of mako

This is a sub-PR of #19015
r? emilio

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #19068 (github issue number if applicable).
- [x] These changes do not require tests because _____

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19101)
<!-- Reviewable:end -->
2017-11-03 11:09:39 -05:00
bors-servo
4df647ed75 Auto merge of #19017 - tigercosmos:test, r=jdm
Print the full path for errors occurring in the servo crate

<!-- Please describe your changes on the following line: -->
`Cargo` will print the path where it runs.
Origin python script `cd` into the crate folder, so the root path is set in  the crate.
Now I use `--manifest-path PATH` to `cargo build`, so the root path is at `servo`.

Origin path in error message:
```
error: expected one of `!` or `::`, found `#`
  --> lib.rs:24:1
```

Now it would be:
```
error: expected one of `!` or `::`, found `use`
  --> ports/geckolib/glue.rs:11:1
```

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #9895 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19017)
<!-- Reviewable:end -->
2017-11-03 09:05:17 -05:00
Emilio Cobos Álvarez
bcc9c62620
style: Inline a bunch of stuff, fixup indentation of a couple things.
MozReview-Commit-ID: CgUNMeBDOCw
2017-11-03 14:18:49 +01:00
Emilio Cobos Álvarez
e7149f15d7
style: Inline DomDescendants.
MozReview-Commit-ID: HeBxicDHlzt
2017-11-03 14:18:48 +01:00
Emilio Cobos Álvarez
bfabd9f855
style: Allow disabling invalidation-based querySelector from C++
Rust compile times are hard.

MozReview-Commit-ID: 9Xhtf7f3Vzv
2017-11-03 14:18:48 +01:00
Emilio Cobos Álvarez
931aae9760
style: Remove some unneeded indirections in the invalidation code.
MozReview-Commit-ID: 5h5SE3ieC0A
2017-11-03 14:18:47 +01:00
Emilio Cobos Álvarez
9a378a89b4
style: Bump the selector length heuristic.
A selector with combinators has to have length > 2 (a component, a combinator,
another component).

MozReview-Commit-ID: GvMEbRdOVi2
2017-11-03 14:18:46 +01:00
Emilio Cobos Álvarez
eea8ecd345
style: Add a query-selector fast path for #id foo.
MozReview-Commit-ID: DkrLcfQLPga
2017-11-03 14:18:45 +01:00
Emilio Cobos Álvarez
ea8f493ae6
style: Extract a bit better the logic for finding elements with an ID under a subtree.
MozReview-Commit-ID: Hj9yxBk1OvS
2017-11-03 14:18:44 +01:00
Emilio Cobos Álvarez
b03b59b218
style: Optimize all ids in the rightmost compound selector.
This is effectively the same optimization Gecko has now.

MozReview-Commit-ID: 21HrjpHdpOz
2017-11-03 14:18:44 +01:00
Emilio Cobos Álvarez
1fd7269949
style: Add a fast path for querySelector/All with a single id selector using the doc ID table.
MozReview-Commit-ID: JVnDO890kn4
2017-11-03 14:18:43 +01:00
Emilio Cobos Álvarez
be1ba90284
style: Introduce TNode::is_in_document.
MozReview-Commit-ID: BrhhoOghtUL
2017-11-03 14:18:43 +01:00
bors-servo
af1cd386f5 Auto merge of #19109 - tigercosmos:ndk, r=jdm
Check if the NDK version is 12

<!-- Please describe your changes on the following line: -->
Since we only support NDK 12(b), we should add some script to check for that.
User might download 15 or 16, and would get some errors.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #19095 (github issue number if applicable).

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19109)
<!-- Reviewable:end -->
2017-11-03 08:14:27 -05:00
tigercosmos
3cdba605af Check if the NDK version is 12 2017-11-03 20:59:56 +08:00
Emilio Cobos Álvarez
c3876a42a8
style: Move the single simple selector optimizations to a different function.
MozReview-Commit-ID: EEM3AzW2A9s
2017-11-03 13:49:15 +01:00
Emilio Cobos Álvarez
db65c2d346
style: Add a Document::elements_with_id API.
MozReview-Commit-ID: BNtbJp0RI68
2017-11-03 13:49:15 +01:00
tigercosmos
a0ae81610d Print the full path for errors occurring in the servo crate 2017-11-03 13:54:39 +08:00
CYBAI
d316c55590 style: Move font -moz-script-level outside of mako 2017-11-03 09:49:19 +08:00
bors-servo
c494d25e24 Auto merge of #18750 - Manishearth:transform-generic, r=emilio,xidorn
Make transforms generic

This makes the specified and computed value of transform share a generic
backing enum.

This will eventually be a complete fix for
https://bugzilla.mozilla.org/show_bug.cgi?id=1391145 , and also
incidentally fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1405881

Currently WIP -- the generic transform exists and is used, but this
currently misses some animation and glue cases.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18750)
<!-- Reviewable:end -->
2017-11-02 17:02:07 -05:00