Commit graph

12686 commits

Author SHA1 Message Date
Martin Robinson
117c278936 Move DisplayList drawing logic to struct implementation
This will be useful when PaintLayers that contain DisplayLists instead
of StackingContexts need to draw themselves. This is a simple
preparatory refactoring and doesn't change any behavior.
2015-09-22 09:33:07 -07:00
bors-servo
d588ce8d85 Auto merge of #7707 - mskrzypkows:compositing_net_plugins, r=jdm
Add plugins for compositing and net crates #7699

Changed to_string calls to to_owned calls
where was a need.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7707)
<!-- Reviewable:end -->
2015-09-22 07:58:55 -06:00
Maciej Skrzypkowski
88815d21ba Add plugins for compositing and net crates #7699
Changed to_string calls to to_owned calls
where was a need.
2015-09-22 13:51:21 +02:00
bors-servo
44de9173cc Auto merge of #7678 - AnthonyBroadCrawford:improved-error-messaging-mach-bootstrap, r=frewsxcv
#7630 Adding better error messaging in mach bootstrap for missing virtualenv/pip dependencies 

This PR is in reference to #7630 

I've added a simple try catch around our use of subprocess.check_all when trying to invoke and use python's 

- virtualenv 
- pip

Upon failure, I use sys.exit with an error message for the user.  Exit seemed appropriate as anything beneath those dependencies will fail to execute and result in a non friendly error message

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7678)
<!-- Reviewable:end -->
2015-09-21 18:13:35 -06:00
bors-servo
434e1fa074 Auto merge of #7702 - frewsxcv:no-dead-code, r=nox
Remove unnecessary `allow(dead_code)` function attributes



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7702)
<!-- Reviewable:end -->
2015-09-21 17:31:04 -06:00
Corey Farwell
4898f34d95 Remove unnecessary allow(dead_code) function attributes 2015-09-21 18:53:04 -04:00
Anthony Broad-Crawford
2e0e2288ed Added error handling and improved error messaging when running mach without python's virtualenv or pip installed 2015-09-21 13:38:30 -05:00
bors-servo
4dc986bca3 Auto merge of #7064 - paulrouget:reload, r=Ms2ger
Implement location.reload()

This is a naive implementation of `window.location.reload()`.
I'd appreciate any feedback.

I was wondering if it'd be better to implement `ConstellationMsg::Reload` instead of using  `load_url`.

Also, what kind of test should I write?

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7064)
<!-- Reviewable:end -->
2015-09-21 09:03:42 -06:00
bors-servo
291fa88832 Auto merge of #7691 - frewsxcv:rm-creator-webidl-attribute, r=nox
Remove deprecated 'creator' WebIDL attribute

According to @Ms2ger, the 'creator' attribute was merged into 'setter'

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7691)
<!-- Reviewable:end -->
2015-09-21 05:45:30 -06:00
Corey Farwell
d8da5c20f6 Remove deprecated 'creator' WebIDL attribute
According to @Ms2ger, the 'creator' attribute was merged into 'setter'
2015-09-21 07:12:17 -04:00
Corey Farwell
6c6c6663ab Update spec link to point to exact section 2015-09-21 07:11:58 -04:00
bors-servo
ec9aa9ace0 Auto merge of #7690 - frewsxcv:codegen-cleanup, r=nox
Minor DOM codegen cleanup



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7690)
<!-- Reviewable:end -->
2015-09-21 01:53:56 -06:00
bors-servo
611ceabcd1 Auto merge of #7694 - ddrmanxbxfr:HTMLMetaFixesWPT, r=nox
HTML Meta keyword nits in wpt webstorage files

Hi guys,

This PR is a small cleanup over Webstorage WPT tests.

Meta charset keywords were declared as <mete charset=utf-8 > instead of <meta charset=utf-8>

Thanks for looking into it.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7694)
<!-- Reviewable:end -->
2015-09-21 01:09:06 -06:00
Paul Rouget
e742e7e9bc wpt test for location.reload() 2015-09-21 08:04:24 +02:00
Paul Rouget
c7e5e785b2 implement window.location.reload() 2015-09-21 07:56:33 +02:00
Mathieu Rheaume
5f1b0e6a49 HTML Meta keyword nits in wpt webstorage files 2015-09-20 22:39:04 -04:00
bors-servo
b737bd322e Auto merge of #7674 - Ms2ger:update-css, r=Ms2ger
Update CSS tests to revision 135b269a1d9f5ce7862ab7426578bd56e2add740



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7674)
<!-- Reviewable:end -->
2015-09-20 10:58:13 -06:00
Corey Farwell
3b99893eaa Python 'is' operator should not be used to check value
'is' checks reference. '==' checks value
2015-09-20 12:39:32 -04:00
bors-servo
566f1eb6f6 Auto merge of #7689 - frewsxcv:supported-property-names-links, r=nox
Add/update spec links for SupportedPropertyNames methods



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7689)
<!-- Reviewable:end -->
2015-09-20 10:21:22 -06:00
Corey Farwell
38bbdd80db Remove parens around Python 'assert' statement
'assert' is a statement, not a function
2015-09-20 12:10:28 -04:00
Corey Farwell
83333e972c Add/update spec links for SupportedPropertyNames methods 2015-09-20 11:48:14 -04:00
bors-servo
d1269294e6 Auto merge of #7611 - nox:cache-element-id, r=frewsxcv
Cache the `id` attribute on Element

Thanks to @asabil for the original work, I only rebased it.

Fixes #6359 and #7040.


<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7611)
<!-- Reviewable:end -->
2015-09-20 09:23:20 -06:00
bors-servo
5667283d1f Auto merge of #7653 - notriddle:calc-transition, r=dzbarsky
Add transitions for CSS `calc()`.

Closes #7284

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7653)
<!-- Reviewable:end -->
2015-09-20 00:22:13 -06:00
Michael Howell
554a4cf9f2 Add transitions for CSS calc().
Closes #7284
2015-09-19 19:39:55 -07:00
bors-servo
61267cde63 Auto merge of #7601 - nox:cleanup-dom-webidls, r=Ms2ger
Improve DOM interfaces' extended attributes

Some should have been `[SameObject]` instead of `[Constant]`. The rest of the changes are additional `[Constant]` and `[Pure]` extended attributes on many operations.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7601)
<!-- Reviewable:end -->
2015-09-19 17:50:22 -06:00
bors-servo
a0d3c9223f Auto merge of #7662 - nerith:import, r=frewsxcv
Check for multiple import blocks separated by whitespace

Fixes #7381.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7662)
<!-- Reviewable:end -->
2015-09-19 13:34:51 -06:00
Brandon Fairchild
de3547e401 Fix reported test-tidy errors for unmerged import blocks
This merges import blocks that were reported by tidy as unmerged.
2015-09-19 12:50:14 -04:00
Brandon Fairchild
e924393be8 tidy.py: Check for import blocks separated by whitespace
This enables flagging multiple import blocks separated by whitespace
as errors.

Fixes #7381.
2015-09-19 12:46:01 -04:00
Ms2ger
bff545d198 Update CSS tests to revision 135b269a1d9f5ce7862ab7426578bd56e2add740 2015-09-19 18:02:54 +02:00
Anthony Ramine
49219baab8 Annotate many DOM attribute and methods with [Constant] and [Pure] 2015-09-19 16:03:13 +02:00
bors-servo
7f2d81933a Auto merge of #7654 - samfoo:hsts-cookie-arc, r=jdm
Move HSTS/CookieStorage to Arc<RwLock> from Ipc

servo/servo#7421

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7654)
<!-- Reviewable:end -->
2015-09-19 02:01:06 -06:00
Sam Gibson
641119206e Remove superfluous clone 2015-09-19 19:13:51 +12:00
Sam Gibson
6d20b388f6 General cleanup for HSTS/Cookie Arc 2015-09-19 18:30:38 +12:00
Sam Gibson
6f573d5d44 Move HSTS/CookieStorage to Arc<RwLock> from Ipc
servo/servo#7421
2015-09-19 18:30:37 +12:00
bors-servo
c91c0188f2 Auto merge of #7679 - bjwbell:reftest-twitter-fail-whale, r=pcwalton
Add css twitter fail whale html test & update ellipse_to_bezier comment

cgaebel had a TODO for a css twitter fail whale reftest, which depended on elliptical border-radius support.
I didn't see any feasible way other than a reference image for border_twitter_fail_whale_b.html.

r? @pcwalton

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7679)
<!-- Reviewable:end -->
2015-09-18 22:54:44 -06:00
Bryan Bell
f4a04614ff Add css twitter fail whale test & update ellipse_to_bezier comment 2015-09-18 20:55:10 -07:00
bors-servo
d1b85de762 Auto merge of #7680 - Mylainos:Issue-#7390, r=metajack
fixes #7390 : tidy now check the order of mod declarations even whith attribute



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7680)
<!-- Reviewable:end -->
2015-09-18 14:44:48 -06:00
Hugo Thiessard
6565e7b02f Issue #7390 correct the order of mod declaration 2015-09-18 22:02:04 +02:00
Hugo Thiessard
e81e91207c fixes #7390 : tidy now check the order of mod declarations even whith attribute 2015-09-18 21:32:00 +02:00
Josh Matthews
9b939546a6 Link to instructions that don't mention critic. 2015-09-18 11:48:21 -04:00
bors-servo
8a8204ffc8 Auto merge of #7447 - ddrmanxbxfr:master, r=jdm
Issue #7382 Use descriptive enums instead of booleans for MIMEClassifier::classifer

Hi guys i've done a small pass of refactor in the MIMEClassifier implementation. (See issue #7382 )
   - Moved the predicates to separate functions
   - Added a mimetype enum so we can compare them easily after calling MIMEClassifier::get_media_type

I hope it follows rust good pratices (care it's my first time doing rust).

Improvements and tips are welcome :).

Thanks for looking at it.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7447)
<!-- Reviewable:end -->
2015-09-18 07:22:59 -06:00
bors-servo
eae3eaf974 Auto merge of #7669 - mbrubeck:zoom, r=glennw
Set default limits on page zoom and pinch zoom

Currently these both clamp to 100% in one direction and are unbounded in the other direction.  This sets default zoom constraints of 10% to 800%.  r? @glennw

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7669)
<!-- Reviewable:end -->
2015-09-18 06:36:27 -06:00
Matt Brubeck
8606a94722 Set default limits on page zoom and pinch zoom
Currently these both clamp to 100% in one direction and are unbounded in the
other direction.  This sets default zoom constraints of 10% to 800%.
2015-09-18 05:30:55 -07:00
bors-servo
491d62c27c Auto merge of #7667 - mbrubeck:oh-snap, r=glennw
Snap to screen pixels instead of px

Fixes #7665. r? @glennw

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7667)
<!-- Reviewable:end -->
2015-09-18 04:09:26 -06:00
Matt Brubeck
9333f028e8 Snap to screen pixels instead of px
Fixes #7665.
2015-09-18 03:06:06 -07:00
Matt Brubeck
186ab5aa24 Allow setting device-pixel-ratio for reftests 2015-09-18 02:48:59 -07:00
bors-servo
acde10f005 Auto merge of #7656 - mbrubeck:incremental-text-6501, r=pcwalton
Reconstruct flows when text/font styles change

These styles are used during text shaping.  When they change, we need to re-run shaping and construct new flows.

Fixes #6501. r? @pcwalton

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7656)
<!-- Reviewable:end -->
2015-09-18 01:32:40 -06:00
bors-servo
3030eff4c6 Auto merge of #7664 - mbrubeck:glutinup, r=glennw
Update glutin to latest upstream merge

To pick up servo/glutin#47. r? @glennw

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7664)
<!-- Reviewable:end -->
2015-09-17 23:36:18 -06:00
Matt Brubeck
734513c668 Update glutin to latest upstream merge
To pick up servo/glutin#47.
2015-09-17 22:33:11 -07:00
Matt Brubeck
0c77705f52 Reconstruct flows when text/font/list styles change
Fixes #6501.
2015-09-17 11:59:00 -07:00