Commit graph

19254 commits

Author SHA1 Message Date
Fernando Jiménez Moreno
2974dae431 Fix binding generation for overloaded functions with optionals and default values 2017-11-11 08:41:19 +01:00
bors-servo
33fa728d6e Auto merge of #19167 - CYBAI:font-variant-alternates-out-of-mako, r=emilio
style: Move font-variant-alternates outside of mako

This is a sub-PR of #19015
r? emilio

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #19166  (github issue number if applicable).
- [x] These changes do not require tests

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19167)
<!-- Reviewable:end -->
2017-11-10 17:49:15 -06:00
bors-servo
3d888b5db8 Auto merge of #19181 - mbrubeck:opts, r=emilio
Remove unused -t command-line flag

A little bit was left over from #16716.

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests because they only remove unused code

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19181)
<!-- Reviewable:end -->
2017-11-10 13:50:14 -06:00
Emilio Cobos Álvarez
3a5d70f106
style: Stop inspecting children to recascade them just because we reframed.
We only need to do this when display changes from none to non-none, so handle it
explicitly when computing the cascade requirement.

This patch also removes a few conditions that are redundant because they're
handled also by the cascade requirement check, like the initial styling.
2017-11-10 20:47:37 +01:00
Emilio Cobos Álvarez
5200ded17c
script: Fix Servo relying on descendants being visited when there's a reframe. 2017-11-10 20:47:37 +01:00
Matt Brubeck
5630476d16 Remove unused -t command-line flag 2017-11-10 11:46:03 -08:00
CYBAI
aeae3113bf style: Move font-variant-alternates outside of mako 2017-11-11 02:21:12 +08:00
Emilio Cobos Álvarez
6704122927
style: Get rid of CurrentElementInfo.
It's out-of-band data I never liked, and the code has changed enough from when
it was introduced, that now all of the information it stores can be local.
2017-11-10 17:03:01 +01:00
Emilio Cobos Álvarez
49fe3d1c9f
style: Remove "reconstructed ancestor" checks.
This is only useful to avoid restyling NAC subtrees, but _not_ for ::before or
::after, in most cases. These subrees are small, and reframing is also not too
common, so I don't think it warrants the complexity.
2017-11-10 17:03:01 +01:00
bors-servo
333c6ef7fa Auto merge of #19175 - emilio:children-changed, r=nox
script: Call content_and_heritage_changed from children_changed instead of add_child / remove_child.

add_child / remove_child aren't called when a node character data changed. This
is important for finer grained invalidation.

The only test that tests this is now wallpapered, but won't be after #19164.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19175)
<!-- Reviewable:end -->
2017-11-10 08:47:50 -06:00
Emilio Cobos Álvarez
e4d6296f3f
layout: Fixup indentation of ThreadSafeLayoutNodeHelpers::flags.
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
2017-11-10 13:13:19 +01:00
Emilio Cobos Álvarez
c9d9304912
script: Call content_and_heritage_changed from children_changed instead of add_child / remove_child.
add_child / remove_child aren't called when a node character data changed. This
is important for finer grained invalidation.

The only test that tests this is now wallpapered, but won't be after #19164.
2017-11-10 13:12:24 +01:00
bors-servo
a3f2fae561 Auto merge of #19165 - CYBAI:font-synthesis-out-of-mako, r=emilio
style: Move font-synthesis outside of mako

This is a sub-PR of #19015
r? emilio

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #19160  (github issue number if applicable).
- [x] These changes do not require tests

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19165)
<!-- Reviewable:end -->
2017-11-09 22:13:51 -06:00
CYBAI
b5370aa688 style: Move font-synthesis outside of mako 2017-11-10 09:00:31 +08:00
bors-servo
338e2ae520 Auto merge of #18262 - KiChjang:value-sanitization, r=nox
Implement value sanitization on HTMLInputElement

https://html.spec.whatwg.org/multipage/input.html#value-sanitization-algorithm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18262)
<!-- Reviewable:end -->
2017-11-09 18:35:07 -06:00
Keith Yeung
8203605c04 Implement value sanitization on HTMLInputElement 2017-11-09 16:34:14 -08:00
Glenn Watson
b1ec2b260a Update WR (dotted border fix, better AA for split primitives) 2017-11-10 08:17:32 +10:00
Simon Sapin
793bebfc0e Upgrade to rustc 1.23.0-nightly (02004ef78 2017-11-08) 2017-11-09 16:56:39 +01:00
Emilio Cobos Álvarez
57121a2e15
style: Remove the skip_applying_damage "optimization".
We already remove all change hints down the tree when finding a reframe hint
using ClearServoRestyleFromSubtree in ServoRestyleManager, so this is useless.

MozReview-Commit-ID: 1twx7iPt79x
2017-11-09 15:21:53 +01:00
Simon Sapin
954b2cc3d8
Allow unused imports for AsciiExt in style code.
See #19128, this part is cherry-picked so Gecko can build with rust nightly.
2017-11-09 12:43:23 +01:00
Keith Yeung
9d60333af9 Implement string stripping utilities from the Infra spec 2017-11-08 11:58:18 -08:00
bors-servo
5b36b74c06 Auto merge of #19138 - asajeffrey:script-rename-js-dependency-to-mozjs, r=jdm
Rename js crate to mozjs

<!-- Please describe your changes on the following line: -->

This PR renames the `js` dependency to `mozjs', ready for when https://github.com/servo/rust-mozjs/pull/377 lands.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because refactoring

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19138)
<!-- Reviewable:end -->
2017-11-08 11:45:05 -06:00
Alan Jeffrey
8008ba5081 Renamed js crate to mozjs 2017-11-08 11:43:30 -06:00
CYBAI
e73f2377cf style: Move font-size-adjust outside of mako 2017-11-08 23:40:23 +08:00
bors-servo
cbf2ac35f7 Auto merge of #19149 - emilio:random-cleanup, r=nox
style: minor cleanups

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19149)
<!-- Reviewable:end -->
2017-11-08 07:28:47 -06:00
Emilio Cobos Álvarez
5ecf1508ee
style: We never call accumulate_damage_for in a forgetful traversal.
We early-return instead before calling it.

MozReview-Commit-ID: JaRWPHCQAl9
2017-11-08 14:24:10 +01:00
Emilio Cobos Álvarez
92a69fbd9a
style: Tidy up PseudoElement::should_exist.
MozReview-Commit-ID: Enr1NHONmtp
2017-11-08 14:23:58 +01:00
bors-servo
a1f7337221 Auto merge of #19148 - KiChjang:import-sequence-inner-types, r=jdm
Import sequence inner types if it appears in dictionary members

Relands #19133, as it was backed out wrongly in #19143.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19148)
<!-- Reviewable:end -->
2017-11-08 06:22:16 -06:00
Keith Yeung
ce8486ab9b Import sequence inner types if it appears in dictionary members 2017-11-08 04:20:30 -08:00
bors-servo
fd8b4b59c2 Auto merge of #19119 - CYBAI:font-size-out-of-mako, r=emilio
style: Move font-size outside of mako

This is a sub-PR of #19015
r? emilio

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #19111  (github issue number if applicable).
- [x] These changes do not require tests

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19119)
<!-- Reviewable:end -->
2017-11-08 04:05:47 -06:00
CYBAI
0f57d250bb style: Move font-size outside of mako 2017-11-08 14:31:06 +08:00
Emilio Cobos Álvarez
7adad61db8
style: Get rid of parse_specified.
It has a single use, and I don't think we should use it in the future.
2017-11-08 01:33:13 +01:00
bors-servo
9de76632f4 Auto merge of #19135 - paulrouget:resize, r=mbrubeck
do not pass new size to Resize event

It's not necessary to pass the new size to the resize event as it can be retrieved via `WindowMethods::framebuffer_size()`.

From the perspective of the embedder, that makes things a bit easier.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19135)
<!-- Reviewable:end -->
2017-11-07 10:44:51 -06:00
Emilio Cobos Álvarez
7f073456f9
style: respect allow_quirks for boxed properties.
This will unblock #19119
2017-11-07 14:25:51 +01:00
Paul Rouget
8a219e8a81 do not pass new size to Resize event 2017-11-07 10:27:24 +01:00
Gecko Backout
2c1b041fc6 Backed out changeset d77275db6419 (bug 1374178) for failure reftests/transform-3d/translatez-1a.html r=backout a=backout on a CLOSED TREE
Backs out https://github.com/servo/servo/pull/19106
2017-11-07 06:49:27 +00:00
Glenn Watson
3007bfe815 Update WR (blur and subpixel text optimizations, recording fix) 2017-11-07 14:48:53 +10:00
bors-servo
4decea188f Auto merge of #19106 - upsuper:window-transform, r=emilio
Implement -moz-window-transform{,-origin} internal properties

This fixes [bug 1374178](https://bugzilla.mozilla.org/show_bug.cgi?id=1374178).

Note that the impl of `-moz-window-transform-origin` doesn't exactly match how it is implemented in Gecko. Specifically, that property doesn't accept depth value in Gecko, but it does in this impl. The depth value is simply dropped during conversion. This is because I don't think it's worth adding code for handling this internal property to make it as restrictive.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19106)
<!-- Reviewable:end -->
2017-11-06 17:46:51 -06:00
bors-servo
5227df260c Auto merge of #19038 - CJ8664:master, r=jdm
Added implementation for itemprop and itemtype along with test files

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [x] There are tests for these changes OR

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19038)
<!-- Reviewable:end -->
2017-11-06 14:17:11 -06:00
Vijay Hebbar
4a43dba8d7 Add implementation for itemprop and itemtype
Created test file

Added the stub methods for itemprop and itemscope

Resolved html5ever dependency, added ItemScope and ItemProp attr

Resolving dependency

Added pref override on metadata attributes

Resetting to original state due to change in requirement

Reverted adding attributes

1. add a customized implementation of parse_plain_attribute
2. add the following methods to HTMLElement.webidl

added itemprop and itemtype, enabled pref in test

Added initial implementation for getting itemprop property values

Adding the wireframe for testing

Implemented function to handle itemType

Corrected typo

Fixed typo bug in code

Handling duplicates for itemtype attribute values

Added the test suite structure

Added test for extra space

Added test for regular test values

Added test cases for Single property values

Test cases to check absence of itemtype and itemprop attributes

Added code to handle absence of itemtype or itemprop attributes

Added shell script to run all test cases

cleared up Cargo file

Tidying up

Removed the local test file

Removed new line for test-tidy

Ordered key in prefs.json

Fixes for test-tidy

Enabled test preferences

Created test using wpt

Creating WPT Tests for Regular and Single Prop Types

Fixed the Regular type test

Fixed tests

Removed old test case metadata

Incorporate review changes from PR

Updated MANIFEST to sync test cases

Making changed suggested in review

Removed editor folding

Removed unnecessary code

Resolving cargo conflicts

Updated PropertyNames and itemtypes implementation

Trying different data in test case

Updated manifest

Updated code based on reviews
2017-11-06 15:11:50 -05:00
Xidorn Quan
7dfcbb582a Add general impl in gecko_properties for TransformOrigin value and add -moz-window-transform-origin. 2017-11-06 11:49:53 -08:00
Xidorn Quan
9f5195eeec Add general impl in gecko_properties for Transform value and add -moz-window-transform. 2017-11-06 11:49:52 -08:00
Xidorn Quan
79fb584eac Use helpers.predefined_type for transform property. 2017-11-06 11:49:50 -08:00
Sandeep Hegde
ffbabf4a4c Added randomness to the mutation strategy
- now running only maximum one mutation per file.
- Beautified the output
2017-11-06 13:00:14 -05:00
Sandeep Hegde
c2d46c3b90 Fixed json tidy error 2017-11-06 13:00:13 -05:00
Sandeep Hegde
58ab11cf9b Fixed few tidy errors 2017-11-06 13:00:13 -05:00
Sandeep Hegde
ba2152900c Added Test Mapping framework and running through a path. 2017-11-06 13:00:12 -05:00
bors-servo
a509ebf90c Auto merge of #18657 - emilio:bye-applet, r=KiChjang
script: Remove HTMLAppletElement.

It was removed from the spec, there's no reason to keep it in tree.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18657)
<!-- Reviewable:end -->
2017-11-06 10:46:44 -06:00
Emilio Cobos Álvarez
8b0f58c8af
script: Remove HTMLAppletElement.
It was removed from the spec, there's no reason to keep it in tree.
2017-11-06 17:08:14 +01:00
bors-servo
0047c77f03 Auto merge of #19126 - emilio:source-size-list, r=nox
style: Introduce SourceSizeList.

This is part of the work for https://bugzilla.mozilla.org/show_bug.cgi?id=1408308.

But this can just land now IMO, before I do the integration bits.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19126)
<!-- Reviewable:end -->
2017-11-06 09:37:14 -06:00