Commit graph

13694 commits

Author SHA1 Message Date
rohan.prinja
45224028db more refactoring 2015-10-30 20:26:29 +09:00
rohan.prinja
bb2536cd01 move Castable into dom::bindings::inheritance 2015-10-30 20:24:42 +09:00
bors-servo
00b60b9386 Auto merge of #8250 - wenderen:8246-remove-get-rooted, r=Ms2ger
remove get_rooted() and replace all references to it with references …

…to get()

for #8246

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8250)
<!-- Reviewable:end -->
2015-10-30 06:37:44 +05:30
bors-servo
b6bcccb204 Auto merge of #8212 - Ms2ger:reflow-root, r=pcwalton
Remove SharedLayoutContext::reflow_root.



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8212)
<!-- Reviewable:end -->
2015-10-30 05:22:54 +05:30
bors-servo
88f501c412 Auto merge of #5745 - servo:gc, r=Manishearth
Move the DOM memory management blog post into the tree.

This is a WIP, but I wanted to get eyes on it already.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/5745)
<!-- Reviewable:end -->
2015-10-29 21:58:22 +05:30
Ms2ger
4dbc99c7f3 Move the DOM memory management blog post into the tree. 2015-10-29 17:25:00 +01:00
rohan.prinja
4a4f041948 remove get_rooted() and replace all references to it with references to get() 2015-10-29 21:48:39 +09:00
bors-servo
430578355b Auto merge of #8247 - Ms2ger:assert, r=jdm
Add thread assertions to js.rs.



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8247)
<!-- Reviewable:end -->
2015-10-29 17:08:50 +05:30
Ms2ger
85a57b5111 Add thread assertions to js.rs. 2015-10-29 11:56:17 +01:00
bors-servo
94ca87e7dd Auto merge of #8244 - mrobinson:layer-size, r=pcwalton
Expand DisplayList layer bounds to whole pixels

Before passing these layers to the paint task, expand them to pixel
boundaries. This ensures that subpixel edges of the layer will not be
clipped away and helps prevent rounding issues with layer contents.

Fixes #8166.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8244)
<!-- Reviewable:end -->
2015-10-29 06:55:10 +05:30
Martin Robinson
a7a58e47a0 Expand DisplayList layer bounds to whole pixels
Before passing these layers to the paint task, expand them to pixel
boundaries. This ensures that subpixel edges of the layer will not be
clipped away and helps prevent rounding issues with layer contents.

Fixes #8166.
2015-10-28 18:11:59 -07:00
bors-servo
9501564e01 Auto merge of #8229 - mbrubeck:debug-log, r=larsbergstrom
Disable debug logging in release builds

This uses the new `release_max_level` feature added in rust-lang-nursery/log#58 to turn the `debug!` and `trace!` macros into no-ops in optimized builds.

r? @pcwalton (or anyone else who wants it)

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8229)
<!-- Reviewable:end -->
2015-10-29 03:07:01 +05:30
Matt Brubeck
ccecf3fc93 Disable debug logging in release builds
This uses the new `release_max_level` feature added in
rust-lang-nursery/log#58 to turn the `debug!` and `trace!` macros into no-ops
in optimized builds.
2015-10-28 14:22:57 -07:00
bors-servo
285e29c066 Auto merge of #8098 - bholley:dirty_from_layout, r=jdm
Track event state changes on Document and do the dirtying from layout

This is a first step in fixing #6942.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8098)
<!-- Reviewable:end -->
2015-10-29 00:24:53 +05:30
bors-servo
30ce2a84c1 Auto merge of #8242 - Ms2ger:update-js, r=metajack
Update js.



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8242)
<!-- Reviewable:end -->
2015-10-28 23:35:40 +05:30
Ms2ger
2a2ab23dfb Update js. 2015-10-28 18:02:10 +01:00
bors-servo
0d699a2b44 Auto merge of #8241 - Manishearth:euclid_up, r=mbrubeck
Update euclid to 0.3



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8241)
<!-- Reviewable:end -->
2015-10-28 22:01:15 +05:30
Manish Goregaokar
184b2bacf3 Fix serde_macros 2015-10-28 21:53:15 +05:30
Manish Goregaokar
ce5586f74a Update euclid to 0.3 2015-10-28 21:34:23 +05:30
bors-servo
3efa749976 Auto merge of #8226 - froydnj:gc-zeal, r=Ms2ger
unblock using JS_GC_ZEAL

I think these patches move the `JS_SetReservedSlot` call to the right place for #6057.  I'm not sure that the interface to `create_dom_global` is the best; passing a `JSVal` or a `*libc::c_void` seemed about equal, so I'd welcome feedback there.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8226)
<!-- Reviewable:end -->
2015-10-28 17:24:36 +05:30
bors-servo
8cc6ce4b86 Auto merge of #8230 - jgraham:wptrunner_update, r=Ms2ger
Update to latest wptrunner.



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8230)
<!-- Reviewable:end -->
2015-10-28 16:28:13 +05:30
bors-servo
3951c577bf Auto merge of #7963 - dagnir:issue-7774, r=eefriedman
Implement ask_for_reset for HTMLSelectElement.

Fixes #7774

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7963)
<!-- Reviewable:end -->
2015-10-28 07:45:02 +05:30
Dongie Agnir
4849033297 Add fixes based on review.
- Use if let instead of match for Option

- Refactor common code into pick_if_selected_and_reset
2015-10-27 15:20:35 -10:00
bors-servo
7c9f4644f3 Auto merge of #8169 - ax3lst:master, r=eefriedman
Implement document.createEvent(TouchEvent)

This solves #8160

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8169)
<!-- Reviewable:end -->
2015-10-28 05:55:03 +05:30
bors-servo
949a5b3a3e Auto merge of #8231 - mbrubeck:plugin-doc, r=eefriedman
Fix misplaced doc comment in plugins/lib.rs



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8231)
<!-- Reviewable:end -->
2015-10-28 05:12:36 +05:30
Matt Brubeck
64a2d9e793 Fix misplaced doc comment in plugins/lib.rs 2015-10-27 16:37:57 -07:00
James Graham
5998742e5d Update to latest wptrunner. 2015-10-28 08:22:13 +09:00
bors-servo
bccede0370 Auto merge of #8145 - notriddle:master, r=pcwalton
Show overflow for #8118.

Fixes list items.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8145)
<!-- Reviewable:end -->
2015-10-28 03:57:07 +05:30
Nathan Froyd
c82b6ce843 move reserved slot setting for DOM globals
Moving this slot setting prior to initializing standard classes and
other initialization tasks means that we can effectively use JS_GC_ZEAL.

Fixes #6057.
2015-10-27 18:08:35 -04:00
Michael Howell
2b6e897cd1 Show overflow for #8118. 2015-10-27 15:07:59 -07:00
Dongie Agnir
92e008307f Add fixes based on review.
- Whitespace and indentation issues

- call as_for_reset on option insert

- add link to 'pick' in standard
2015-10-27 11:52:55 -10:00
Nathan Froyd
3d39646c8e reduce indentation in CodegenRust.py
We're going to wind up tacking on different pieces of code for the
global vs. non-global case once we move the JS_SetReservedSlot call into
create_dom_global.  We might as well separate the indentation changes
into a separate commit.
2015-10-27 16:46:01 -04:00
bors-servo
381317f658 Auto merge of #8129 - craftytrickster:pos-fixed-list-item, r=glennw
Made block type pattern match less inclusive

Given the comments above the match statement, it seems that fixed-pos check should match only block elements in this case. Doing this change seems to partially resolve the issue where list items with `position:fixed;` styling are not displaying their bullet points. This change only resolves the issue for list items with `list-style-position: inside`, outside positioning is still not functioning correctly. 

https://github.com/servo/servo/issues/8001#issuecomment-149781613

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8129)
<!-- Reviewable:end -->
2015-10-28 01:44:48 +05:30
Bobby Holley
069c40f788 Check modified event state from layout and dirty it there.
This adds some overhead, but also provides the small performance benefit of
avoiding dirtying in the case where an event state is toggled an even
number of times between reflows.

The main benefit here though is that it sets us up to be smarter about
what we mark as dirty using restyle hints.
2015-10-27 12:48:48 -07:00
Bobby Holley
441c84d75d Pass the document instead of the documentElement to reflow. 2015-10-27 12:41:16 -07:00
Bobby Holley
85596b5510 Use an RAII guard to join the script task. 2015-10-27 12:41:14 -07:00
Bobby Holley
630b9f8fa0 Implement Hash and Eq for JS<T> and LayoutJS<T>. 2015-10-27 12:41:14 -07:00
bors-servo
d1295e9e7d Auto merge of #8040 - froydnj:codegen-arg-info, r=jdm
generate JIT argument type information for methods

This enhances `CodegenRust.py` to output `JSTypedMethodJitInfo` structures where appropriate.  This brings a notable speedup to tests like Dromaeo's `dom-attr/getAttribute`, which improves by several orders of magnitude with these patches applied.

If there are tricks for addressing the XXX comments, I would appreciate hearing them.

I think this addresses all of #6904.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8040)
<!-- Reviewable:end -->
2015-10-28 01:06:06 +05:30
Nathan Froyd
4f649ac6dd generate JIT argument type information for methods
Fixes #6904.
2015-10-27 15:09:32 -04:00
Nathan Froyd
dd74572dc0 add CGMemberJITInfo.{getJSArgType,getSingleArgType}
These are copied directly from Gecko's Codegen.py, with two changes:

- We need to use ArgType:: to qualify the enums rather than plain
  JSJitInfo::

- Given Rust's stronger notion of enums, we need to treat everything as an
  i32 so we can bitwise-or things together.
2015-10-27 15:07:55 -04:00
bors-servo
98dc67dbec Auto merge of #8224 - mbrubeck:glutinup, r=frewsxcv
Upgrade glutin and related packages

Updated version of #8172.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8224)
<!-- Reviewable:end -->
2015-10-27 23:59:53 +05:30
Alan Jeffrey
219d1b9201 Updated to v0.1.15 of string_cache.
Manually edited ports/gonk/Cargo.lock.
Trying to rebuild ports/gonk/Cargo.lock using cargo-update produes errors:

$ ./mach update-cargo -p string_cache_shared -p string_cache_plugin -p string_cache
components/servo
    Updating registry `https://github.com/rust-lang/crates.io-index`
      Adding bitflags v0.1.1
      Adding gl_generator v0.0.27
      Adding khronos_api v0.0.7
ports/cef
    Updating registry `https://github.com/rust-lang/crates.io-index`
      Adding bitflags v0.3.2
      Adding gl_generator v0.0.27
      Adding khronos_api v0.0.8
ports/gonk
    Updating registry `https://github.com/rust-lang/crates.io-index`
Package `serde v0.5.2` does not have these features: `unstable`
2015-10-27 11:24:21 -07:00
Matt Brubeck
1f8940fedd Upgrade glutin, image, and related packages 2015-10-27 11:24:20 -07:00
David Raifaizen
091282ee24 Made block type pattern match less inclusive 2015-10-27 09:41:42 -04:00
bors-servo
484c0e4546 Auto merge of #8222 - Ms2ger:test-ref, r=frewsxcv
Use wptrunner for some old-style reftests.



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8222)
<!-- Reviewable:end -->
2015-10-27 18:45:25 +05:30
Ms2ger
c265c52939 Move box_shadow_default_color_a.html to wpt reftests. 2015-10-27 14:07:01 +01:00
Ms2ger
f9930ab1fe Move box_shadow_blur_a.html to wpt reftests. 2015-10-27 14:00:13 +01:00
Ms2ger
5b08ac9ca9 Move borders_a.html to wpt reftests. 2015-10-27 13:32:29 +01:00
Ms2ger
8838133abe Move border_spacing_fixed_layout_a.html to wpt reftests. 2015-10-27 13:23:24 +01:00
Ms2ger
b456b219f6 Move border_spacing_auto_layout_a.html to wpt reftests. 2015-10-27 13:16:45 +01:00