Commit graph

29593 commits

Author SHA1 Message Date
Anthony Ramine
605c679fee Fix URL attributes
URL attributes should always use AttrValue::Url, and the input should be
resolved against the document's base URL at setting time always.
2017-10-11 13:56:07 +02:00
bors-servo
826352ab4c Auto merge of #18804 - servo:media, r=emilio
Another couple of low-key media improvements 👶👣

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18804)
<!-- Reviewable:end -->
2017-10-10 06:17:15 -05:00
Anthony Ramine
e3fb99dd59 Implement a bit more of the "object" path when loading media 2017-10-10 11:44:29 +02:00
bors-servo
55a7fd75b4 Auto merge of #18738 - hiikezoe:use-atom-for-animation-name-property, r=xidorn
Use atom for animation name property

<!-- Please describe your changes on the following line: -->
https://bugzilla.mozilla.org/show_bug.cgi?id=1329169

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18738)
<!-- Reviewable:end -->
2017-10-10 04:34:47 -05:00
Hiroyuki Ikezoe
fd2ccee84d Update bindings. 2017-10-10 18:33:49 +09:00
Anthony Ramine
b7452f37d9 Properly abort any ongoing resource selection on loading a new media 2017-10-10 10:10:39 +02:00
Hiroyuki Ikezoe
e0ef378b20 Use atom for animation-name property 2017-10-10 17:10:02 +09:00
Anthony Ramine
8754155a11 Update HTMLMediaElement.webidl according to spec 2017-10-10 09:50:51 +02:00
bors-servo
27cb13314e Auto merge of #18798 - emilio:faster-custom-props, r=SimonSapin
style: Optimize custom properties cycle removal.

After #18791, this is the major custom_properties perf bottleneck in the
testcase from bug 1405411.

I'm looking into how to efficiently merge this into `substitute_all`, but
meanwhile this is worth landing, and makes most of the overhead go away.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18798)
<!-- Reviewable:end -->
2017-10-10 02:47:29 -05:00
bors-servo
2cd9dcebee Auto merge of #18800 - hiikezoe:fix-mismatched-arguments-for-servo-selector-list, r=emilio
Fix mismatched arguments for servo selector list

<!-- Please describe your changes on the following line: -->
https://bugzilla.mozilla.org/show_bug.cgi?id=1406811

This needs to be fixed to update binding files.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18800)
<!-- Reviewable:end -->
2017-10-10 01:20:38 -05:00
bors-servo
bbb2a3cde9 Auto merge of #18790 - upsuper:scope, r=emilio
Support :scope pseudo-class

This fixes [bug 1406817](https://bugzilla.mozilla.org/show_bug.cgi?id=1406817).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18790)
<!-- Reviewable:end -->
2017-10-09 23:04:15 -05:00
Xidorn Quan
dd0366c6b9 Add wpt for :scope pseudo-class 2017-10-10 12:09:38 +11:00
Xidorn Quan
4667e811dd Cherry pick w3c/web-platform-tests#6874 to fix this test. 2017-10-10 12:09:36 +11:00
bors-servo
2a179cec2b Auto merge of #18795 - servo:jdm-patch-2, r=nox
Make update_manifest.sh more verbose.

This is an attempt to figure out why https://github.com/servo/servo/issues/17450 occurs.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18795)
<!-- Reviewable:end -->
2017-10-09 20:06:34 -05:00
bors-servo
54f6e87939 Auto merge of #18777 - mateon1:perf/headless-event-poll, r=jdm
Improved headless Servo performance

Now the main thread doesn't waste 100% CPU, polling for events.

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #18770 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because: I verified Servo works correctly in headless mode, and the linked issue is gone.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18777)
<!-- Reviewable:end -->
2017-10-09 16:45:41 -05:00
Hiroyuki Ikezoe
1e5ee9d2d4 Update bindings. 2017-10-10 06:35:49 +09:00
Hiroyuki Ikezoe
175b88afcf Fix mismatched arguments for Servo_SelectorXXX. 2017-10-10 06:35:16 +09:00
Emilio Cobos Álvarez
1d2e9e3ef7
style: Optimize custom properties cycle removal.
After #18791, this is the major custom_properties perf bottleneck in the
testcase from bug 1405411.

I'm looking into how to efficiently merge this into `substitute_all`, but
meanwhile this is worth landing, and makes most of the overhead go away.

MozReview-Commit-ID: LMUGc8kPhhE
2017-10-09 21:47:20 +02:00
bors-servo
80df3fb56a Auto merge of #18792 - tigercosmos:img, r=jdm
fix #18472:outdated png crate: various panics

<!-- Please describe your changes on the following line: -->
fix #18472:outdated png crate: various panics

---
- [X] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [X] These changes fix #18472

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18792)
<!-- Reviewable:end -->
2017-10-09 14:05:14 -05:00
Mateusz Naściszewski
63d69dbe9f
Move sleeping code to match block and comment 2017-10-09 20:36:08 +02:00
bors-servo
e3624e62a4 Auto merge of #18747 - jdm:serializing-childrenonly, r=jdm
Serializing childrenonly

Rebased from #17896.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #14975 (github issue number if applicable).
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18747)
<!-- Reviewable:end -->
2017-10-09 11:12:53 -05:00
bors-servo
8c314ff5d0 Auto merge of #18791 - emilio:faster-custom-props, r=heycam
style: Optimize custom property cascading.

This should help a bunch with https://bugzilla.mozilla.org/show_bug.cgi?id=1405411

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18791)
<!-- Reviewable:end -->
2017-10-09 09:29:18 -05:00
bors-servo
64aadee62c Auto merge of #18788 - BorisChiou:style/animation_value/debug, r=emilio
Use defualt Debug trait for AnimationValue

We use AnimationValue for animation backend to do interpolation,
accumulation, or computing distance. While debugging it, dumping the
property name is not enough. We need to dump the detailed value contained
in it.

For example:
if we animate ```translate(100px)``` to ```translate(200px)```,
and want to dump ```{:?} => {:?}```, the result is ```transform => transform```.
I think what we want is something like:
```Transform([Translate(100px, 0px, 0px)]) => Transform([Translate(200px, 0px, 0px)])```.

Using default Debug trait is not perfect because there are some redundant type strings,
but it is still better than nothing.

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [x] These changes are related to PR #18415.
- [X] These changes do not require tests because this is debug only.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18788)
<!-- Reviewable:end -->
2017-10-09 06:51:47 -05:00
tigercosmos
2fc765f254 fix #18472:outdated png crate: various panics 2017-10-09 19:42:00 +08:00
Xidorn Quan
0564a1e47b Support :scope pseudo-class in Element::{matches,closest} in Servo 2017-10-09 22:13:00 +11:00
Xidorn Quan
ba44d18ddb Support :scope pseudo-class in Element::matches for stylo 2017-10-09 22:04:10 +11:00
Xidorn Quan
ab46a0bbe0 Add support for :scope pseudo-class 2017-10-09 22:04:08 +11:00
Emilio Cobos Álvarez
a6eaa0812a
style: Share custom property declarations if they don't contain variable references. 2017-10-09 12:29:50 +02:00
Josh Matthews
398a15e6e0 Make update_manifest.sh more verbose. 2017-10-09 06:21:48 -04:00
bors-servo
604cc4e311 Auto merge of #18794 - emilio:xbl-quirks-mode, r=heycam
style: use the XBL styleset quirks mode to match XBL rules.

This fixes bug 1405543.

MozReview-Commit-ID: Dv3mt3Fb8Yp

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18794)
<!-- Reviewable:end -->
2017-10-09 05:04:15 -05:00
Emilio Cobos Álvarez
100dd18307
style: use the XBL styleset quirks mode to match XBL rules.
This fixes bug 1405543.

MozReview-Commit-ID: Dv3mt3Fb8Yp
2017-10-09 11:30:37 +02:00
Emilio Cobos Álvarez
7e143372bd
style: Don't go through remove_cycles if there are no references in the specified values. 2017-10-09 09:22:28 +02:00
Emilio Cobos Álvarez
c354f224ff
style: Refactor the custom properties map to have less temporary hashmap entries. 2017-10-09 09:22:28 +02:00
Emilio Cobos Álvarez
1ecd942384
style: Rename CustomPropertiesBuilder::custom_properties to something more descriptive. 2017-10-09 09:22:27 +02:00
Emilio Cobos Álvarez
4914351f2b
style: Hoist cascade() to CustomPropertyBuilder. 2017-10-09 09:22:27 +02:00
bors-servo
49376c9e54 Auto merge of #18789 - bholley:more_hashmap_asserts, r=Manishearth
Assert more things in hashtables

https://bugzilla.mozilla.org/show_bug.cgi?id=1406815

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18789)
<!-- Reviewable:end -->
2017-10-09 02:04:17 -05:00
Boris Chiou
df07ebde99 Use default Debug trait for AnimationValue.
We use AnimationValue for animation backend to do interpolation,
accumulation, or computing distance. While debugging it, dumping the
property name is not enough. We need to dump the detailed value contained
in it.
2017-10-09 14:06:06 +08:00
Bobby Holley
e5023a3eb4 Assert more things in hashtables.
MozReview-Commit-ID: H8jKywUewcZ
2017-10-08 22:40:34 -07:00
bors-servo
715fc9cea6 Auto merge of #18786 - nnethercote:bug-1400460, r=froydnj
Rename nsIAtom as nsAtom.

Bug 1400459 devirtualized nsIAtom so that it is no longer a subclass of
nsISupports. This means that nsAtom is now a better name for it than
nsIAtom.

<!-- Please describe your changes on the following line: -->

This is the Servo-side PR for https://bugzilla.mozilla.org/show_bug.cgi?id=1400460.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix https://bugzilla.mozilla.org/show_bug.cgi?id=1400460

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because testing is on the Gecko side.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18786)
<!-- Reviewable:end -->
2017-10-08 19:10:40 -05:00
Nicholas Nethercote
7628c1236a Rename nsIAtom as nsAtom.
Bug 1400459 devirtualized nsIAtom so that it is no longer a subclass of
nsISupports. This means that nsAtom is now a better name for it than
nsIAtom.
2017-10-09 09:27:11 +11:00
bors-servo
55a37930b2 Auto merge of #18783 - emilio:custom-props-builder, r=SimonSapin
style: Introduce CustomPropertiesBuilder.

I'm about to introduce more state here to implement optimizations for custom
property cascading, so this abstraction is useful to encapsulate that state.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18783)
<!-- Reviewable:end -->
2017-10-08 09:50:04 -05:00
Emilio Cobos Álvarez
d0f080d5dd
style: Introduce CustomPropertiesBuilder.
I'm about to introduce more state here to implement optimizations for custom
property cascading, so this abstraction is useful to encapsulate that state.
2017-10-08 15:01:21 +02:00
bors-servo
712d32e899 Auto merge of #18758 - stuartnelson3:stn/dynamic-body-bgcolor, r=emilio
Add support for dynamic bgcolor change

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18758)
<!-- Reviewable:end -->
2017-10-08 07:47:50 -05:00
bors-servo
47efcd5e52 Auto merge of #18781 - emilio:custom-props-bench, r=heycam
style: Add a simple custom properties benchmark.

This is going to help the work in bug 1405411.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18781)
<!-- Reviewable:end -->
2017-10-08 06:04:28 -05:00
Emilio Cobos Álvarez
99d241d517
style: Add a simple custom properties benchmark. 2017-10-08 13:03:38 +02:00
Emilio Cobos Álvarez
851b3e32bd
style: allow re-initializing thread_state as long as it's with the same value.
This unbusts running multiple rule-tree benchmarks at the same time.
2017-10-08 12:56:24 +02:00
Emilio Cobos Álvarez
8ea275a376
style: Avoid unused context argument.
In custom_properties::SpecifiedValue::parse.

It's not a big deal now, but it's useful to simplify testing this stuff, since
it avoids forcing us to mock it.
2017-10-08 12:56:24 +02:00
Stuart Nelson
c886e3ee75 Update manifest and move files 2017-10-08 11:29:49 +02:00
bors-servo
3f4afbafab Auto merge of #18779 - bholley:canary_and_journal, r=Manishearth
DiagnosticHashMap

https://bugzilla.mozilla.org/show_bug.cgi?id=1405879

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18779)
<!-- Reviewable:end -->
2017-10-07 14:55:03 -05:00
Bobby Holley
58322d0021 Add canary and journaling.
MozReview-Commit-ID: 582ZiTmcvgs
2017-10-07 12:54:17 -07:00