Commit graph

33454 commits

Author SHA1 Message Date
Xidorn Quan
a0edeb1a92
style: Remove DeclarationPushMode::Update and related code.
Bug: 1473180
Reviewed-by: emilio
MozReview-Commit-ID: 1fI5YRa54lQ
2018-07-24 03:29:42 +02:00
Xidorn Quan
b14b2beaad
style: Add new algorithm for setting property to be used in later commit.
Bug: 1473180
Reviewed-by: emilio
MozReview-Commit-ID: CdM8hDB6rFj
2018-07-24 03:29:28 +02:00
Xidorn Quan
d245f8b579
style: Introduce a concept of logical group.
Bug: 1473180
Reviewed-by: emilio
MozReview-Commit-ID: GXlf8JNML4N
2018-07-24 03:29:15 +02:00
Emilio Cobos Álvarez
08dcd7fca0
style: Remove IS_STYLE_IF_VISITED.
Bug: 1474959
Reviewed-by: xidorn
MozReview-Commit-ID: 8rnlaMOJisA
2018-07-24 03:29:03 +02:00
Emilio Cobos Álvarez
4e1606bfaf
style: Push visited style computation a bit further down.
Bug: 1474959
Reviewed-by: xidorn
MozReview-Commit-ID: 1DILenWIw4D
2018-07-24 03:28:50 +02:00
Emilio Cobos Álvarez
45435a57e9
style: Cleanup might_need_transitions_update.
Thought I had to update this as well, but nope. When basically any style changes
we already update transitions.

needs_transitions_update already handles the physical mapping changing by
checking whether any transition for the physical property remain there or not.

Bug: 1309752
Reviewed-by: birtles
MozReview-Commit-ID: 6vKwal4yzRU
2018-07-24 03:28:36 +02:00
Emilio Cobos Álvarez
856e5d1db6
style: Update animations if the logical to physical property mapping changes.
Bug: 1309752
Reviewed-by: birtles
MozReview-Commit-ID: 1lbOcniojVO
2018-07-24 03:28:23 +02:00
Emilio Cobos Álvarez
5504cbdfd7
style: Animate logical properties.
The setup is that AnimationValue only contains physical properties, and
we physicalize when building keyframes and transitions.

Bug: 1309752
Reviewed-by: birtles
MozReview-Commit-ID: 9dI20N0LFrk
2018-07-24 03:28:10 +02:00
Emilio Cobos Álvarez
be9acba801
style: Introduce PropertyDeclaration::to_physical.
Bug: 1309752
Reviewed-by: heycam
MozReview-Commit-ID: FAL04K5G948
2018-07-24 03:27:56 +02:00
Bobby Holley
89880727ec
style: Use an acquire load for is_unique in servo_arc.
Fixes #21186

Bug: 1476445
Reviewed-by: Manishearth
Differential Revision: https://phabricator.services.mozilla.com/D2205
2018-07-24 03:27:08 +02:00
Sylvestre Ledru
498592ff61
style: autopep8
Bug: 1468273
Reviewed-by: ted
MozReview-Commit-ID: 8j8EU3E08GP
2018-07-24 03:26:12 +02:00
bors-servo
b539ae7fe5
Auto merge of #21219 - paavininanda:Update_the_image_data, r=jdm
Complete remaining algo update_the_image_data

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #11416.

<!-- Either: -->
- [x] These changes do not require tests

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21219)
<!-- Reviewable:end -->
2018-07-23 14:54:50 -04:00
bors-servo
41f9f85040
Auto merge of #21236 - emilio:mutation-observer, r=jdm
script: A couple mutation observer fixes.

I felt like doing Servo stuff while trying to catch Gecko intermittents :)

This fixes most of #21233. I haven't dug into the other test.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21236)
<!-- Reviewable:end -->
2018-07-23 13:33:45 -04:00
Emilio Cobos Álvarez
39e647de06
script: Fix the logic for mutation observer attributes. 2018-07-23 19:28:29 +02:00
Emilio Cobos Álvarez
073629076f
script: Avoid useless string clones in mutation observer stuff. 2018-07-23 19:28:29 +02:00
Emilio Cobos Álvarez
e4f978e215
script: Queue a mutation record from CharacterData::append_data. 2018-07-23 19:06:22 +02:00
bors-servo
e80dfd616d
Auto merge of #21230 - servo-wpt-sync:wpt_update_22-07-2018, r=jdm
Sync WPT with upstream (22-07-2018)

Automated downstream sync of changes from upstream as of 22-07-2018.
[no-wpt-sync]

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21230)
<!-- Reviewable:end -->
2018-07-23 09:00:24 -04:00
bors-servo
c71fafaff7
Auto merge of #21225 - cbrewster:rustfmt_constellation, r=paulrouget
Rustfmt the constellation

<!-- Please describe your changes on the following line: -->
Yay for consistency!

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because just formatting things

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21225)
<!-- Reviewable:end -->
2018-07-23 01:00:00 -04:00
WPT Sync Bot
a5af9a106a Update web-platform-tests to revision 3f9178031eec5374c9a7d5709a7e11ba4a1955ed 2018-07-22 22:39:46 -04:00
bors-servo
8933a06eb8
Auto merge of #21229 - ergunsh:merge-run-wpt, r=jdm
Merge run_wpt.py into run.py

<!-- Please describe your changes on the following line: -->
To ensure everything is still works, one can run `./mach test-wpt tests/wpt/mozilla/DOMParser.html`

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #21201 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21229)
<!-- Reviewable:end -->
2018-07-22 18:11:46 -04:00
ergunsh
ae20469636 merge run_wpt.py into run.py 2018-07-22 22:59:59 +03:00
bors-servo
4997ec26c2
Auto merge of #21228 - jdm:syncupdate, r=jdm
Update sync commit.
2018-07-22 12:16:50 -04:00
Josh Matthews
c650e6814a Update sync commit. 2018-07-22 12:10:43 -04:00
Connor Brewster
a2064cef28 Rustfmt the constellation 2018-07-21 15:03:23 -06:00
bors-servo
a97d8b99ef
Auto merge of #21048 - cbrewster:hash_change_history, r=asajeffrey
Track hash changes in session history

<!-- Please describe your changes on the following line: -->
Adds tracking of hash changes in the session history.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #14970 fix #13437 (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21048)
<!-- Reviewable:end -->
2018-07-21 14:39:25 -04:00
Connor Brewster
61442cce4b Track hash changes in session history
Notify history changed on pushState and scroll to frag
2018-07-21 12:38:51 -06:00
paavininanda
5b77926460 Step3,4,5 2018-07-21 15:13:43 +05:30
bors-servo
37a73d3bc0
Auto merge of #21213 - servo:android-wpt, r=nox+jgraham
Add some support for WPT tests in an Android emulator through WebDriver

This succeeds on my machine:

`./mach test-wpt --product servodriver --binary etc/run_in_headless_android_emulator.py --binary-arg servo-x86 --binary-arg target/i686-linux-android/release/servo.apk /_mozilla/mozilla/DOMParser.html`

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21213)
<!-- Reviewable:end -->
2018-07-20 18:53:23 -04:00
bors-servo
aa76909f55
Auto merge of #21215 - nupurbaghel:update_source_set, r=jdm
Implement step 5 of select_image_source

<!-- Please describe your changes on the following line: -->
This step is responsible for selecting an image source based on user agent's environment( closest value which is greater than user's pixel density)
In case of no device, maximum density source is selected.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #11416

<!-- Either: -->
- [x] These changes do not require tests because tests are already present

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21215)
<!-- Reviewable:end -->
2018-07-20 17:25:14 -04:00
nupurbaghel
c881c2a0fb implement step 5 of select_image_source 2018-07-21 01:44:20 +05:30
Simon Sapin
2b5bba6f12 servodriver: increase browser’s init_timeout 2018-07-20 18:13:59 +02:00
Simon Sapin
45b710b7f0 Add ./mach test-wpt-android 2018-07-20 17:11:02 +02:00
bors-servo
1a9943d736
Auto merge of #21216 - Eijebong:parking_lot, r=emilio
Update parking_lot to 0.6

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21216)
<!-- Reviewable:end -->
2018-07-20 10:34:57 -04:00
Simon Sapin
230a6da5ff servodriver: fix setting preferences
This makes `/_mozilla/mozilla/webgl/context_creation_error.html` pass,
for example.

```
./ mach test-wpt --product servodriver \
  --binary etc/run_in_headless_android_emulator.py \
  --binary-arg servo-x86 \
  --binary-arg target/i686-linux-android/release/servo.apk \
  /_mozilla/mozilla/webgl/context_creation_error.html
```
2018-07-20 15:58:41 +02:00
bors-servo
c1cc2aaf9c
Auto merge of #21217 - servo-wpt-sync:wpt_update_19-07-2018, r=jdm
Sync WPT with upstream (19-07-2018)

Automated downstream sync of changes from upstream as of 19-07-2018.
[no-wpt-sync]

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21217)
<!-- Reviewable:end -->
2018-07-19 22:49:42 -04:00
WPT Sync Bot
158f7eec0e Update web-platform-tests to revision abd18b3e018d25ed668d179c905b7869dca5e239 2018-07-19 22:44:23 -04:00
Bastien Orivel
ba9cbd87fb Update parking_lot to 0.6 2018-07-20 00:44:08 +02:00
Simon Sapin
cdd64604cf Don’t reverse-forward port "None"
```
 0:27.48 pid:4157 Traceback (most recent call last):
 0:27.48 pid:4157   File "/home/simon/servo1/etc/run_in_headless_android_emulator.py", line 212, in <module>
 0:27.48 pid:4157     sys.exit(main(*sys.argv[1:]))
 0:27.48 pid:4157   File "/home/simon/servo1/etc/run_in_headless_android_emulator.py", line 72, in main
 0:27.48 pid:4157     forward_webdriver(adb, args)
 0:27.48 pid:4157   File "/home/simon/servo1/etc/run_in_headless_android_emulator.py", line 163, in forward_webdriver
 0:27.48 pid:4157     ports = [int(part) for part in split if part]
 0:27.48 pid:4157 ValueError: invalid literal for int() with base 10: 'None'
```
2018-07-19 20:50:42 +02:00
Simon Sapin
f10b47465a More Python fixes for servodriver
```
Traceback (most recent call last):
  File "/home/simon/servo1/tests/wpt/web-platform-tests/tools/wptrunner/wptrunner/testrunner.py", line 90, in run
    rv = commands[command](*args)
  File "/home/simon/servo1/tests/wpt/web-platform-tests/tools/wptrunner/wptrunner/testrunner.py", line 110, in wait
    self.executor.wait()
  File "/home/simon/servo1/tests/wpt/web-platform-tests/tools/wptrunner/wptrunner/executors/base.py", line 209, in wait
    self.protocol.base.wait()
AttributeError: 'ServoWebDriverProtocol' object has no attribute 'base'
```
2018-07-19 20:50:28 +02:00
Simon Sapin
e6eca2bce4 run_in_headless_android_emulator: add some code comments 2018-07-19 20:12:58 +02:00
Simon Sapin
94d1acbcfd run_in_headless_android_emulator: add support for reverse port forwarding 2018-07-19 19:16:07 +02:00
Simon Sapin
d7495a2297 run_in_headless_android_emulator: add support for user stylesheets 2018-07-19 19:02:34 +02:00
Simon Sapin
33234affc9 run_in_headless_android_emulator: add port forwarding for webdriver 2018-07-19 18:52:17 +02:00
Simon Sapin
f5ff709c79 Refactor run_in_headless_android_emulator.py into more functions 2018-07-19 18:44:47 +02:00
bors-servo
908a642063
Auto merge of #21209 - servo:jdm-patch-20, r=SimonSapin
Resume WPT syncing on mac builders.

This reverts https://github.com/servo/servo/pull/21148 to avoid the virtualenv problems that come with using the linux builders.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21209)
<!-- Reviewable:end -->
2018-07-19 12:19:24 -04:00
Simon Sapin
48f6e168d4 Fix a webdriver timeout during server start up
When sending a webdriver load URL command soon enough after starting Servo,
that command could time out with a logged warning:

```
constellation: Webdriver load for closed browsing context (0,2).
```

When `closed` in this case really meant not opened yet.
2018-07-19 18:07:33 +02:00
Simon Sapin
4acdb81197 WebDriver timeout settings are not optional.
Not setting one of them in a SetTimeouts requests should not remove it.
This fixes a panicking `unwrap()`.
2018-07-19 18:07:33 +02:00
Simon Sapin
c05d30d116 Add --binary-arg support in ./mach test-wpt --product servodriver 2018-07-19 18:07:33 +02:00
Simon Sapin
9b80369efb Make servodriver wait until the server starts accepting TCP connections 2018-07-19 18:07:33 +02:00
Simon Sapin
780e21c970 Fix Python errors in servodriver 2018-07-19 17:38:53 +02:00