Commit graph

33454 commits

Author SHA1 Message Date
Simon Sapin
e38a45bdaa Stop using Salt-installed Android SDK on CI 2018-07-16 15:10:21 +02:00
Anthony Ramine
e7631cea61 Move ANGLE name shenanigans to WebGL thread 2018-07-16 10:16:30 +02:00
Anthony Ramine
cbac5d05be Store active uniforms on the DOM side 2018-07-16 10:16:29 +02:00
bors-servo
a6f403c5f2
Auto merge of #21182 - gw3583:update-wr-more, r=jdm
Update WR for gradient API changes, and various dependencies.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21182)
<!-- Reviewable:end -->
2018-07-15 23:51:56 -04:00
Glenn Watson
1881a06c40 Updates for WR gradient API change. 2018-07-16 10:57:10 +10:00
Bastien Orivel
6354cd9a5e WIP: Dedupe dependencies 2018-07-16 08:59:15 +10:00
bors-servo
8eb2a53e20
Auto merge of #21170 - gterzian:use_remote_event_task_source_for_eventsource, r=jdm
Use remote-event task source in EventSource

<!-- Please describe your changes on the following line: -->
Follow up on https://github.com/servo/servo/pull/21126, this again 'changes nothing', but will be useful for https://github.com/servo/servo/issues/21114 in the context of https://github.com/servo/servo/pull/21111.

Trying to break up work into smaller PR's ;)

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #21112 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21170)
<!-- Reviewable:end -->
2018-07-13 21:41:41 -04:00
bors-servo
3961e8d1eb
Auto merge of #19184 - bobthekingofegypt:fix/18706-abs-image-with-padding, r=mbrubeck
fix block size for absolute replaced element

Absolutely replaced elements with padding were incorrectly setting their
block size to include twice the padding values.  This attempts to stop
that extra padding for replaced elements but leave the working flow for
non replaced elements

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #18706 (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19184)
<!-- Reviewable:end -->
2018-07-13 20:18:27 -04:00
Gregory Terzian
baef63becd use remote-event task source in EventSource 2018-07-13 13:56:46 +08:00
bors-servo
f01f6ae6bf
Auto merge of #21167 - servo:jdm-patch-13, r=asajeffrey
Avoid virtualenv conflicts when running nightly jobs

To avoid the errors that appear in http://build.servo.org/builders/linux-nightly/builds/750, I'm trying to keep the regular mach virtualenv and the one used for test-perf separate.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21167)
<!-- Reviewable:end -->
2018-07-12 19:26:32 -04:00
bors-servo
8af9409339
Auto merge of #21166 - servo:android-x86, r=jdm
Test Android x86 on CI

Fixes https://github.com/servo/servo/issues/21124

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21166)
<!-- Reviewable:end -->
2018-07-12 16:47:26 -04:00
Simon Sapin
bfb3f2f66d Exiting on broken pipe is expected operation for the 'yes' program 2018-07-12 22:47:02 +02:00
Simon Sapin
abb2ac6d20 Test Android x86 on CI 2018-07-12 20:30:32 +02:00
Simon Sapin
8dc2457931 Remove unused --update parameter to ./mach bootstrap-android 2018-07-12 16:01:28 +02:00
Josh Matthews
f37699d682
Use an explicit virtualenv name when running perf tests. 2018-07-12 09:41:43 -04:00
bors-servo
4dfb41fdb3
Auto merge of #21159 - kleinph:doc-specified-float-clear, r=jdm
Add doc comments to specified `float` and `clear` CSS properties

As discussed in #21156. I also added the doc comment to `float`.

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

No tests needed as this in only a doc change.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21159)
<!-- Reviewable:end -->
2018-07-11 20:11:19 -04:00
bors-servo
b411536165
Auto merge of #21162 - servo:android-x86-noop, r=SimonSapin
Add a no-op 'android-x86' set of Buildbot steps

This seems to exist before we configure Buildbot to look for it. Actual compilation and testing steps will be added once Buildbot is configured to run them.

CC https://github.com/servo/servo/issues/21124, https://github.com/servo/servo/issues/21116.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21162)
<!-- Reviewable:end -->
2018-07-11 17:32:23 -04:00
bors-servo
a4e8164dd0
Auto merge of #20543 - kwonoj:chore-bulid-win32, r=jdm
build(mach): locate vs via vswhere on win32

<!-- Please describe your changes on the following line: -->
This PR tries to improve Visual Studio installation lookup in mach.

It includes changes
- lookup VS2017 installation via `vswhere` (https://github.com/Microsoft/vswhere) allows non-default location installation eventually.
: currently PR does uses vswhere binary from VS installation itself, but vswhere binary can be placed separately without VS (github repo publishes binary releases also) - allows VS lookup without any dependency to binary / path / or env variables. For VS15, it falls back to same logic based on file path as vswhere supports from VS17 and above.

- assign environment variable in python process
: This is mostly for some non-default win32 environment who doesn't uses cmd.exe as default shell (myself). For example, if default shell is zsh, running vcvarsall.bat doesn't inherit env variable into current shell. Instead, this PR borrows implementation of Electron (https://github.com/electron/electron/blob/master/script/lib/env_util.py) which established inheriting env variable into python process itself, doesn't care about primary shell invoked scripts.

Still `mach.bat` remains for compatibility purpose, but `mach` take cares of all of jobs.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [ ] `./mach build-geckolib` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____
- Locally built & run on windows machine
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20543)
<!-- Reviewable:end -->
2018-07-11 16:19:47 -04:00
Simon Sapin
b25483d012 Add a no-op 'android-x86' set of Buildbot steps
This seems to exist before we configure Buildbot to look for it.
Actual compilation and testing steps will be added once Buildbot
is configured to run them.

CC https://github.com/servo/servo/issues/21124,
https://github.com/servo/servo/issues/21116
2018-07-11 20:39:03 +02:00
Anthony Ramine
a5b800970a Remove WebGLCommand::GetActiveAttrib 2018-07-11 11:55:50 +02:00
Philipp Klein
5e43fe330d Add doc comments to specified float and clear CSS property 2018-07-11 08:07:58 +02:00
bors-servo
f66c9b6160
Auto merge of #21156 - kleinph:move-clear-outside-mako, r=emilio
style: Move `clear` CSS property outside mako

This is part of issue #19015.

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21155

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21156)
<!-- Reviewable:end -->
2018-07-10 09:31:02 -04:00
bors-servo
8988d674d0
Auto merge of #21126 - gterzian:tasksource_specific_cancelation, r=jdm
Introduce "per task source" cancellation

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #21119 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21126)
<!-- Reviewable:end -->
2018-07-10 08:23:34 -04:00
Philipp Klein
85af4145c3 style: Move clear CSS property outside mako
closes #21155
2018-07-10 09:18:33 +02:00
Gregory Terzian
671627e97e introduce "per task source" ignoring of tasks 2018-07-10 13:42:28 +08:00
bors-servo
2bc70e738b
Auto merge of #21139 - kleinph:move-float-clear-outside-mako, r=emilio
style: Move `float` CSS property outside mako

Hi, I am fairly new to Rust and this is my first contribution to a Rust project.

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21130

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

I'm not sure if the approach with the two enums is good. Please let me know if this can be improved.
Regarding the tests I'm unsure: `tests/wpt/web-platform-tests/css/css-display/display-contents-float-001.html` seems to fail already before this PR, (and the cause is maybe not related to the style property definition).

Also I would like to add some docs, is it allowed to use the descriptions from MDN (https://developer.mozilla.org/en-US/docs/Web/CSS/float).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21139)
<!-- Reviewable:end -->
2018-07-09 22:00:25 -04:00
bors-servo
82213cce6f
Auto merge of #21120 - paavininanda:HTMLSourceElementIDL_attributes, r=jdm
Exposing HTMLSourceElement IDL attributes

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21120)
<!-- Reviewable:end -->
2018-07-09 20:47:09 -04:00
bors-servo
934848c1a1
Auto merge of #21148 - servo:jdm-patch-10, r=SimonSapin
Run WPT sync on a machine with a case-sensitive filesystem.

This works around #21145.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21148)
<!-- Reviewable:end -->
2018-07-09 19:14:52 -04:00
Josh Matthews
55a8de5d6b
Run WPT sync on a machine with a case-sensitive filesystem. 2018-07-09 16:58:24 -04:00
bors-servo
493bb05ed0
Auto merge of #21099 - servo-wpt-sync:wpt_update_28-06-2018, r=jdm
Sync WPT with upstream (28-06-2018)

Automated downstream sync of changes from upstream as of 28-06-2018.
[no-wpt-sync]

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21099)
<!-- Reviewable:end -->
2018-07-09 15:02:26 -04:00
bors-servo
52ccdba05f
Auto merge of #21143 - servo:webgl, r=jdm
Make some WebGL tests have a long timeout (fixes #20883)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21143)
<!-- Reviewable:end -->
2018-07-09 10:46:49 -04:00
Anthony Ramine
36b6b86ad4 Make some WebGL tests have a long timeout (fixes #20883) 2018-07-09 16:39:33 +02:00
Anthony Ramine
00d9f55f35 Update outdated expectations 2018-07-09 16:39:33 +02:00
Anthony Ramine
6d91cadcdf Update the Khronos test suites 2018-07-09 16:39:33 +02:00
bors-servo
3dc560761e
Auto merge of #21142 - servo:webgl, r=emilio
A couple of small WebGL fixes

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21142)
<!-- Reviewable:end -->
2018-07-09 09:29:29 -04:00
Anthony Ramine
ef7d495838 Properly implement the checks for gl.renderbufferStorage (fixes #20563) 2018-07-09 15:27:51 +02:00
Anthony Ramine
fc0e403fb0 Implement attribute aliasing check (fixes #21136) 2018-07-09 15:27:49 +02:00
Philipp Klein
c7871811c8 style: Move float CSS property outside mako
closes #21130
2018-07-09 12:47:07 +02:00
bors-servo
6554a40331
Auto merge of #21140 - emilio:gecko-sync, r=emilio
style: Sync changes from mozilla-central.

See each individual commit for details.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21140)
<!-- Reviewable:end -->
2018-07-08 21:23:22 -04:00
Emilio Cobos Álvarez
628ab7db01
style: Fix servo build. 2018-07-09 03:22:52 +02:00
Emilio Cobos Álvarez
d9d0186117
style: Trivial indentation fix.
MozReview-Commit-ID: JqBxF7i0HQZ
2018-07-09 03:05:45 +02:00
Emilio Cobos Álvarez
9f8c80fb3a
style: Make writing-mode and direction non-animatable.
Per https://github.com/w3c/csswg-drafts/issues/2751

Bug: 1473779
Reviewed-by: heycam
2018-07-09 03:05:32 +02:00
Emilio Cobos Álvarez
a11dcefee7
style: Reformat most of inherited_box.mako.rs.
image-orientation is being changed as we speak, so I left it there to avoid
bitrot.

Bug: 1473779
Reviewed-by: heycam
2018-07-09 03:05:19 +02:00
Emilio Cobos Álvarez
6518b0adfa
style: Other minor properties.mako.rs cleanups and improvements.
Also, add an is_logical method, which we'll use in a bit.

Bug: 1473793
Reviewed-by: heycam
MozReview-Commit-ID: Hq63wgbiRRu
2018-07-09 03:05:04 +02:00
Emilio Cobos Álvarez
263d4258ea
style: Add a clone helper that works regardless of whether the property is logical.
Bug: 1473793
Reviewed-by: heycam
2018-07-09 03:04:36 +02:00
Emilio Cobos Álvarez
769188ddbb
style: Remove dead code.
Bug: 1473793
Reviewed-by: heycam
2018-07-09 03:04:21 +02:00
Bobby Holley
50a85a5dd6
style: Cap the number of style threads at six.
Differential Revision: https://phabricator.services.mozilla.com/D1928
Bug: 1431285
Reviewed-by: emilio
2018-07-09 03:04:01 +02:00
Emilio Cobos Álvarez
c23dca874f
style: Reformat font.mako.rs.
To be consistent, use the block indentation the rest of the Rust code uses.

Differential Revision: https://phabricator.services.mozilla.com/D1906
Bug: 1472552
Reviewed-by: xidorn
2018-07-09 03:03:41 +02:00
bors-servo
41e105733c
Auto merge of #21129 - servo:webgl, r=emilio
Implement instanced WebGL drawing calls (part of #20791)

This is half of #20599. The check for drawElements is a bit more complex to implement.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21129)
<!-- Reviewable:end -->
2018-07-08 04:45:37 -04:00
Anthony Ramine
4e6eea221a Implement instanced WebGL drawing calls (part of #20791) 2018-07-08 10:44:45 +02:00