Commit graph

13806 commits

Author SHA1 Message Date
Florian Merz
a918df9e6f change comments to complete sentences 2015-11-03 23:53:34 +01:00
Florian Merz
c26b80cf4f add get_insertion_point_index_for_layout
This resolves #8107
Previously the index of the insetion point for a password input was
calculated using the scrambled string based on the edit point in the
raw string. That could lead to a wrong position of the caret. This
commit changes this behavior to calculate the insertion point using
the raw string.
This is done in
`HTMLInputElementHelpers::get_insertion_point_index_for_layout`
and relies on a 1:1 mapping of the chars in the raw input to the
scrambled chars (currently bullets) in the password input.
2015-11-03 21:55:41 +01:00
bors-servo
3fdaa6e3f3 Auto merge of #8232 - mbrubeck:glutin-touch, r=glennw
Correct event dispatching for multiple simultaneous touch points

Instead of just converting the mouse into a single "touch" input, Servo can now listen for multi-touch events from Glutin, maintain a list of active touch points, and dispatch events for all of them.

r? @glennw (for the compositor changes) and @jdm (for the DOM changes)

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8232)
<!-- Reviewable:end -->
2015-11-03 22:45:21 +05:30
Matt Brubeck
ef93650db9 Handle multi-touch events from glutin 2015-11-03 08:56:34 -08:00
bors-servo
5070c873d0 Auto merge of #8111 - gilles-leblanc:issue-8002, r=SimonSapin
Compute value of float according to position value

According to CSS2 Section 9.7, if 'position' has a value of 'absolute'
or 'fixed' the computed value of 'float' should be 'none'.

This changes the float to a single_keyword_computed which checks the
positioned value of the element to compute the float value.

Fixes #8002

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8111)
<!-- Reviewable:end -->
2015-11-03 21:39:32 +05:30
bors-servo
23efa0a36f Auto merge of #8087 - asajeffrey:dont_dirty_twice, r=pcwalton
Removced unncessary call to dirty() in Document::node_and_heritage_ch…

Removed unncessary call to dirty() in Document::node_and_heritage_change, since the node is aready dirtied by force_dirty_ancestors().

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8087)
<!-- Reviewable:end -->
2015-11-03 21:04:39 +05:30
Alan Jeffrey
d3ea0a0256 Removced unncessary call to dirty() in Document::node_and_heritage_change, since the node is aready dirtied by force_dirty_ancestors(). 2015-11-03 09:08:13 -06:00
bors-servo
526a3c8df3 Auto merge of #8223 - mrobinson:pinch-zoom-2, r=pcwalton
Make executing synthesized pinch zoom more similar to zoom

Synthesized pinch zoom was removed in #8121 so that this combination of
mouse wheel and key press can be handled by the page. I mistakenly
re-implemented it #8215. In order to preserve synthesized pinch zoom,
which is very useful for testing on desktop computers, have it work
similarly to page zoom except with the ALT key pressed.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8223)
<!-- Reviewable:end -->
2015-11-03 19:22:38 +05:30
bors-servo
27fb2ed26d Auto merge of #8300 - pcwalton:avoid-animation-state-flooding, r=glennw
layout: Avoid flooding the compositor with animation state changes if there are no animations running and no new animations were added.

Avoids compositor jank during scroll.

r? @glennw

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8300)
<!-- Reviewable:end -->
2015-11-03 18:25:33 +05:30
bors-servo
108de991ae Auto merge of #8298 - jdm:webglreftests, r=metajack
Fix missing reference links in webgl tests.



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8298)
<!-- Reviewable:end -->
2015-11-03 17:17:20 +05:30
bors-servo
1794e5875a Auto merge of #8295 - Ms2ger:cleanup, r=jdm
Various cleanup.



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8295)
<!-- Reviewable:end -->
2015-11-03 16:28:14 +05:30
bors-servo
9a800becdf Auto merge of #8239 - Ms2ger:ScriptReflow, r=pcwalton
Remove unused code around ScriptReflow.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8239)
<!-- Reviewable:end -->
2015-11-03 15:29:17 +05:30
bors-servo
4f51710ed3 Auto merge of #8056 - eefriedman:trace-refcell, r=jdm
Fix the implementation of JSTraceable for RefCell.

The existing implementation could panic; make sure that doesn't
happen by requiring that the contents of a RefCell are trivially
traceable (i.e. the value don't contain any traceable objects).

I'm not sure whether the TriviallyJSTraceable trait is actually
worthwhile; maybe we should just never use RefCell in the DOM.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8056)
<!-- Reviewable:end -->
2015-11-03 07:07:40 +05:30
Patrick Walton
8d58197bf0 layout: Avoid flooding the compositor with animation state changes if
there are no animations running and no new animations were added.

Avoids compositor jank during scroll.
2015-11-02 16:34:17 -08:00
Eli Friedman
df7fb8fa32 Remove JSTraceable implementation from RefCell.
The implementation wasn't really right, and we would rather just use
DOMRefCell anyway.
2015-11-02 14:40:57 -08:00
Josh Matthews
1dfd48864a Fix missing reference links in webgl tests. 2015-11-02 15:08:36 -05:00
bors-servo
db1163b1ec Auto merge of #7414 - Adenilson:fixCanvasPanic01, r=pcwalton
Adding a reference test where a bigger area than the original element

Adding a reference test where a bigger area than the original element size is defined at script.

To pass, this depends in a fix on rust-azure (i.e. #195). No for commit, we need the rust-azure to land and next update the deps.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7414)
<!-- Reviewable:end -->
2015-11-03 00:22:46 +05:30
Adenilson Cavalcanti
b1197c31d1 The end of the MANIFEST odyssey. 2015-11-02 09:46:34 -08:00
Adenilson Cavalcanti
bcea688e1f Telling the test runner what compare the test with. 2015-11-02 09:13:16 -08:00
Adenilson Cavalcanti
4fdf73d105 Adding a reference test where a bigger area than the original
element is defined in script.

The test is now using wpt infrastructure (thanks Manishearth!).
2015-11-02 08:53:21 -08:00
Ms2ger
d3d1f2b5c4 Simplify DOMTokenList::Item. 2015-11-02 16:04:50 +01:00
Ms2ger
13291c4b64 Avoid some string copies in handle_modify_attribute. 2015-11-02 16:04:49 +01:00
bors-servo
5c11c88e92 Auto merge of #8294 - Ms2ger:layout-input, r=jdm
Remove RawLayoutHTMLInputElementHelpers.



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8294)
<!-- Reviewable:end -->
2015-11-02 19:44:51 +05:30
bors-servo
3282174a99 Auto merge of #8291 - ecoal95:webgl-drop, r=jdm
Add destructors to some WebGL objects, remove duplicated glutin dependency and try to enable the webgl reftests

The first commit allows to cleanup the gl resources of the webgl task earlier if they aren't being used.
Right now all resources were cleaned up when the context was destroyed, so I think this is
a slightly better approach.

The second commit bumps rust-offscreen-rendering-context to remove the duplicated glutin dependency.

The third one tries to reenable the webgl reftests.
Since the errored builds are deleted, It's the only way I can try to troubleshoot it.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8291)
<!-- Reviewable:end -->
2015-11-02 18:52:33 +05:30
Emilio Cobos Álvarez
8fff34e2e7 Disable WebGL reftests on linux 2015-11-02 14:05:05 +01:00
Ms2ger
0dacd33102 Remove RawLayoutHTMLInputElementHelpers. 2015-11-02 11:42:39 +01:00
bors-servo
50d51bab7f Auto merge of #8245 - eefriedman:misc-attribute-fixes, r=nox
Use attribute getter/setter macros for misc DOM attributes.

This fixes a few minor bugs.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8245)
<!-- Reviewable:end -->
2015-11-02 15:14:32 +05:30
bors-servo
e72bd1437c Auto merge of #7400 - dzbarsky:angle, r=mbrubeck
Allow more valid use of calc expressions



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7400)
<!-- Reviewable:end -->
2015-11-02 12:46:43 +05:30
David Zbarsky
00980ea595 Implement calc expressions for more value types 2015-11-01 23:16:14 -08:00
bors-servo
35b452660b Auto merge of #8193 - dzbarsky:event_type, r=nox
Use an Atom for Event.type

Depends on https://github.com/servo/string-cache/pull/113

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8193)
<!-- Reviewable:end -->
2015-11-02 05:57:28 +05:30
Eli Friedman
cf8f2b1874 Use attribute getter/setter macros for misc DOM attributes.
This fixes a few minor bugs.

Also adds some better testing for "unsigned long" attributes.
2015-11-01 12:47:28 -08:00
Emilio Cobos Álvarez
641e54bd41 Bump offscreen_gl_context
This new version shold prevent crashing on the linux buildbots.
2015-11-01 20:51:23 +01:00
Emilio Cobos Álvarez
12d1464220 Move WebGL reftests to wpt/mozilla 2015-11-01 20:30:39 +01:00
Emilio Cobos Álvarez
938a05428a servo/main: Load gl symbols in headless mode
This allows running WebGL reftests in wpt.
2015-11-01 20:30:38 +01:00
bors-servo
2e4454a423 Auto merge of #8192 - nxnfufunezn:brotli-decompressor, r=jdm
Accept Brotli-compressed HTTP responses #8156

r? @jdm

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8192)
<!-- Reviewable:end -->
2015-11-01 23:13:21 +05:30
David Zbarsky
0070adb71f Use an Atom for Event.type 2015-11-01 09:42:11 -08:00
bors-servo
0e70a1f8a8 Auto merge of #7965 - frewsxcv:labelable-elements-label-attribute, r=nox
Implement 'labels' attribute on 'labelable elements'



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7965)
<!-- Reviewable:end -->
2015-11-01 20:51:18 +05:30
Corey Farwell
9df375195e Implement 'labels' attribute on 'labelable elements' 2015-11-01 09:50:14 -05:00
Emilio Cobos Álvarez
35473b0009 Try to re-enable webgl reftests
I can't reproduce locally the failure that produced them, and since the
builds that triggered them are deleted for some reason (like
http://build.servo.org/builders/linux-dev/builds/419), it could be a
good moment to troubleshoot it.

If merged closes #7931
2015-11-01 13:45:02 +01:00
Emilio Cobos Álvarez
2c87249311 Bump offscreen_rendering_context to remove duplicated Glutin dependency 2015-11-01 13:44:31 +01:00
Emilio Cobos Álvarez
95a0d0584f webgl: Add destructors for texture, program, shader, buffer and framebuffer
This allows to cleanup resources earlier if they stop being used. Right
now all resources were cleaned up when the context was destroyed, this is
a slightly better approach.

We ignore the possible failure of the send() call, since we don't keep
track of these resources from the `WebGLRenderingContext` structure, so
a texture could be destroyed after the context and give us problems.
2015-11-01 13:39:20 +01:00
bors-servo
601169c0e5 Auto merge of #8290 - itsmeolivia:store-script-reflow, r=Ms2ger
Un-boxed ScriptReflow

As per #8238 I changed `layout_interface::Msg::Reflow` to store `ScriptReflow` rather than `Box<ScriptReflow>` 

I ran the tests and believe everything passed but this is my first commit to the project so sorry if I messed up the protocol!

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8290)
<!-- Reviewable:end -->
2015-11-01 14:50:17 +05:30
Olivia Nordquist
aebf87cf5b Un-boxed ScriptReflow 2015-10-31 22:29:16 -07:00
nxnfufunezn
468eaac096 Accept Brotli-compressed HTTP responses #8156 2015-11-01 08:59:18 +05:30
bors-servo
959ae86bd0 Auto merge of #8274 - bholley:state_restyle_hints, r=pcwalton
Implement state-based restyle hints



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8274)
<!-- Reviewable:end -->
2015-11-01 07:23:51 +05:30
bors-servo
1add1185ab Auto merge of #8287 - eefriedman:label-unused-var, r=Manishearth
Fix unused variable warnings.



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8287)
<!-- Reviewable:end -->
2015-11-01 06:19:03 +05:30
bors-servo
4cf49d4d09 Auto merge of #8037 - eefriedman:net-send-sniff, r=jdm
Consistently use content-type sniffing with all protocols.



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8037)
<!-- Reviewable:end -->
2015-11-01 03:50:29 +05:30
Bobby Holley
564170f41b State restyle hint tests.
This handles the state part of #6942.
2015-10-31 14:28:52 -07:00
Bobby Holley
45fc7f2930 Implement restyle hints for state changes. 2015-10-31 14:28:52 -07:00
Bobby Holley
41dfd07d16 Rev rust-selectors. 2015-10-31 14:28:51 -07:00