Commit graph

25671 commits

Author SHA1 Message Date
Fernando Jiménez Moreno
b22e0e9494 Stylo: Bug 1355408 - add support for @-moz-document 2017-05-09 12:52:44 +02:00
bors-servo
9c9bd17871 Auto merge of #16722 - UK992:clobber, r=SimonSapin
Add clobber mechanism

Solution for https://github.com/servo/servo/issues/16602 and https://github.com/servo/servo/issues/16632
Only work when `AUTOCLOBBER` environment variable is defined.

CC @SimonSapin @jdm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16722)
<!-- Reviewable:end -->
2017-05-08 23:53:05 -05:00
bors-servo
fc3a7d03f2 Auto merge of #16303 - froydnj:rayon-version-bump, r=jdm
bump required rayon version to 0.7

...and bring jpeg-decoder along for the ride.  Minor tweaks were necessary because of rayon API changes.

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16303)
<!-- Reviewable:end -->
2017-05-08 21:36:48 -05:00
bors-servo
8ff484d3fd Auto merge of #16767 - UK992:travis, r=jdm
Try to re-enable unit tests on travis-ci

After https://github.com/servo/servo/pull/16573 and https://github.com/servo/servo/pull/16593, issue https://github.com/servo/servo/issues/15076 _could_ be fixed.

Edit:
Closes #14723
Closes #15076

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16767)
<!-- Reviewable:end -->
2017-05-08 20:05:16 -05:00
bors-servo
fca15d3782 Auto merge of #16774 - emilio:unbust-stylo, r=Manishearth
Unbust stylo

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16774)
<!-- Reviewable:end -->
2017-05-08 18:59:33 -05:00
Emilio Cobos Álvarez
8bcb0e3e11
stylo: Update bindings. 2017-05-09 00:46:30 +02:00
Emilio Cobos Álvarez
29c52cc61b
stylo: Fix nsCOMPtr release bindings. 2017-05-09 00:46:27 +02:00
bors-servo
0d9b26f4e4 Auto merge of #16607 - canaltinova:moz-transform-var, r=SimonSapin
Fix variable serialization bug on shorthand alias properties

<!-- Please describe your changes on the following line: -->
-moz-transform were having a problem with variable serialization. It wasn't printing transform's value and transform wasn't printing -moz-transform's if their value was a variable. This PR fixes that.
Reduces stylo -moz-transform failures to 2: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3fd3a57873e5e98dfcb173eef4b13822a66fdf6a

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16607)
<!-- Reviewable:end -->
2017-05-08 17:34:54 -05:00
UK992
3f6703780b Try with enabled build-geckolib and test-stylo 2017-05-09 00:02:46 +02:00
UK992
be645794a6 Try to re-enable unit tests on travis-ci 2017-05-09 00:02:41 +02:00
bors-servo
19706085a7 Auto merge of #16756 - servo:rustup, r=jdm
Upgrade to rustc 1.19.0-nightly (ced823e26 2017-05-07)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16756)
<!-- Reviewable:end -->
2017-05-08 16:06:56 -05:00
bors-servo
4e3544f05c Auto merge of #16761 - Ksbugbee:master, r=jdm
Use hash2 instead of deprecated hash

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16761)
<!-- Reviewable:end -->
2017-05-08 13:42:32 -05:00
Ksbugbee
b4d894e119 Use hash2 instead of deprecated hash
Removed X's from PULL_REQUEST_TEMPLATE.md

Commented changes
2017-05-08 13:39:28 -04:00
bors-servo
81f273b66f Auto merge of #16392 - fitzgen:update-bindgen-dependency, r=emilio
Update the style crate's bindgen dependency to 0.24.0

<!-- Please describe your changes on the following line: -->

Update style's dependency on bindgen from 0.22 to 0.23

This introduces a huge mess of transitive dependency versioning issues with `bitflags`, which I'm going to just ignore for now. Will file a follow up issue to address them properly.

r? @emilio

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because bindgen has its own tests, including building stylo's bindings now.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16392)
<!-- Reviewable:end -->
2017-05-08 12:19:59 -05:00
Nick Fitzgerald
1cfd3ce5d3 Update the style crate's bindgen dependency 2017-05-08 09:32:16 -07:00
UK992
d03e52d240 Add clobber mechanism 2017-05-08 16:19:56 +02:00
bors-servo
a5fe464e4a Auto merge of #16762 - upsuper:buildtime-pseudo, r=emilio
Generate atom files at build-time

The commits here basically do the following things:
1. move all generated files for gecko into "gecko/generated" so that we can copy all of them around
2. make regen_atoms.py generate file to the out dir rather than in-tree
3. make the build script invoke regen_atoms.py when bindgen feature is enabled

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16762)
<!-- Reviewable:end -->
2017-05-08 07:35:19 -05:00
Xidorn Quan
ff76ec8d2f Copy all generated files to dist dir for packaging. 2017-05-08 21:34:00 +10:00
Xidorn Quan
10b7001dd1 Make atom files generated at build-time. 2017-05-08 21:33:58 +10:00
Xidorn Quan
d44b904f08 Move python path into a lazy static. 2017-05-08 21:33:57 +10:00
Xidorn Quan
5b57c5513c Move atom_macro.rs to generated dir. 2017-05-08 21:33:55 +10:00
Xidorn Quan
869e5e025e Rename gecko_ prefix of pseudo_element_helper file. 2017-05-08 21:33:53 +10:00
Xidorn Quan
a60e5f0218 Move binding files into another directory.
So that we can copy them when not using bindgen altogether.
2017-05-08 21:26:58 +10:00
bors-servo
34d33574db Auto merge of #16766 - emilio:border-radius, r=glennw
layout: Fix radius percentage resolution.

Fixes #16764

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16766)
<!-- Reviewable:end -->
2017-05-08 06:24:42 -05:00
Simon Sapin
02e1901bc1 Upgrade to rustc 1.19.0-nightly (ced823e26 2017-05-07) 2017-05-08 12:46:03 +02:00
Emilio Cobos Álvarez
c9ab75b013
layout: Fix radius percentage resolution.
By resolving against the corresponding dimension of the border box, instead of
against the width.

Fixes #16764
2017-05-08 11:48:29 +02:00
Emilio Cobos Álvarez
39471cda1b
layout: Avoid a few dumb refcount bumps. 2017-05-08 11:48:28 +02:00
bors-servo
f6bd158fd4 Auto merge of #16593 - UK992:clean-cargo-cache, r=wafflespeanut
Mach: Add `mach clean-cargo-cache` command

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16593)
<!-- Reviewable:end -->
2017-05-08 04:37:21 -05:00
UK992
63b19c5bb6 Update .travis.yml 2017-05-08 11:28:18 +02:00
UK992
66ea4b21d0 Add mach clean-cargo-cache command 2017-05-08 11:25:21 +02:00
bors-servo
2119c16b66 Auto merge of #16765 - CJKu:bug-1310885-part-1, r=heycam
stylo: Export mozilla::css::ImageValue to stylo.

<!-- Please describe your changes on the following line: -->
This is "Bug 1310885 - Part 0. (gecko) Export mozilla::css::ImageValue to stylo."
We need to land it separately to prevent build break.

Link to the gecko bug:
https://bugzilla.mozilla.org/show_bug.cgi?id=1310885.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16765)
<!-- Reviewable:end -->
2017-05-08 03:28:48 -05:00
cku
ba8e33a30c stylo: Export mozilla::css::ImageValue to stylo. 2017-05-08 15:45:31 +08:00
Xidorn Quan
35dc68c234 Stop touching in-tree files from build-geckolib.
This stops:
* generating atom helper files from regen_atoms.py
* copying generated binding files to in-tree
2017-05-08 14:19:03 +10:00
bors-servo
4e390e2630 Auto merge of #16759 - glennw:subpixel, r=cbrewster
Enable subpixel anti-aliasing on text by default.

No doubt there are still some bugs and missing features related to subpixel text anti-aliasing.

But enabling by default should allow us to detect these and fix them.

If we run into any major issues, this is a standalone commit that can be reverted while we fix the problem.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16759)
<!-- Reviewable:end -->
2017-05-07 20:27:46 -05:00
Glenn Watson
a2d3b053c3 Enable subpixel anti-aliasing on text by default.
No doubt there are still some bugs and missing features related to subpixel text anti-aliasing.

But enabling by default should allow us to detect these and fix them.

If we run into any major issues, this is a standalone commit that can be reverted while we fix the problem.
2017-05-08 11:15:55 +10:00
Xidorn Quan
1d6ede3245 Expose a single function for bindings mod in build_gecko. 2017-05-08 10:52:23 +10:00
bors-servo
f0cf9f47b5 Auto merge of #16758 - glennw:update-wr-xf-subpixel, r=KiChjang
Update WR (transform shader select optimization, subpixel + disable AA fix).

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16758)
<!-- Reviewable:end -->
2017-05-07 19:18:32 -05:00
bors-servo
c171ded902 Auto merge of #16757 - zombiefungus:issue16716, r=KiChjang
Remove obsolete paint threads option #16716

<!-- Please describe your changes on the following line: -->
Remove paint_threads from `ports/cef/core.rs` and `components/config/opts.rs`

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #16716

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16757)
<!-- Reviewable:end -->
2017-05-07 17:09:47 -05:00
Glenn Watson
f872ad9452 Update WR (transform shader select optimization, subpixel + disable AA fix). 2017-05-08 07:54:27 +10:00
zombiefungus
9591d1eda5 Remove obsolete paint threads option #16716 2017-05-07 14:00:25 -05:00
bors-servo
3f1ae64255 Auto merge of #16666 - pyfisch:gradients, r=emilio
Improvements to gradients.

This is a collection of commits improving the rendering of linear and radial gradients by making them conform more closely to the spec.

All commits are are independent and should work without the others.

These commits address the following issues:
* a956e3fd52 resolves #3908 but contains also some other necessary changes to `convert_gradient_stops`. The updated function has a few more copys but should be more correct. Maybe @pcwalton wants to comment since he has originally written the code.
* b230be8aaf partially solves #16638. (Partially because `border-image-outset` is not implemented. This is an older issue for border gradients: #15894.

To quickly catch regressions and see changes to gradients I have created [a set of twelve manual testcases](https://pyfisch.org/stuff/testcases-gradients.html) and placed them in a single file. Attached are two files. One shows how the gradients were rendered before the PR the other one with the changes applied.

![testcases-old](https://cloud.githubusercontent.com/assets/2781017/25580052/b433278e-2e7d-11e7-9396-500fef12eee0.png)
![testcases-new](https://cloud.githubusercontent.com/assets/2781017/25580051/b43222c6-2e7d-11e7-99ab-c0a2709baf41.png)

r? @emilio
and maybe also @jdm?

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16666)
<!-- Reviewable:end -->
2017-05-07 07:56:51 -05:00
Pyfisch
f4fadc7875 Address feedback by emilio. 2017-05-07 12:28:57 +02:00
bors-servo
bd2cd40c50 Auto merge of #16754 - canaltinova:text-shadow, r=emilio
Fix parsing behavior of text-shadow property

Blur radius should reject negative values. There was already `Shadow` struct for properties like this. `filter: drop-shadow` also has the same syntax with that property. I thought sharing the same code would be better and used Shadow struct for parsing. Converted to SpecifiedTextShadow to get rid of unneccessary fields and to be able to convert its computed value. Maybe it would be better to avoid using `Shadow` or just using `Shadow` but sharing code and avoiding unneccessary fields seems better.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16754)
<!-- Reviewable:end -->
2017-05-06 16:10:22 -05:00
Nazım Can Altınova
c072f3ab18
Clean up text-shadow property 2017-05-07 00:05:08 +03:00
Pyfisch
72db8d8555 Duplicate first gradient stop if necessary.
If the first stop of a non-repeating gradient is
not placed at offset 0.0 it is duplicated at this
position. This solves the problem of the first
stop being ignored if it is placed at the same
offset as the next stop.
2017-05-06 21:43:22 +02:00
Nazım Can Altınova
1e975b9833
Properly parse text-shadow property 2017-05-06 21:36:57 +03:00
bors-servo
806f369a79 Auto merge of #16750 - upsuper:bug1362302, r=Manishearth
Use nsIAtom for counter style name

This is the Servo side change of [bug 1362302](https://bugzilla.mozilla.org/show_bug.cgi?id=1362302) which has been reviewed on Bugzilla.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16750)
<!-- Reviewable:end -->
2017-05-05 23:15:08 -05:00
bors-servo
deff38597a Auto merge of #16751 - upsuper:update-bindings, r=jdm
Update binding files to autoland tip

Sync in-tree binding files with that generated from Gecko CI.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16751)
<!-- Reviewable:end -->
2017-05-05 22:22:33 -05:00
Xidorn Quan
8fd69b428d Update binding files to autoland tip. 2017-05-06 12:59:55 +10:00
Xidorn Quan
4a8f680557 Update binding file. 2017-05-06 12:50:10 +10:00