Commit graph

2603 commits

Author SHA1 Message Date
WPT Sync Bot
6ed2abf735 Update web-platform-tests to revision add24188a1226f3598ad6b455e71641c9ac6a5fd 2019-03-29 23:56:29 -04:00
WPT Sync Bot
cb63cfd5c7 Update web-platform-tests to revision 3bfdeb8976fc51748935c8d1f1014dfba8e08dfb 2019-03-29 00:51:32 -04:00
Fernando Jiménez Moreno
d15640081c Implement srcObject logic for Blob media providers 2019-03-27 07:11:29 +01:00
George Roman
e63de4d52c Update Event's timestamp 2019-03-26 09:39:07 +02:00
WPT Sync Bot
c858882d3c Update web-platform-tests to revision 3b0abc897b6f4f3997ed42b9ef902e98b2893d8d 2019-03-24 23:52:38 -04:00
bors-servo
7a67443fcb
Auto merge of #23086 - servo-wpt-sync:wpt_update_23-03-2019, r=jdm
Sync WPT with upstream (23-03-2019)

Automated downstream sync of changes from upstream as of 23-03-2019.
[no-wpt-sync]

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23086)
<!-- Reviewable:end -->
2019-03-24 08:30:11 -04:00
bors-servo
5f4030d028
Auto merge of #23011 - dboyan:open-feature-tokenize, r=gterzian,cybai
Add tokenizer for features in window.open

<!-- Please describe your changes on the following line: -->
This is a prototype implementation of feature tokenizer ~~and "noreferrer" feature~~ for window.open. I'm not very sure where the tokenizer code should be placed. Building now generates the following warning

```
warning: unused attribute
  --> components/script/dom/bindings/conversions.rs:74:5
   |
74 |     rustc_on_unimplemented(message = "The IDL interface `{Self}` is not derived from `{T}`.")
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: #[warn(unused_attributes)] on by default
```

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes _partially_ fix #22869 (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23011)
<!-- Reviewable:end -->
2019-03-24 05:31:24 -04:00
WPT Sync Bot
93d826f7ba Update web-platform-tests to revision 122a4672fa0dc554a6e7528fa3487fd907c792ee 2019-03-23 23:57:08 -04:00
Boyan Ding
f261799e64 Add a tokenizer for features in window.open() 2019-03-23 15:31:14 +08:00
bors-servo
059ac12c00
Auto merge of #23073 - sbansal3096:master, r=emilio
Expose public getter to stylesheet's owner

<!-- Please describe your changes on the following line: -->

- [x] expose a public getter on CSSStyleSheet to return the stylesheet's owner
- [x] in CSSRuleList::insert_rule, use the new getter to pass a non-None value as an argument to arc.insert_rule
- [x] add a test for this that verifies that the new stylesheet is actually loaded
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #23028

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23073)
<!-- Reviewable:end -->
2019-03-22 19:45:08 -04:00
bors-servo
525484a4d9
Auto merge of #22973 - paulrouget:wrupdate, r=emilio
WR update

~Need https://github.com/tomaka/winit/issues/803~

@emilio can I ask you to look at the *"WR udpate: layout"* commit? There are a few changes I'm not sure about (should_inflate, the new filters_data and cache_tiles).

Fix: #22993

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22973)
<!-- Reviewable:end -->
2019-03-22 08:48:16 -04:00
Paul Rouget
f1f7779c1a WR update: test ompositing_simple_div.html: PASS to FAIL 2019-03-22 18:23:46 +08:00
Paul Rouget
0b8ea51509 WR update: transform3d-perspective-005.html: PASS to FAIL 2019-03-22 18:23:46 +08:00
sbansal3096
13eebbfe56 Fix insertRule crash by exposing getter on stylesheet's owner 2019-03-22 15:45:18 +05:30
WPT Sync Bot
953dbda9a6 Update web-platform-tests to revision b7a8b84debb42268ea95a45bdad8f727d1facdf7 2019-03-21 23:44:37 -04:00
George Roman
c6433efc1d Implement XMLSerializer interface 2019-03-21 09:50:29 +02:00
bors-servo
93dc2295f7
Auto merge of #23051 - servo-wpt-sync:wpt_update_17-03-2019, r=jdm
Sync WPT with upstream (17-03-2019)

Automated downstream sync of changes from upstream as of 17-03-2019.
[no-wpt-sync]

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23051)
<!-- Reviewable:end -->
2019-03-20 18:53:44 -04:00
bors-servo
6d308c3577
Auto merge of #22480 - cdeler:implement-DOMException-constructor, r=jdm
Implement dom exception constructor

The constructor method was implemented

I have a question: should I edit `./mach test-wpt` expectations?

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #22412
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22480)
<!-- Reviewable:end -->
2019-03-20 16:13:17 -04:00
cdeler
76fed04f6b #22412 disabled /bluetooth/requestDevice/canonicalizeFilter wpt tests due to #23066 2019-03-20 22:36:02 +03:00
bors-servo
5ec725488f
Auto merge of #22923 - peterjoel:issue_8539_prefs_refactor, r=jdm
#8539 Config preferences backend restructure

<!-- Please describe your changes on the following line: -->

A procedural macro for generating static structures for use as the backend for config preferences, as well a mapping from string names to accessors.

Preferences can be accessed and updated via a map-like interface with `String` keys, and now also via a convenience macro: `get_pref!(path.to.pref)`. Various `serde`-compatible field attributes are also supported, including renaming the string keys. This could be useful when changing the backend structure without breaking existing usages.

I have added the choice to use `i64` as well as `f64` for storing numbers. As it turns out, none of the existing preferences used non-integer values. Setting a floating point value from a command-line argument requires a decimal point in order to parse correctly.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #8539

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

-----

I have a few outstanding problems or questions:

1. I am unable to get rid of this warning:
    ```
    warning: unnecessary path disambiguator
       --> components/config/prefs.rs:130:51
        |
    130 |         accessor_type = crate::pref_util::Accessor::<Prefs, crate::pref_util::PrefValue>,
        |                                                   ^^ try removing `::`
    ```
    See: https://stackoverflow.com/questions/54710797/how-to-disable-unnecessary-path-disambiguator-warning
2. Several of the preferences in use were not represented in `prefs.json`. Some of these may be in error, but it is hard to tell. For example `js.offthread_compilation.enabled` vs `js.ion.offthread_compilation.enabled` could be different preferences or could be intended to have the same value.
3. Previously, several pieces of code provided default values when accessing a preference that may not be present. For example:
    ```Rust
    let DBL_CLICK_TIMEOUT = Duration::from_millis(
        PREFS
            .get("dom.document.dblclick_timeout")
            .as_u64()
            .unwrap_or(300),
    );
    ```
    Fallback values don't really make sense now and I've added these defaults to `prefs.json`. Does this sound right?
4. I have kept `PrefValue::Missing`, though it doesn't seem very useful any more. An error might be more appropriate now for an incorrect preference key. I've kept this partly because [`webdriver_server` uses it](https://github.com/servo/servo/blob/master/components/webdriver_server/lib.rs#L224).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22923)
<!-- Reviewable:end -->
2019-03-20 14:33:37 -04:00
bors-servo
43cc2a0224
Auto merge of #23029 - KwanEsq:insertRuleNoIndex, r=SimonSapin
Update StyleSheet.insertRule WebIDL to make index optional.

Update wpt metadata to show the new passes.
Add one test as crashing since currently passing an \@import rule to insertRule
leads to "Expected a stylesheet loader for \@import"

---

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #23025
- [x] There are tests for these changes
- [x] ./mach test-wpt css/cssom passes with these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23029)
<!-- Reviewable:end -->
2019-03-20 13:04:13 -04:00
Peter Hall
8bfd4dc1e2 #8539 Config preferences backend restructure 2019-03-20 15:01:26 +00:00
Josh Matthews
7b4d1c6e4c Rebuild all manifests. 2019-03-20 10:50:58 -04:00
WPT Sync Bot
f2c1b70e4a Update web-platform-tests to revision c2e5b9fbaa17424f05ca2bb04609790a3b61d5c2 2019-03-20 10:50:56 -04:00
cdeler
18fe572562 #22412 updated bluetooth tests expectations 2019-03-20 16:56:55 +03:00
cdeler
e30f48f3c8 #22412 fixed PR issues - fixed wpt tests expectations 2019-03-20 13:19:00 +03:00
cdeler
220a471b14 implemented missed constructor for DOMException; fixed the tests expectations 2019-03-19 22:49:14 +03:00
bors-servo
34fda66dfa
Auto merge of #22891 - georgeroman:implement_cdatasection, r=Manishearth
Implement CDATASection interface and createCDATASection method

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #22846

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22891)
<!-- Reviewable:end -->
2019-03-18 17:22:55 -04:00
WPT Sync Bot
ad4cc3691e Update web-platform-tests to revision 2d68590d46a990bf28a08d6384a59962d2e56bf6 2019-03-14 23:41:26 -04:00
George Roman
4b8282b3b1 Implement CDATASection interface and createCDATASection method 2019-03-14 21:41:02 +02:00
bors-servo
bc03d32142
Auto merge of #23016 - pngai:remove-on-prefix, r=jdm
Remove 'on' prefix from event handler macros

<!-- Please describe your changes on the following line: -->
Remove 'on' prefix from event handler macros

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #22516 (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23016)
<!-- Reviewable:end -->
2019-03-14 15:14:44 -04:00
Ian Moody
948e169e51 Update StyleSheet.insertRule WebIDL to make index optional.
Update wpt metadata to show the new passes.
Add one test as crashing since currently passing an @import rule to insertRule
leads to "Expected a stylesheet loader for @import"

Fixes #23025
2019-03-13 19:49:00 +00:00
Patrick Ngai
b17343a0ff Remove 'on' prefix from event handler macros 2019-03-14 00:55:21 +08:00
Emilio Cobos Álvarez
b42342a273 Update test expectations. 2019-03-13 15:08:59 +01:00
WPT Sync Bot
b3f94b4330 Update web-platform-tests to revision ea3cae9746c39e8192b91181044144c60d9388e8 2019-03-12 23:41:54 -04:00
bors-servo
f2ea73f360
Auto merge of #22802 - gterzian:only_run_tasks_for_fully_active_docs, r=nox
In BC event-loop, only run tasks related to fully-active documents

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #22792 (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22802)
<!-- Reviewable:end -->
2019-03-11 12:32:03 -04:00
WPT Sync Bot
ef0343b420 Update web-platform-tests to revision dc5ac330e65f29e767d7ce86004be251aad321f6 2019-03-09 22:39:59 -05:00
WPT Sync Bot
e9a369631b Update web-platform-tests to revision 8fde342d6e62e9820f2c19db634b99b78df796fa 2019-03-08 22:55:43 -05:00
WPT Sync Bot
4851e4e2b9 Update web-platform-tests to revision 8a14626934f5748a4ea6210847a02c0d8bbc8560 2019-03-07 23:09:32 -05:00
WPT Sync Bot
bf84a079f9 Update web-platform-tests to revision 78f764c05c229883e87ad135c7153051a66e2851 2019-03-06 22:39:43 -05:00
Gregory Terzian
ecfb9c639a in BC event-loop, only run tasks related to fully-active documents 2019-03-06 14:18:18 +08:00
Josh Matthews
bc2e1e2151 Do not store state when syncing WPT. 2019-03-04 13:45:56 -05:00
bors-servo
b1c2d58a32
Auto merge of #22961 - servo:jdm-patch-19, r=jdm
Force a pickling protocol that will accept certain awkward classes.

This cherry-picks the important part of https://github.com/web-platform-tests/wpt/pull/15611 to unbreak the nightly WPT sync.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22961)
<!-- Reviewable:end -->
2019-03-03 16:09:36 -05:00
Josh Matthews
6186cb465d Force a pickling protocol that will accept certain awkward classes. 2019-03-03 10:46:10 -05:00
bors-servo
4ccbd1e87e
Auto merge of #22622 - sreeise:audio_video_tracks, r=jdm
Added AudioTrack, AudioTrackList, VideoTrack, and VideoTrackList inte…

…rfaces

<!-- Please describe your changes on the following line: -->

Added AudioTrack, AudioTrackList, VideoTrack, VideoTrackList, and TrackEvent interfaces to support multiple media tracks.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22301  (GitHub issue number if applicable)

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22622)
<!-- Reviewable:end -->
2019-03-03 10:31:44 -05:00
sreeise
cac4aa56f7 Added AudioTrack, AudioTrackList, VideoTrack, VideoTrackList, and TrackEvent interfaces 2019-03-03 09:04:50 -05:00
Yuki Toyoda
c1e96b452d implement historical cancelBubble attribute for Event interface 2019-03-03 16:55:22 +09:00
bors-servo
4d8d54fc00
Auto merge of #22933 - pngai:implement-returnValue-attribute, r=jdm
Implement historical returnValue attribute for Event interface

<!-- Please describe your changes on the following line: -->
Implementation of `returnValue` attribute for Event interface.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #22881 (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22933)
<!-- Reviewable:end -->
2019-03-01 17:33:39 -05:00
Patrick Ngai
fcadff7bad Implement historical returnValue attribute for Event interface 2019-02-28 21:03:03 +08:00
bors-servo
2fb00d1d5a
Auto merge of #22941 - servo-wpt-sync:wpt_update_25-02-2019, r=jdm
Sync WPT with upstream (25-02-2019)

Automated downstream sync of changes from upstream as of 25-02-2019.
[no-wpt-sync]

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22941)
<!-- Reviewable:end -->
2019-02-27 09:29:14 -05:00