Commit graph

36788 commits

Author SHA1 Message Date
bors-servo
9c5bdd932e
Auto merge of #20423 - servo:bytes, r=emilio
Use ByteBuf for the canvas messages

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20423)
<!-- Reviewable:end -->
2018-03-26 14:49:16 -04:00
Anthony Ramine
ce81420bef Use ByteBuf for the canvas messages
The type Vec<u8> is super unefficient to work with in Serde if all you want
to represent is a simple blob.
2018-03-26 20:48:02 +02:00
Andrew Shu
3990946a63 TextDecoder: streaming decode, ignoreBOM
https://encoding.spec.whatwg.org/#dom-textdecoder-decode

https://encoding.spec.whatwg.org/#dom-textdecoder-ignorebom
2018-03-26 11:15:44 -07:00
bors-servo
31d7d3f1fb
Auto merge of #20439 - kwonoj:refactor-websocket-send, r=jdm
refactor(websocket): do not borrow sender anymore

<!-- Please describe your changes on the following line: -->
Relates to #20438.

Per instructed, this PR aim to remove borrwing `Websocket::sender`, by explicitly injecting instance via ctor.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #20438 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____
- These changes are locally passed compilation / passed unit test on macOS.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20439)
<!-- Reviewable:end -->
2018-03-26 12:05:24 -04:00
OJ Kwon
a1316fae0a
refactor(websocket): do not borrow sender anymore 2018-03-26 08:54:19 -07:00
bors-servo
0948adf370
Auto merge of #20432 - servo-wpt-sync:wpt_update_25-03-2018, r=jdm
Sync WPT with upstream (25-03-2018)

Automated downstream sync of changes from upstream as of 25-03-2018.
[no-wpt-sync]

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20432)
<!-- Reviewable:end -->
2018-03-26 08:24:51 -04:00
bors-servo
10813436b3
Auto merge of #20433 - nnethercote:bug-1411469, r=froydnj
Statically allocate static atoms.

<!-- Please describe your changes on the following line: -->

This is the Servo part of bug 1411469.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix Mozilla bug 1411469

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because tests are on the Gecko side.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

r? @emilio

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20433)
<!-- Reviewable:end -->
2018-03-26 04:08:14 -04:00
Nicholas Nethercote
77e3522507 Statically allocate static atoms. 2018-03-26 17:05:05 +11:00
WPT Sync Bot
395556b779 Update web-platform-tests to revision d04a8fc02b85bd32799691759c8c05ead07cd939 2018-03-25 23:24:11 -04:00
bors-servo
34f388229d
Auto merge of #20402 - Eijebong:lazy_static, r=emilio
Dedupe lazy_static

🎉 🎉 🎉

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20402)
<!-- Reviewable:end -->
2018-03-25 15:11:29 -04:00
bors-servo
36a41722b6
Auto merge of #20426 - christianpoveda:issue_20347, r=jdm
Websockets send typed arrays now

<!-- Please describe your changes on the following line: -->

r? jdm

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #20347 (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20426)
<!-- Reviewable:end -->
2018-03-25 14:07:15 -04:00
Andrew Shu
a631cb6b47 mach: android install/run: infer adb path from SDK dir 2018-03-25 10:40:26 -07:00
Christian Poveda
bff887c5a6 Websockets send typed arrays now 2018-03-25 10:01:33 -05:00
csmoe
054d65763d fix time measure 2018-03-25 09:14:30 +08:00
bors-servo
3ce3f39383
Auto merge of #20422 - anthgur:issue_20345, r=emilio
Use BufferSource in bluetooth APIs

<!-- Please describe your changes on the following line: -->

Updates `RemoveGATTDescriptor.webidl`, `BluetoothDataFilterInit`, and `BluetoothRemoteGATTCharacteristic` to use `BufferSource`.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #20345 (github issue number if applicable).
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20422)
<!-- Reviewable:end -->
2018-03-24 21:11:47 -04:00
Anthony Urena
ef0e93c9b1 Updates Bluetooth type to use BufferSource 2018-03-24 20:46:14 -04:00
Anthony Urena
5bf2e71407 Switches characteristic to use BufferSource 2018-03-24 20:46:13 -04:00
Anthony Urena
40235da2d3 Switches WriteValue to use BufferSource 2018-03-24 20:46:12 -04:00
bors-servo
b8279b376b
Auto merge of #20419 - emilio:mozjs-up, r=jdm
Update mozjs.

Peeks up https://github.com/servo/rust-mozjs/pull/408.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20419)
<!-- Reviewable:end -->
2018-03-24 19:05:47 -04:00
Emilio Cobos Álvarez
c2f8b0468a
Update mozjs. 2018-03-25 00:04:43 +01:00
bors-servo
2f94e0d2a8
Auto merge of #20413 - christianpoveda:issue_20344, r=jdm
TextDecoder's Decode now receives a BufferSource as input

<!-- Please describe your changes on the following line: -->

r? jdm

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #20344 (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20413)
<!-- Reviewable:end -->
2018-03-24 17:46:46 -04:00
Christian Poveda
2c47e7e1db TextDecoder's Decode now receives a BufferSource as input 2018-03-24 16:26:44 -05:00
bors-servo
782d4d4af6
Auto merge of #20414 - servo:webgl, r=emilio
Implement gl.getParameter(gl.ALIASED_POINT_SIZE_RANGE)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20414)
<!-- Reviewable:end -->
2018-03-24 14:58:38 -04:00
bors-servo
23b2f42a36
Auto merge of #20406 - kwonoj:feat-fetch-body-arraybuffer, r=jdm
feat(fetch): accept arraybuffer in consume_body

<!-- Please describe your changes on the following line: -->
Related to https://github.com/servo/servo/issues/20346.

I realized I am not sufficiently knowledgeable about codebases and have high confidence this PR is not ready to be accepted. Raising it as PR early to possibly ask some suggestions around codebases.

If this PR seems unrecoverable by code review, please feel freely close and unassign me from issue 🙏

This PR tries to implement #20346, updating `Body` idl and implements corresponding implementation in `body.rs` for `fetch`. Criteria for changes may includes

- does `run_array_buffer_data_algorithm` implementation is legit for allocating arraybuffer? (probably not)
- does `run_array_buffer_data_algorithm` implementation is acceptable for handling error, by naively returning `Error::JSFailed`?
- there are some number of wpt test started to PASS with this PR. Is this legit side effect, or something incorrect by current implementation?
- etcs, vice versa

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #20346 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____
- wpt test has changed in PR, need to be reviewed.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20406)
<!-- Reviewable:end -->
2018-03-24 13:46:20 -04:00
bors-servo
2d78964634
Auto merge of #20405 - christianpoveda:issue_20349, r=jdm
Add constructors for typed arrays in DOMMatrix and DOMMatrixReadOnly

<!-- Please describe your changes on the following line: -->

- DOMMatrix now have the functions: FromFloat32Array, FromFloat64Array.
- DOMMatrixReadOnly now have the functions: FromFloat32Array, FromFloat64Array, ToFloat32Array, ToFloat64Array.

r? @jdm

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #20349 (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20405)
<!-- Reviewable:end -->
2018-03-24 12:41:44 -04:00
OJ Kwon
80304a133f
test(wpt): update fetch test metadata 2018-03-24 08:57:33 -07:00
OJ Kwon
e6de213a13
refactor(consume_body): json stored in roottraceablebox 2018-03-24 08:57:32 -07:00
Anthony Ramine
d6ebbd3e17 Implement gl.getParameter(gl.ALIASED_POINT_SIZE_RANGE) 2018-03-24 16:36:19 +01:00
OJ Kwon
168f610821
feat(consume_body): implement consume_body accepts arraybuffer 2018-03-24 08:33:01 -07:00
bors-servo
2ab34d5969
Auto merge of #20411 - servo:webgl, r=emilio
Implement WebGLRenderingContextBase.getAttachedShaders

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20411)
<!-- Reviewable:end -->
2018-03-24 10:25:35 -04:00
Anthony Ramine
20a309f037 Implement missing WebGLShader checks
Methods compileShader and getShaderParameter should emit an error when
the shader has been deleted.
2018-03-24 15:24:54 +01:00
Anthony Ramine
a62bed82e4 Implement WebGLRenderingContextBase.getAttachedShaders 2018-03-24 13:58:07 +01:00
Anthony Ramine
2befe47384 Implement missing checks in WebGLRenderingContext::GetBufferParameter 2018-03-24 11:44:29 +01:00
OJ Kwon
c0b5eeef57
feat(webidl): expose arraybuffer overload in body idl 2018-03-23 23:12:21 -07:00
bors-servo
3525100a5f
Auto merge of #20409 - servo-wpt-sync:wpt_update_23-03-2018, r=jdm
Sync WPT with upstream (23-03-2018)

Automated downstream sync of changes from upstream as of 23-03-2018.
[no-wpt-sync]

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20409)
<!-- Reviewable:end -->
2018-03-24 01:11:12 -04:00
bors-servo
72f326b22b
Auto merge of #20400 - servo:webgl, r=emilio
Implement HTMLCanvasElement.toDataURL for WebGL canvas (fixes #19147)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20400)
<!-- Reviewable:end -->
2018-03-24 00:18:28 -04:00
bors-servo
5a432eaad3
Auto merge of #20404 - MaximilianDauner:issue_20392, r=jdm
GamepadButtonList::sync_from_vr should use more iterators #20392

<!-- Please describe your changes on the following line: -->
Used the zip function instead of iterating over both vectors with an indexing variable and using unwrap.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #20392(github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because it says in the issue description no need for tests
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20404)
<!-- Reviewable:end -->
2018-03-23 23:15:51 -04:00
WPT Sync Bot
2b35c55ac7 Update web-platform-tests to revision d04a8fc02b85bd32799691759c8c05ead07cd939 2018-03-23 22:48:00 -04:00
bors-servo
1fda5d6a5a
Auto merge of #20407 - dbaron:bug1448138, r=erahm
Rename Gecko string DataFlags::SHARED to REFCOUNTED

This is the servo piece of:

[Bug 1448138](https://bugzilla.mozilla.org/show_bug.cgi?id=1448138) - Rename string DataFlags::SHARED to REFCOUNTED to make it clearer to those reading the code.  r=erahm

This is a renaming in the internals of Gecko's string library that should also have a corresponding rename in the rust bindings.  This is already reviewed as part of the Gecko change, and the two pieces should be able to land separately.

<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20407)
<!-- Reviewable:end -->
2018-03-23 20:56:08 -04:00
L. David Baron
5a42c6cf72
Bug 1448138 - Rename string DataFlags::SHARED to REFCOUNTED to make it clearer to those reading the code. (Servo changes.) r=erahm 2018-03-23 13:40:51 -07:00
Christian Poveda
6d08027890 Add constructors for typed arrays in DOMMatrix and DOMMatrixReadOnly 2018-03-23 15:37:32 -05:00
bors-servo
e8fdc677f4
Auto merge of #20396 - Xanewok:webgl-typed-arrays, r=jdm
Replace `object` function arguments in WebGL with typed arrays

<!-- Please describe your changes on the following line: -->

Could use a https://github.com/servo/rust-mozjs/pull/402 in some places, as this should simplify a little bit and remove unnecessary `#[allow(unsafe_code)]` attributes.

I sort of hacked my way through for https://github.com/servo/servo/issues/20394 since I encountered this issue as well. I agree that the comment above makes me feel uneasy about this and feels like I'm missing something and this shouldn't be the way we eventually resolve the overloads with auto rootable types (talking about this: https://github.com/servo/servo/pull/20396/files#diff-60d01595cff328c165842fea9e4ccbc2R428).

r? @jdm

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #20342 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because if the bindings compile now, it works!

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20396)
<!-- Reviewable:end -->
2018-03-23 15:15:38 -04:00
MaximilianDauner
b42e54f13f Used the zip function to iterate over both vectors simultaneously instead of an
index variable and unwrapping the result.
2018-03-23 20:13:13 +01:00
Igor Matuszewski
80c6891f33 Use safe to_vec() for typed arrays in WebGL bindings 2018-03-23 19:37:25 +01:00
Igor Matuszewski
fbfcc762e1 Add codegen test for function overloads taking typed array args 2018-03-23 19:25:20 +01:00
Igor Matuszewski
2437a8472e Unify argument auto rooting in codegen 2018-03-23 19:25:20 +01:00
Igor Matuszewski
c42127b683 Fix indentation 2018-03-23 19:25:19 +01:00
Igor Matuszewski
cb85a95478 Fix sanity check in vertex attrib 2018-03-23 19:25:19 +01:00
Igor Matuszewski
daceeb4002 Appease test-tidy 2018-03-23 19:25:19 +01:00
Igor Matuszewski
20f21cb5f8 Adapt uniform[fv] and similar to accept typed array args 2018-03-23 19:25:19 +01:00