Anthony Ramine
4cf944eab8
Fix gl.isBuffer for buffers that are marked for deletion but still attached
2018-08-30 16:15:39 +02:00
Anthony Ramine
7b673de4d6
Always emit INVALID_OPERATION on null element buffers in drawElements
2018-08-30 16:15:39 +02:00
Anthony Ramine
0ba66f9f12
Fix the error for invalid arrays passed to gl.vertexAttrib*v()
2018-08-30 16:15:38 +02:00
Simon Sapin
1333b6ee45
Fix the build for NLL
...
Test with `RUSTFLAGS="-Zborrowck=mir -Ztwo-phase-borrows" cargo build`
https://internals.rust-lang.org/t/help-us-get-non-lexical-lifetimes-nll-over-the-finish-line/7807/7
2018-08-24 17:49:58 +02:00
Anthony Ramine
8b1c753c6c
Properly check limit in gl.activeTexture()
2018-08-23 15:15:33 +02:00
Josh Matthews
7c32ad7c3d
Revert "Fix the build for NLL"
...
This reverts commit d1733aa502
.
2018-08-07 20:24:55 -04:00
Simon Sapin
d1733aa502
Fix the build for NLL
...
Test with `RUSTFLAGS="-Zborrowck=mir -Ztwo-phase-borrows" cargo build`
https://internals.rust-lang.org/t/help-us-get-non-lexical-lifetimes-nll-over-the-finish-line/7807/7
2018-08-08 00:09:56 +02:00
danxionglei
ee916d5c63
fix(webgl): fix issue https://github.com/servo/servo/issues/21352
...
If we have a bounded framebuffer previously, which is not the one to delete.
we would not change the !binding, but we would change the GLSide with Command::BindFramebuffer(Default).
2018-08-07 22:21:07 +08:00
Anthony Ramine
04c81c5cc3
Merge code from Draw* and Draw*Instanced methods
...
This made me realise we weren't supporting OES_element_index_uint in the
ANGLE_instanced_arrays extension.
2018-08-02 22:54:39 +02:00
bors-servo
c5aaae7333
Auto merge of #21324 - servo:webgl, r=emilio
...
Properly set initial values for WebGL texture filters
<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21324 )
<!-- Reviewable:end -->
2018-08-02 12:08:12 -04:00
Anthony Ramine
f7124886bc
Use the DOM cache for gl.getTexParameter(gl.TEXTURE_*_FILTER)
...
Part of #20596 .
2018-08-02 18:06:58 +02:00
bors-servo
bde8a1e239
Auto merge of #21313 - jdm:glstuff, r=nox
...
Framebuffer and renderbuffer fixes
This commits address two separate panics that occur when running the framebuffer-object-attachment.html test. The test still panics due to another framebuffer completion status problem, so the overall test results don't demonstrate any improvement.
---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21252
- [x] There are tests for these changes
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21313 )
<!-- Reviewable:end -->
2018-08-02 09:26:35 -04:00
Anthony Ramine
fba6d801a1
Always use a WebGLVertexArrayObject to handle vertex attribs
...
This lets us clean up how buffers are reference-counted.
2018-08-02 12:46:19 +02:00
Josh Matthews
03eb7e4dd2
webgl: Emulate some renderbuffer formats in non-GLES.
2018-08-02 02:05:53 -04:00
Anthony Ramine
15d1215949
Properly check for context ownership of objects passed to gl.is*()
2018-07-31 11:12:45 +02:00
Anthony Ramine
76f23f7d78
Simplify gl.getShaderParameter() ( fixes #20562 )
...
The expectation change is due to the shader now using its DOM-side compile status.
It is actually a bug for the shader to think it actually compiled successfully,
but at least it does so consistently now.
2018-07-31 11:12:45 +02:00
Anthony Ramine
a0fc4c9832
Fix program and shader lifetime cycle
2018-07-31 11:12:40 +02:00
Anthony Ramine
5a9ad01145
Cache which capabilities are enabled in the context ( fixes #20534 )
...
This is needed for #20555 .
2018-07-25 19:58:02 +02:00
Anthony Ramine
3179ed59c5
Properly check for GL object ownership ( fixes #21133 )
2018-07-24 15:05:35 +02:00
Anthony Ramine
661e258b28
Store a reference to the WebGLRenderingContext in WebGLObject
2018-07-24 13:27:33 +02:00
Anthony Ramine
b64232d77b
Invalidate all WebGLUniformLocation values on program relink
2018-07-19 11:34:04 +02:00
Anthony Ramine
3e8c2d659a
Implement gl.getUniform()
2018-07-18 21:37:41 +02:00
Anthony Ramine
476640c3ab
Use active uniforms data to implement gl.uniform* checks
2018-07-17 01:26:44 +02:00
Anthony Ramine
cbac5d05be
Store active uniforms on the DOM side
2018-07-16 10:16:29 +02:00
Anthony Ramine
ef7d495838
Properly implement the checks for gl.renderbufferStorage ( fixes #20563 )
2018-07-09 15:27:51 +02:00
Anthony Ramine
4e6eea221a
Implement instanced WebGL drawing calls (part of #20791 )
2018-07-08 10:44:45 +02:00
Anthony Ramine
0aefffc5bf
Correctly implement the vertex buffer checks in drawArrays
...
This is half of #20599 . The check for drawElements is a bit more complex
to implement.
2018-07-08 10:44:45 +02:00
Anthony Ramine
f0ca100e87
Return an empty typed array from gl.getParameter(gl.COMPRESSED_TEXTURE_FORMATS)
2018-07-08 10:44:42 +02:00
Anthony Ramine
31774e9203
Implement gl.getParameter(gl.MAX_VIEWPORT_DIMS)
2018-07-08 10:14:10 +02:00
Anthony Ramine
0e6bec65bb
Return typed arrays from gl.getParameter ( fixes #20655 )
2018-07-08 10:11:44 +02:00
Anthony Ramine
6996d1ce36
Fix gl.getShaderSource and gl.getShaderInfoLog
...
It only returns null if there was an error, and the only error isn't
implemented yet.
2018-07-08 10:11:44 +02:00
Anthony Ramine
0e93f06d8d
Pass more GL limits to the ANGLE shader compiler
2018-07-08 10:11:44 +02:00
Anthony Ramine
15389586d9
Make gl.useProgram(null) do the right thing
2018-07-05 14:20:47 +02:00
Anthony Ramine
fc593c68c5
Store active attribs in DOM and optimise active attributes APIs
2018-07-05 14:20:47 +02:00
Anthony Ramine
0e2e834d18
Fix gl.linkProgram() signature
2018-07-05 14:20:47 +02:00
Anthony Ramine
cde6023ed4
Store vertex attribs data in DOM and optimise GetVertexAttrib
2018-07-05 14:20:47 +02:00
Anthony Ramine
0814bd6699
Rename VertexAttribs::set_from to VertexAttribs::clone_from
2018-07-05 14:20:47 +02:00
Anthony Ramine
0018e5e6ba
Refactor some vertex attrib checks
2018-07-05 14:20:47 +02:00
Anthony Ramine
f108a3e797
Introduce VertexAttribData
2018-07-05 14:20:47 +02:00
Anthony Ramine
5d43f1c9bd
Rename BoundAttribBuffers to VertexAttribs and make it store a slice
2018-07-05 14:20:44 +02:00
Anthony Ramine
02b8766e75
Implement EXT_blend_minmax
2018-06-22 14:10:56 +02:00
bors-servo
8f84f893a7
Auto merge of #21072 - servo:webgl, r=emilio
...
Implement checks for vertex attribs enabled as arrays without a bound buffer
<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21072 )
<!-- Reviewable:end -->
2018-06-20 10:19:38 -04:00
Anthony Ramine
fc3dd7cefc
Implement checks for vertex attribs enabled as arrays without a bound buffer
2018-06-20 15:59:06 +02:00
bors-servo
1f562af418
Auto merge of #20699 - simartin:issue_20593, r=nox
...
Issue #20593 : Implement proper checks in WebGLRenderingContext's getFramebufferAttachmentParameter().
Add missing input checks.
---
- [X] `./mach build -d` does not report any errors
- [X] `./mach build-geckolib` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #20593
- [X] There are tests for these changes
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20699 )
<!-- Reviewable:end -->
2018-06-18 12:01:39 -04:00
Anthony Ramine
f1288cc6e0
Implement EXT_texture_filter_anisotropic
2018-06-06 12:24:47 +02:00
bors-servo
022daccbe1
Auto merge of #20884 - jdm:more-limits, r=avadacatavra
...
Don't forward GL parameter gets for constant limits.
This avoids IPC traffic for unchanging constants that are determined when the GL context is created. These changes require https://github.com/emilio/rust-offscreen-rendering-context/pull/123 .
---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #20876 .
- [x] There are tests for these changes
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20884 )
<!-- Reviewable:end -->
2018-05-31 15:03:43 -04:00
Josh Matthews
76c29f8bd0
Don't forward GL parameter gets for constant limits.
2018-05-31 14:24:18 -04:00
Simon Martin
08b193c922
Issue #20593 : Implement proper checks in WebGLRenderingContext's getFramebufferAttachmentParameter().
2018-05-31 20:09:11 +02:00
Josh Matthews
b1202cfa9f
Don't panic when tearing down a WebGL context and the thead is unreachable.
...
This avoids some cascading double-panics when there are errors in the WebGL rendering thread.
2018-05-29 15:26:39 -04:00
Anthony Ramine
3e510ec008
Implement most of the unsupported parameters in gl.getParameter()
...
Fixes #20536 .
Fixes #20537 .
Fixes #20538 .
Fixes #20544 .
Fixes #20545 .
Fixes #20546 .
Fixes #20548 .
Fixes #20549 .
Fixes #20551 .
2018-05-24 12:32:15 +02:00