jmr0
df49cf2b13
adding tidy rule to warn against use of &String and refactoring instances of &String in codebase
2015-11-25 21:49:12 -05:00
bors-servo
8efc954531
Auto merge of #8671 - paulrouget:iframe-hit-test, r=pcwalton
...
Fix clip rect for iframes in hit testing code
Fixes #8080 r? @mrobinson
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8671 )
<!-- Reviewable:end -->
2015-11-26 00:39:36 +05:30
bors-servo
188fa9378c
Auto merge of #8667 - asajeffrey:update-string-cache, r=SimonSapin
...
Update string cache
Updated string_cache to 0.2, and updated the dependencies that depend on string_cache.
Removed references to string_cache_plugin.
Import atom! and ns! from string_cache.
Replaced ns!("") by ns!().
Replaced ns!(XML) and co by ns!(xml) and co.
Replaced Atom::from_slice by Atom::from.
Replaced atom.as_slice() by &*atom.
r? @SimonSapin
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8667 )
<!-- Reviewable:end -->
2015-11-26 00:10:39 +05:30
Alan Jeffrey
3dec6edd10
Update string_cache to 0.2.
...
Updated string_cache, html5ever, xml5ever and selectors in Cargo.toml files and Cargo.lock.
Removed references to string_cache_plugin.
Import atom! and ns! from string_cache.
Replaced ns!("") by ns!().
Replaced ns!(XML) and co by ns!(xml) and co.
Replaced atom!(foo) by atom!("foo").
Replaced Atom::from_slice by Atom::from.
Replaced atom.as_slice() by &*atom.
2015-11-25 10:13:21 -06:00
bors-servo
e7b1924948
Auto merge of #6826 - dzbarsky:deletecontents, r=jdm
...
Implement Range#deleteContents
Sadly calling ExtractContents and discarding the result doesn't do the right thing.
It may be worth having a CutContents method that takes an `Option<DocumentFragment>` and switch the behavior based on it, to share the code between DeleteContents and ExtractContents, like what Gecko does. Maybe a followup.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6826 )
<!-- Reviewable:end -->
2015-11-25 19:55:02 +05:30
bors-servo
6684804846
Auto merge of #8648 - Ms2ger:test-ref, r=frewsxcv
...
Use wptrunner for some old-style reftests.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8648 )
<!-- Reviewable:end -->
2015-11-25 15:30:12 +05:30
David Zbarsky
25b7c9523c
Implement Range#deleteContents
2015-11-25 00:02:25 -08:00
Matt Brubeck
7b799497d1
Convert from client to page coords in script
2015-11-25 07:16:09 +01:00
Matt Brubeck
a61989e82b
Fix clip rect for iframes in hit testing code
...
Fixes #8080
2015-11-25 05:28:47 +01:00
bors-servo
4f625d3ab6
Auto merge of #8670 - pcwalton:animation-expiration, r=glennw
...
Write animated values into the `ComputedValues` structures when animations complete or are interrupted.
This adds a new pair of reader-writer locks. I measured the performance
of style recalculation on Wikipedia and the overhead of the locks was
not measurable.
Closes #7816 .
cc @paulrouget
r? @glennw
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8670 )
<!-- Reviewable:end -->
2015-11-25 08:00:14 +05:30
bors-servo
13a96fcaf7
Auto merge of #8660 - pcwalton:ipc-channel-errors, r=larsbergstrom
...
Update `ipc-channel` to pick up the improved error reporting.
Intended to help diagnose intermittent failures.
r? @jdm or @larsbergstrom (or whoever)
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8660 )
<!-- Reviewable:end -->
2015-11-25 07:31:15 +05:30
Patrick Walton
e881f0feeb
Write animated values into the ComputedValues
structures when
...
animations complete or are interrupted.
This adds a new pair of reader-writer locks. I measured the performance
of style recalculation on Wikipedia and the overhead of the locks was
not measurable.
Closes #7816 .
2015-11-24 19:50:52 -06:00
bors-servo
6f35b867c9
Auto merge of #8653 - servo:no-regex-macros, r=Ms2ger
...
Remove dependency on regex_macros
This reduces the amount of code using unstable features that we depend on.
The hand-written IP address parser is probably just as fast.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8653 )
<!-- Reviewable:end -->
2015-11-25 03:05:10 +05:30
Simon Sapin
45ec900745
Remove dependency on regex_macros
...
This reduces the amount of code using unstable features that we depend on.
The hand-written IP address parser is probably just as fast.
2015-11-24 22:07:14 +01:00
Simon Sapin
0dfdc94cb2
Remove IPv6 subnet parsing in host files like ::1/64
...
The host replacement code doesn’t do anything useful with it.
(It only compares strings.)
2015-11-24 22:07:06 +01:00
bors-servo
ed6a3f5022
Auto merge of #8609 - KiChjang:file-loader-headers, r=KiChjang
...
Add content_type to metadata in file_loader
Fixes #4212 .
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8609 )
<!-- Reviewable:end -->
2015-11-25 01:49:26 +05:30
Keith Yeung
af705a6faf
Add content_type to metadata in file_loader
2015-11-24 11:52:35 -08:00
bors-servo
e31478cc3d
Auto merge of #8665 - Ms2ger:8647-enable, r=SimonSapin
...
Enable background-root-102 and background-root-103.
Fixes #8647 .
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8665 )
<!-- Reviewable:end -->
2015-11-24 20:14:15 +05:30
Ms2ger
473b12683d
Enable background-root-102 and background-root-103.
2015-11-24 15:34:54 +01:00
bors-servo
716cc8c8f5
Auto merge of #8652 - Ms2ger:update-tests, r=Ms2ger
...
Update tests.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8652 )
<!-- Reviewable:end -->
2015-11-24 18:40:35 +05:30
Ms2ger
3a79c9b53f
Update web-platform-tests to revision ee40b886c701ffa25a673240cabdedd59ee3ace4
2015-11-24 13:35:04 +01:00
Ms2ger
a00f2d6310
Update CSS tests to revision e102a993c37a2e0ebd549bc7d5548b006458ab34
2015-11-24 12:27:39 +01:00
bors-servo
037cac7353
Auto merge of #8651 - eefriedman:metadata-cleanup, r=jdm
...
Remove a couple dead ini files.
The directories in question no longer exist.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8651 )
<!-- Reviewable:end -->
2015-11-24 12:13:50 +05:30
Eli Friedman
930b4bb7b7
Remove a couple of dead .ini files.
...
The directories in question no longer exist.
2015-11-23 19:32:36 -08:00
bors-servo
a2330f4943
Auto merge of #8632 - mrobinson:flow-tree-dump, r=pcwalton
...
Improve readability of flow tree dump
Use the PrintTree utility to improve the readability of flow tree
dumps. Blocks and fragments are now split over two dump levels, because
otherwise they are impenetrable. Also start printing the restyle damage of
fragments.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8632 )
<!-- Reviewable:end -->
2015-11-24 07:49:07 +05:30
bors-servo
a8ba880e17
Auto merge of #8659 - frewsxcv:fix-travis, r=eefriedman
...
Fix travis by making manifest_changed.sh pass
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8659 )
<!-- Reviewable:end -->
2015-11-24 06:30:13 +05:30
Patrick Walton
2843000810
Update ipc-channel
to pick up the improved error reporting.
...
Intended to help diagnose intermittent failures.
2015-11-23 16:38:39 -08:00
bors-servo
0905088e83
Auto merge of #8655 - jdm:domain, r=jdm
...
Implement document.domain getter
Rebased from #6840 + test fixes.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8655 )
<!-- Reviewable:end -->
2015-11-24 06:01:13 +05:30
Martin Robinson
8dd664a438
Improve readability of flow tree dump
...
Use the PrintTree utility to improve the readability of flow tree
dumps. Blocks and fragments are now split over two dump levels, because
otherwise they are impenetrable. Also start printing the restyle damage of
fragments.
2015-11-23 15:17:32 -08:00
Corey Farwell
768226230d
Fix travis by making manifest_changed.sh pass
2015-11-23 17:39:27 -05:00
bors-servo
711f516d80
Auto merge of #8639 - bholley:generalize_wrappers2, r=pcwalton
...
Use associated types for layout wrapper trait, and generalized ThreadSafeLayoutFoo
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8639 )
<!-- Reviewable:end -->
2015-11-24 04:01:32 +05:30
Tom Schuster
0e0e051f3f
Implement document.domain getter
2015-11-23 15:45:02 -05:00
bors-servo
6449cd09eb
Auto merge of #8542 - KiChjang:style-whitespace-methods, r=SimonSapin
...
Extend whitespace::T with additional helper methods
Fixes #8128 .
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8542 )
<!-- Reviewable:end -->
2015-11-23 23:39:07 +05:30
bors-servo
6ef6d664aa
Auto merge of #8656 - servo:canvas-currentcolor, r=SimonSapin
...
Implement currentColor for Canvas colors
Fixes #7120 .
This is #7120 by @dzbarsky, with one tidy error fixed.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8656 )
<!-- Reviewable:end -->
2015-11-23 23:09:57 +05:30
Simon Sapin
18ecf54d10
Tidy.
2015-11-23 16:16:35 +01:00
bors-servo
e3eee5a41b
Auto merge of #8597 - r0e:testing, r=Manishearth
...
Fix for #8593 'loop..match' should be 'while let'
As per #8593 .
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8597 )
<!-- Reviewable:end -->
2015-11-23 08:18:20 +05:30
bors-servo
f6591a3d9e
Auto merge of #8649 - Wafflespeanut:I_TRIED, r=SimonSapin
...
Moving Servo's cry message!
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8649 )
<!-- Reviewable:end -->
2015-11-23 03:21:57 +05:30
Ravi Shankar
eb85d58ee4
Moving Servo's cry message!
2015-11-23 02:52:38 +05:30
Ms2ger
576c4f7e4b
Move simple_inline_default.html to wpt reftests.
2015-11-22 15:39:10 +01:00
Ms2ger
7254a25fc5
Move simple.html to wpt reftests.
2015-11-22 15:34:52 +01:00
Ms2ger
2450694eee
Move positioning_margin.html to wpt reftests.
2015-11-22 15:24:28 +01:00
Ms2ger
e228e29289
Move overflow.html to wpt reftests.
2015-11-22 15:22:00 +01:00
Ms2ger
ea118c56d6
Move multiple_external.html to wpt reftests.
2015-11-22 15:16:29 +01:00
Ms2ger
4cb6a87992
Move hide_layers1.html and hide_layers2.html to wpt reftests.
2015-11-22 15:14:37 +01:00
Ms2ger
4466fc3537
Move hide_and_show.html to wpt reftests.
2015-11-22 15:12:08 +01:00
Ms2ger
19c4991c55
Move hide_after_load.html to wpt reftests.
2015-11-22 15:10:15 +01:00
Ms2ger
833cd524e0
Move bg_color.html to wpt reftests.
2015-11-22 15:08:05 +01:00
bors-servo
6ab205a97e
Auto merge of #8644 - fitzgen:remove-unused-imports-in-scropt-dom-node, r=eefriedman
...
Remove two unused imports from components/script/dom/node.rs
Fixes these two compiler warnings:
```
Compiling servo v0.0.1 (file:///Users/fitzgen/src/servo/components/servo)
/Users/fitzgen/src/servo/components/script/dom/node.rs:26:65: 26:78 warning: unused import, #[warn(unused_imports)] on by default
/Users/fitzgen/src/servo/components/script/dom/node.rs:26 use dom::bindings::inheritance::{Castable, CharacterDataTypeId, ElementTypeId};
^~~~~~~~~~~~~
/Users/fitzgen/src/servo/components/script/dom/node.rs:27:53: 27:70 warning: unused import, #[warn(unused_imports)] on by default
/Users/fitzgen/src/servo/components/script/dom/node.rs:27 use dom::bindings::inheritance::{EventTargetTypeId, HTMLElementTypeId, NodeTypeId};
^~~~~~~~~~~~~~~~~
```
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8644 )
<!-- Reviewable:end -->
2015-11-22 17:06:48 +05:30
bors-servo
3199eace98
Auto merge of #8642 - jmr0:master, r=jdm
...
making internal pub enums, functions, and structs private
Refactoring to fix #8620
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8642 )
<!-- Reviewable:end -->
2015-11-22 16:15:36 +05:30
Nick Fitzgerald
bd857cb1cb
Remove two unused imports from components/script/dom/node.rs
...
Fixes these two compiler warnings:
```
Compiling servo v0.0.1 (file:///Users/fitzgen/src/servo/components/servo)
/Users/fitzgen/src/servo/components/script/dom/node.rs:26:65: 26:78 warning: unused import, #[warn(unused_imports)] on by default
/Users/fitzgen/src/servo/components/script/dom/node.rs:26 use dom::bindings::inheritance::{Castable, CharacterDataTypeId, ElementTypeId};
^~~~~~~~~~~~~
/Users/fitzgen/src/servo/components/script/dom/node.rs:27:53: 27:70 warning: unused import, #[warn(unused_imports)] on by default
/Users/fitzgen/src/servo/components/script/dom/node.rs:27 use dom::bindings::inheritance::{EventTargetTypeId, HTMLElementTypeId, NodeTypeId};
^~~~~~~~~~~~~~~~~
```
2015-11-21 21:45:55 -08:00