Commit graph

39684 commits

Author SHA1 Message Date
bors-servo
e10cf7adad
Auto merge of #25222 - pshaughn:node_isconnected, r=jdm
adding .isConnected DOM attribute

<!-- Please describe your changes on the following line: -->
is_connected already existed for this concept and just needed to be hooked up to an IDL attribute.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #25126

<!-- Either: -->
- [X] There are tests for these changes OR

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2019-12-11 15:04:45 -05:00
bors-servo
fc97a53a94
Auto merge of #25240 - pshaughn:unspecial_mouseover, r=SimonSapin
Took out the special mouseover cancel case

<!-- Please describe your changes on the following line: -->
eventtarget.rs was checking the event type to see if it was a mouseover; now it doesn't. Other special-case events like error and beforeunload go down other code paths entirely, so this one has no special cases left.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #25190

<!-- Either: -->
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2019-12-11 10:12:52 -05:00
Patrick Shaughnessy
0231a0a712 adding .isConnected DOM attribute 2019-12-11 10:08:05 -05:00
Simon Sapin
e501eaaa5b
Add FIXME to the new comment asking wether code below it is right 2019-12-11 08:59:05 +01:00
bors-servo
aa268e154f
Auto merge of #25228 - servo-wpt-sync:wpt_update_10-12-2019, r=jdm
Sync WPT with upstream (10-12-2019)

Automated downstream sync of changes from upstream as of 10-12-2019.
[no-wpt-sync]
r? @servo-wpt-sync
2019-12-11 00:17:09 -05:00
Josh Matthews
cf7fb78d65
Remove intermittent failure. 2019-12-10 23:08:21 -05:00
bors-servo
b98a8fc576
Auto merge of #25230 - servo:sequential, r=nox
Fix `--layout-threads 1` in layout 2020
2019-12-10 23:07:04 -05:00
bors-servo
ded8643988
Auto merge of #25227 - gterzian:remove_unnecessary_thread_in_filereader, r=jdm
Remove unnecessary thread in filereader, add stream TODO

<!-- Please describe your changes on the following line: -->

I think there are no benefits to queuing the various `FileReadingTask` from a thread, and reading the actual blob bytes are still done on the main-thread. We could try to move the reading off the main-thread(but note the `Blob` is not something you would want to move to another thread "as-is" since it's a `DomObject`), and I think we should just aim for implementing streams and follow the spec instead.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2019-12-10 23:06:03 -05:00
Patrick Shaughnessy
f35a870f55 Took out the special mouseover cancel case 2019-12-10 21:50:47 -05:00
bors-servo
e900c22105
Auto merge of #24716 - servo:jdm-patch-36, r=nox
Install gperf for linux CI builds.

Fixes #24715.
2019-12-10 20:00:50 -05:00
bors-servo
b19b778fef
Auto merge of #25220 - pshaughn:patch25151, r=jdm
Workarounds for form-submission-0 tests with about:blank onloads

<!-- Please describe your changes on the following line: -->
Following the model of 3b9ab34600 these changes replace some naive onload events with equivalents that do nothing if they see an about:blank load event. Two test cases now pass, and one failing test case is now failing for a less ambiguous reason (#25154)

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #25151 and fix #25152.

<!-- Either: -->
- [X] These changes do not require tests because these are fixes to tests only, not code changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2019-12-10 16:35:14 -05:00
bors-servo
8d4cedb911
Auto merge of #24575 - marmeladema:issue-23607/compat, r=SimonSapin
Enable some mach commands to be run with python3

This change finally enable the following commands to be run with python3:
* `build`
* `test-unit`
* `package`

As previously explained, `test-tidy` will require more work in the wpt repository directly. Maybe `test-tidy --no-wpt` is achievable relatively quickly though.

For possible remaining bits that might need to be worked on, see https://github.com/servo/servo/issues/23607

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2019-12-10 16:34:10 -05:00
Patrick Shaughnessy
15e5aef631 Workarounds for tests with about:blank onloads (rebased) 2019-12-10 15:52:53 -05:00
bors-servo
47716cc1aa
Auto merge of #25219 - jdm:angle-uwp-up, r=paulrouget
Update ANGLE for UWP fix.

This fixes a WACK error where the ANGLE DLLs do not contain the App Container feature.
2019-12-10 14:47:32 -05:00
Simon Sapin
c895e3d236 Disable use of rayon with --layout-threads 1 instead of panicking 2019-12-10 18:41:24 +01:00
Simon Sapin
aade603025 Support STYLO_THREADS=1 2019-12-10 18:41:14 +01:00
Simon Sapin
d717382c0c Disable in Layout 2020 an assertion that does not apply there 2019-12-10 18:41:14 +01:00
marmeladema
02c55e2eca Use is_linux to check for current platform instead of relying on sys.platform 2019-12-10 16:11:03 +00:00
marmeladema
17233f2dd2 Write subprocess stdout/stderr logs to raw stdout buffer when using Python3 2019-12-10 16:11:02 +00:00
Simon Sapin
63d5d8a4b6 .gitignore all virtualenvs 2019-12-10 16:11:02 +00:00
Simon Sapin
2bacf69d15 Taskcluster: install packages for Python 3 in Docker tasks 2019-12-10 16:11:02 +00:00
marmeladema
64e9c0ee23 taskcluster: change some mach commands to use python3 under linux 2019-12-10 16:11:02 +00:00
marmeladema
176e63284e Replace usage of basestring by six.string_types for Python3 compatibility 2019-12-10 16:11:02 +00:00
marmeladema
267eaad4eb Properly open file as 'wb' in archive_deterministically 2019-12-10 16:10:58 +00:00
bors-servo
6cf618ae9f
Auto merge of #25207 - servo:replaced, r=nox
min/max-width/height, replaced elements
2019-12-10 10:49:17 -05:00
bors-servo
f4acea3dfa
Auto merge of #25163 - servo:treeherder, r=nox
Make tasks easier to find in Treeherder
2019-12-10 10:04:46 -05:00
Simon Sapin
53ce714005 Fix a “Accessing content size that was not requested” panic
Percentage `width` are treated as `auto` for the purpose of
min/max-content computation, so they also need to be considered
when testing “wether width is auto”
2019-12-10 15:11:53 +01:00
Simon Sapin
a17db217a1 Struct with named fields over large tuple 2019-12-10 15:11:53 +01:00
Simon Sapin
be8df1d114 Move solve_axis function to module level 2019-12-10 15:11:53 +01:00
Simon Sapin
29067225a4 Conditionsals over closures 2019-12-10 15:11:53 +01:00
Simon Sapin
c07c980501 Delayed initialization over mutation 2019-12-10 15:11:53 +01:00
Simon Sapin
1fa20e93d0 Implement replaced abspos 2019-12-10 15:11:53 +01:00
Simon Sapin
1fcdde99cb Move two AbsoluteBoxOffsets fields into a Vec2 2019-12-10 15:11:53 +01:00
Simon Sapin
f09c14aa6b impl From<&'_ DefiniteContainingBlock> for ContainingBlock 2019-12-10 15:11:53 +01:00
Simon Sapin
14ddf39215 Rename ReplacedContent::used_size to used_size_as_if_inline_element 2019-12-10 15:11:53 +01:00
Simon Sapin
e86222d6bb Remove AbsoluteBoxOffsets’s type parameter 2019-12-10 15:11:53 +01:00
Simon Sapin
f43dc3afcb Remove inline/block_size from AbsolutelyPositionedFragment 2019-12-10 15:11:53 +01:00
Simon Sapin
80b2b5fb5e Fix min/max-content of replaced boxes 2019-12-10 15:11:53 +01:00
Simon Sapin
8996be3c5e Don’t assume replaced elements have an intrinsic size 2019-12-10 15:11:53 +01:00
bors-servo
4d5bf653f7
Auto merge of #25217 - pshaughn:fix25150, r=jdm
hidden field named _charset_ now appears in FormData as UTF-8

<!-- Please describe your changes on the following line: -->
HTMLInputElement now has special case logic for putting a hidden field named `_charset_` in an entry set. To support this, the encoding used when constructing a form dataset is now being passed further down the callchain than it was before.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #25150

<!-- Either: -->
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2019-12-10 07:50:27 -05:00
Simon Sapin
b73eb49a58 Add sizing of inline replaced boxes 2019-12-10 12:36:43 +01:00
Simon Sapin
c40583b644 Move replaced box used size computation to a method of ReplacedContents 2019-12-10 12:36:43 +01:00
Simon Sapin
bf96988260 Add min/max-width/height support for inline-block
(… and other non-replaced atomic inline-level boxes.)
2019-12-10 12:36:43 +01:00
Simon Sapin
999dd72895 Account for min/max-width in outer intrinsic sizing 2019-12-10 12:36:43 +01:00
Simon Sapin
ce7e84be72 Replace percent_resolved_* functions with methods 2019-12-10 12:36:43 +01:00
Simon Sapin
a2c2b294d5 Move clamp_* functions to methods of Length 2019-12-10 12:36:43 +01:00
Simon Sapin
648de3984a Avoid spaces in treeherder tags
The are visually separated by each other by only a space
2019-12-10 12:33:48 +01:00
Simon Sapin
9c93ca6580 Distinguish Layout 2020 build task in Treeherder 2019-12-10 12:33:40 +01:00
WPT Sync Bot
20d165ac2c Update web-platform-tests to revision fa41b43ac93bc2fdc2427a4378dc3754d483cdda 2019-12-10 11:06:32 +00:00
bors-servo
8a7de32d5b
Auto merge of #25218 - asajeffrey:gstplugin-name-unclash, r=jdm
Rename the ServoSrc type to ServoGstSrc to avoid a name clash

<!-- Please describe your changes on the following line: -->

There's a name clash with the type name `ServoSrc`.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #25051
- [x] These changes do not require tests because

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2019-12-10 04:26:57 -05:00