Commit graph

15313 commits

Author SHA1 Message Date
Lars Bergstrom
e92d130f32 Windows instructions 2016-01-25 14:34:50 -06:00
bors-servo
4755cc5c62 Auto merge of #9405 - pcwalton:absolute-positioning-overflow, r=glennw
layout: Remove some bogus code that tried to handle absolutely-positioned flows separately when storing overflow.

This code dates back to the time when absolutely positioned flows were
ignored by all of their ancestors up to the containing block. This
hasn't been true for at least a year.

Closes #9306.
Closes #9309.
Is a partial fix for #9308.

r? @glennw

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9405)
<!-- Reviewable:end -->
2016-01-26 00:20:26 +05:30
Patrick Walton
9c7b9fa32d layout: Remove some bogus code that tried to handle
absolutely-positioned flows separately when storing overflow.

This code dates back to the time when absolutely positioned flows were
ignored by all of their ancestors up to the containing block. This
hasn't been true for at least a year.

Closes #9306.
Closes #9309.
Is a partial fix for #9308.
2016-01-25 10:52:07 -08:00
bors-servo
842ec7c415 Auto merge of #9418 - paulrouget:iframeCrash, r=jdm
Check if root page exist before handling DOM events

Fix #9417

For the test, I'm not sure how to simulate a mouse event or a key event in a way that it would be forwarded to the iframe.

Any idea?

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9418)
<!-- Reviewable:end -->
2016-01-25 21:06:22 +05:30
Paul Rouget
a2c931e4df Check if root page exist before handling DOM events 2016-01-25 16:31:59 +01:00
bors-servo
e74021baaa Auto merge of #9400 - jmr0:websocket, r=nox
Fixing websocket subprotocol header validation

This takes care of https://github.com/servo/servo/issues/9034

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9400)
<!-- Reviewable:end -->
2016-01-25 17:01:39 +05:30
jmr0
3846cf52f2 fix websocket header validation, ensure it meets token requirements, add
testing
2016-01-24 18:31:21 -05:00
bors-servo
e93a460db4 Auto merge of #9413 - nxnfufunezn:issue-9412, r=nox
Move ConstantSpec, NonNullJSNative and define_constants from utils to interface

Fixes #9412
r? @nox

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9413)
<!-- Reviewable:end -->
2016-01-24 20:48:57 +05:30
nxnfufunezn
e54929b4d7 Move ConstantSpec, NonNullJSNative and define_constants from utils to interface 2016-01-24 20:37:30 +05:30
bors-servo
525e77f64f Auto merge of #9385 - larsbergstrom:win32, r=frewsxcv,pcwalton,jdm,ecoal95
Win32 support

r? @frewsxcv for python stuff
r? @pcwalton for the "remove usage of Gaol" stuff for Win32
r? anybody else for misc cargo.lock updates, etc.

This replaces #7878.

This works best with https://github.com/servo/mozjs/pull/71, too, to enable static linking, but can be run without (via some PATH hackery).

The instructions are here, and will be added to a .md file in the repo once the mozjs changes also land:
https://hackpad.com/Servo-on-Windows-C1LPcI2bP25

I'd like to get these changes landed because I've been rebasing them for months, they're otherwise quite stable, and don't affect our other platforms and targets.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9385)
<!-- Reviewable:end -->
2016-01-23 07:27:27 +05:30
Lars Bergstrom
e9d9d1d9e9 Cargo.lock updates 2016-01-22 19:28:46 -06:00
Lars Bergstrom
c65598907e Add Windows support for handle_event 2016-01-22 19:28:39 -06:00
Lars Bergstrom
721693c43e Remove usage of Gaol in the Windows configuration, since sandboxing is not supported there yet. 2016-01-22 19:28:38 -06:00
Jason Williams
13d98f153a adding check for windows then using Scripts instead of bin 2016-01-22 19:27:29 -06:00
bors-servo
a914727541 Auto merge of #9404 - shssoichiro:htmlformelementlength, r=nox
Update HTMLFormElement.length to be of type unsigned long

Fixes #9402

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9404)
<!-- Reviewable:end -->
2016-01-22 22:53:53 +05:30
Joshua Holmer
75d258f866 Update HTMLFormElement.length to be of type unsigned long
Fixes #9402
2016-01-22 12:09:12 -05:00
bors-servo
1c6fb0f04e Auto merge of #9367 - Chandler:url_origin, r=jdm
Add origin to Location and Url API.

The origin field is part of location and url spec but hasn't been implemented in servo yet.
https://html.spec.whatwg.org/multipage/browsers.html#dom-location-origin
https://url.spec.whatwg.org/#dom-url-origin

All of the logic to calculate the url origin exists in https://github.com/servo/rust-url

This review threads through rust-url origin implementation into the servo location and url API.

This fixes one websockets test:
servo/tests/wpt/web-platform-tests/websockets/opening-handshake/003.html

testing done:
./mach test-wpt tests/wpt/web-platform-tests/websockets/

I'm brand new to rust so feedback is appreciated, thanks!

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9367)
<!-- Reviewable:end -->
2016-01-22 04:25:49 +05:30
bors-servo
0dd024e492 Auto merge of #9399 - nxnfufunezn:build_time-9398, r=jdm
Fixes #9398 Integrate BuildTimeTrend into TravisCI

r? @jdm

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9399)
<!-- Reviewable:end -->
2016-01-22 02:48:01 +05:30
nxnfufunezn
5b699a5fff Fixes #9398 Integrate BuildTimeTrend into TravisCI 2016-01-21 15:34:13 -05:00
Chandler Abraham
1ee9ccba21 add origin to location and url api 2016-01-21 11:06:41 -08:00
bors-servo
52da517a14 Auto merge of #9393 - Ms2ger:renumber-prepare, r=jdm
Update HTMLScriptElement::prepare to match the changed specification.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9393)
<!-- Reviewable:end -->
2016-01-21 23:31:18 +05:30
bors-servo
1ba1fb0b7f Auto merge of #9380 - servo:cssparserup, r=SimonSapin
Update cssparser.

https://github.com/servo/rust-cssparser/pull/91

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9380)
<!-- Reviewable:end -->
2016-01-21 22:45:51 +05:30
Simon Sapin
6fd46b5e6a Update cssparser.
https://github.com/servo/rust-cssparser/pull/91
2016-01-21 17:58:03 +01:00
bors-servo
262974cb11 Auto merge of #9396 - psdh:fixwebidltests, r=Ms2ger
update tests for WebIDL.py from mozilla-central

Fixes #9388

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9396)
<!-- Reviewable:end -->
2016-01-21 22:00:22 +05:30
Prabhjyot Singh Sodhi
da40818f25 update to latest tests 2016-01-21 21:53:47 +05:30
bors-servo
41892d4c93 Auto merge of #9394 - servo:wpt-lint, r=jdm
Include the wpt lint in test-tidy --faster.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9394)
<!-- Reviewable:end -->
2016-01-21 19:51:04 +05:30
Ms2ger
aa1ae9b355 Include the wpt lint in test-tidy --faster. 2016-01-21 14:34:03 +01:00
bors-servo
a86035dc6d Auto merge of #9386 - jgraham:update-wpt, r=Ms2ger
Update web-platform-tests to revision 1ac278f94d0e86b88fc9f1eeb31ed2d2ef35b472

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9386)
<!-- Reviewable:end -->
2016-01-21 17:56:18 +05:30
James Graham
4864a52312 Update web-platform-tests expected data to revision 0d9238c8062f05a55898a0cb60dc0c353794d87a 2016-01-21 11:50:33 +00:00
Ms2ger
678cb9da84 Update HTMLScriptElement::prepare to match the changed specification. 2016-01-21 11:54:41 +01:00
James Graham
7e8624d921 Update web-platform-tests to revision 0d9238c8062f05a55898a0cb60dc0c353794d87a 2016-01-21 10:28:30 +00:00
bors-servo
c80fa33864 Auto merge of #9391 - nikkisquared:test_redirect, r=jdm
Test redirect_count boundaries in Fetch

I've written two new tests for Fetch: one to test the highest possible number of redirects succeeds; and another to ensure a failure in Fetch by requesting too many redirects. I also wrote a helper function to be used by each test, since the main difference is how many times they try to redirect.

I've also changed the check against redirect_count in http_network fetch to compare it as greater than or equal to 20, as opposed to being only equal to 20. That's outside of the spec, but in my experience testing for pure equality can easily create errors. Even though it's technically not possible for redirect_count be above 20, bizarre bugs during runtime certainly happen.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9391)
<!-- Reviewable:end -->
2016-01-21 02:36:38 +05:30
Nikki
5426df32de tests for boundary conditions on redirect_count in fetch 2016-01-20 13:03:08 -07:00
bors-servo
5b2d2c0ed8 Auto merge of #9381 - MonsieurLanza:htmldetails, r=KiChjang
Implement HTMLDetailsElement. Fixes #9216

Implement the interface HTMLDetailsElement ( // https://html.spec.whatwg.org/multipage/#htmldetailselement )

All tests pass in
tests/wpt/web-platform-tests/html/semantics/interactive-elements/the-details-element/details.html
&
tests/wpt/web-platform-tests/html/semantics/interactive-elements/the-details-element/toggleEvent.html

Anyway, no change is made on layout and attribute open currently has no effect, it just fires a toggle event.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9381)
<!-- Reviewable:end -->
2016-01-20 20:58:36 +05:30
Lanza
cfc3500dbf Implement HTMLDetailsElement. Fixes #9216 2016-01-20 16:15:37 +01:00
Lars Bergstrom
095658e098 Cargo updates and small workqueue change 2016-01-20 08:38:27 -06:00
Vladimir Vukicevic
5b845cbf79 win32: force PATH to be non-unicode on win32, if virtualenv munges it 2016-01-20 08:38:26 -06:00
Vladimir Vukicevic
ee863fde59 win32: mach and build command fixes
- Add SERVO_USE_NIGHTLY_RUST env var to use the latest rust/cargo nightly snapshot
- Fix up looking for cargo binary (in cargo/bin/cargo, not bin/cargo)
- Fix up win32 executable checking (use .exe suffix)
- fix up win32 PATH handling (subprocess must use shell=True for PATH change to be honored)
2016-01-20 08:38:24 -06:00
Vladimir Vukicevic
77aea599c7 win32: look for python.exe and variants on win32 in style/build.rs 2016-01-20 08:38:23 -06:00
Vladimir Vukicevic
5e136d6dd5 win32: make sleep_microseconds for backoff just do a win32 Sleep(0) 2016-01-20 08:38:22 -06:00
Vladimir Vukicevic
025ed57c04 win32: use fontconfig/freetype on windows as well (for now) 2016-01-20 08:38:20 -06:00
bors-servo
6663f28f0d Auto merge of #9358 - jsanders:refactor-websocket-closing, r=jdm
Clean up websocket closing code

Fixes #7860.

This also changes quite a bit about how close codes are implemented, I believe bringing them closer in line with the spec. Instead of saving off the close code sent by the client, it uses the code from the server's closing handshake. It also handles `NO_STATUS` in what I believe is the correct manner. Making this work required a change to the test harness to make the `/echo` websocket handler echo the code sent by the client and handle `NO_STATUS` properly, rather than always replying with `NORMAL`.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9358)
<!-- Reviewable:end -->
2016-01-19 21:08:09 +05:30
bors-servo
77d3fbcca3 Auto merge of #9284 - bholley:bootstrap_stylo, r=SimonSapin
Add Partial Implementation of style DOM traits for Gecko, and some basic glue to let Gecko call into Servo

The wrapper stuff is partially-complete, modulo some unimplemented methods. The glue code is just a toy for now. Regardless, I think it's worth getting some of this stuff in-tree to minimize breakage.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9284)
<!-- Reviewable:end -->
2016-01-19 14:19:10 +05:30
James Sanders
482d23bb19 Fix test-tidy errors 2016-01-18 17:50:25 -07:00
James Sanders
3837b3e508 Update web-platform-tests expected data 2016-01-18 17:50:25 -07:00
James Sanders
d121958a17 Make closing related code more clear and more correct 2016-01-18 17:37:16 -07:00
James Sanders
a640b9aaea Echo close reason and close code
Set code to None if it is STATUS_NO_STATUS_RECEIVED, which should not be
sent across the wire.
2016-01-18 17:37:16 -07:00
bors-servo
175b3c2d27 Auto merge of #9321 - nikkisquared:response_body, r=jdm
Test setting response.body and fetching a message on a server

I've updated http_fetch to now set response.body, as well as written a test to ensure that fetch can retrieve a message on a server. I've also looked into partially implementing some more of http_fetch while trying to figure out where response.body gets written to.

As always I'd like feedback on my logic, I'm confident there are more steps for handling response.body I need but I find the specification difficult to parse on this.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9321)
<!-- Reviewable:end -->
2016-01-19 04:24:09 +05:30
Nikki
4165786767 Test setting response.body by fetching on a server 2016-01-18 15:12:31 -07:00
bors-servo
03a0b73538 Auto merge of #9360 - jsanders:accept-protocols-sequence, r=KiChjang
Accept WebSocket protocols as string or sequence

Fixes #9053

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9360)
<!-- Reviewable:end -->
2016-01-19 02:18:28 +05:30