Commit graph

17006 commits

Author SHA1 Message Date
bors-servo
f1defb446e Auto merge of #10443 - emilio:webgl-teximage2d-overload, r=jdm
webgl: Implement the pending texImage2D overload, and add more validation

This is a large-ish refactor of the Texture2D code, but it should be
easier to read and of course more correct.

I tried to annotate every error condition with a spec paragraph.

I made just a reftest to ensure this works as intended, since I expect #10373 to land pretty soon.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10443)
<!-- Reviewable:end -->
2016-04-22 11:25:29 -07:00
bors-servo
d926b5d376 Auto merge of #10751 - zwn:tidy-start-operator, r=Wafflespeanut
Report lines starting with && in tidy

Partial implementation of the issue #10692 (the easy part).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10751)
<!-- Reviewable:end -->
2016-04-22 10:40:06 -07:00
bors-servo
4da6855e23 Auto merge of #10651 - craftytrickster:10601/current-color, r=Ms2ger
Setting current color to black if canvas is not rendered in document

Fixes #10601

The change seems deceptively easy, I hope I am not missing anything...

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10651)
<!-- Reviewable:end -->
2016-04-22 09:26:51 -07:00
bors-servo
a262c3121f Auto merge of #10807 - jdm:disable_sslfail, r=Wafflespeanut
Disable sslfail.html pending further investigation in #10760.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10807)
<!-- Reviewable:end -->
2016-04-22 08:42:11 -07:00
Josh Matthews
055a852f18 Disable sslfail.html pending further investigation in #10760. 2016-04-22 11:34:23 -04:00
bors-servo
3aae162426 Auto merge of #10803 - servo:css-20160422, r=Ms2ger
Update CSS tests to revision b9c63d615a65c4d96f26969bcd504d4e1c3cdab8

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10803)
<!-- Reviewable:end -->
2016-04-22 07:18:04 -07:00
David Raifaizen
b5159dc7ff Setting current color to black if canvas is not rendered in document 2016-04-22 09:59:49 -04:00
bors-servo
340a25e68c Auto merge of #10729 - fitzgen:unit-tests-for-time-profiler, r=larsbergstrom
Add unit tests skeleton for the time profiler

This commit adds a test crate for the time profiler to `tests/unit/profile`. The
only unit test contained in this crate is a smoke test that the time profiler
thread can be created and destroyed. It serves as a place for adding new tests
in the future.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10729)
<!-- Reviewable:end -->
2016-04-22 06:05:49 -07:00
Zbynek Winkler
39780ca39f Report lines starting with &&. 2016-04-22 14:28:20 +02:00
Zbynek Winkler
924d804583 Move '&&' to the end of the previous line.
Following https://github.com/servo/servo/issues/10692 this is just a
formating change to satisfy a new tidy requirement of not having '&&' at
the beginning of a line.
2016-04-22 14:28:18 +02:00
Zbynek Winkler
01b111c43e Add newline to the output.
The last line of output from tidy did not end with a newline if some
errors were reported.
2016-04-22 14:28:17 +02:00
bors-servo
f2c213fa58 Auto merge of #10754 - Ms2ger:disable-mutation-events, r=nox
Disable tests for mutation events.

We have no intention of implementing them, so there's not much point in
running them.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10754)
<!-- Reviewable:end -->
2016-04-22 05:09:50 -07:00
bors-servo
6f801e3f3f Auto merge of #10758 - jdm:tidy_check_completeness, r=Wafflespeanut
Ensure that we aren't missing any errors in the tidy self-test.

r? @Wafflespeanut

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10758)
<!-- Reviewable:end -->
2016-04-22 02:40:29 -07:00
bors-servo
a89dff95f8 Auto merge of #10802 - servo:webgl, r=Ms2ger
Disable WebGL tests.

They're not stable enough right now, with no expectation of improvement
any time soon.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10802)
<!-- Reviewable:end -->
2016-04-22 01:26:17 -07:00
Ms2ger
4d13f9f5d5 Update CSS tests to revision b9c63d615a65c4d96f26969bcd504d4e1c3cdab8 2016-04-22 10:06:45 +02:00
Ms2ger
64b26e0e78 Disable WebGL tests.
They're not stable enough right now, with no expectation of improvement
any time soon.
2016-04-22 09:57:31 +02:00
bors-servo
0e0e902edd Auto merge of #10727 - jdm:canvas_panic, r=pcwalton
Use DOM width/height for canvas display list item.

Fixes #10705.

r? @glennw

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10727)
<!-- Reviewable:end -->
2016-04-21 20:50:27 -07:00
Josh Matthews
1623114376 Use DOM width/height for canvas display list item. 2016-04-21 23:20:21 -04:00
bors-servo
dff217c2e3 Auto merge of #10723 - edunham:modelines, r=Wafflespeanut
Remove some Emacs & Vim modelines

This might be a bad idea, especially on the webidl side. However, we started talking about the idea that modelines are a lint error (https://github.com/servo/servo/issues/10719), and these changes would be required before enabling a modeline lint.

If it bitrots, it's easy to recreate with
```
find * -type f -exec sed '/- Mode:/d' -i {} +
find * -type f -exec sed '/ vim:/d' -i {} +
git checkout -- python/tidy/servo_tidy/tidy.py
git checkout -- python/tidy/servo_tidy_tests/spec.webidl
git commit -a
```

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10723)
<!-- Reviewable:end -->
2016-04-21 20:05:04 -07:00
bors-servo
b080da474f Auto merge of #10791 - servo:explicit-python-path, r=KiChjang
Blind attempt at fixing a Python import error on Windows.

See #10789.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10791)
<!-- Reviewable:end -->
2016-04-21 17:26:11 -07:00
bors-servo
69acd8e1cc Auto merge of #10774 - perlun:improve-mako-file-structure-v2, r=SimonSapin
Improve properties.mako.rs file structure, take 2

This is a new attempt of #10586, after Simon Sapin's great cleanups in #10749 has landed. I have adjusted the changes to the new structure that was introduced, and also only done a few of the longhand ones. Will certainly continue on this as soon as we have a basic agreement that this style is reasonable.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10774)
<!-- Reviewable:end -->
2016-04-22 02:19:28 +05:30
Per Lundberg
4643737a1b Applied a bunch of suggestions from Simon. 2016-04-21 22:42:35 +03:00
Per Lundberg
d0489f1160 Improve properties.mako.rs file structure, take 2
This is a new attempt of #10586, after Simon Sapin's great cleanups in #10749 has landed. I have adjusted the changes to the new structure that was introduced, and also only done a few of the longhand ones. Will certainly continue on this as soon as we have a basic agreement that this style is reasonable.
2016-04-21 22:42:35 +03:00
bors-servo
98ae238adf Auto merge of #10794 - jdm:disable_10753, r=Wafflespeanut
Disable frequent intermittently-passing tests.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10794)
<!-- Reviewable:end -->
2016-04-22 01:01:08 +05:30
Josh Matthews
4b9fa4621d Disable frequent intermittently-passing tests. 2016-04-21 14:46:17 -04:00
bors-servo
a6fc440125 Auto merge of #10792 - mbrubeck:nonconformist, r=Wafflespeanut
Disable /webgl/conformance-1.0.3/conformance/more/conformance/quickCheckAPI-S_V.html

Because Servo only sometimes crashes on its random data (#10698).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10792)
<!-- Reviewable:end -->
2016-04-21 23:57:32 +05:30
Matt Brubeck
6d3cb13c64 Disable /webgl/conformance-1.0.3/conformance/more/conformance/quickCheckAPI-S_V.html
Because Servo only sometimes crashes on its random data (#10698).
2016-04-21 10:51:07 -07:00
Simon Sapin
ad95a1dd23 Blind attempt at fixing a Python import error on Windows.
See #10789.
2016-04-21 19:46:23 +02:00
bors-servo
1eec5d9f72 Auto merge of #10777 - servo:wpt-20160421, r=Ms2ger
Update web-platform-tests to revision 0a518aaff73532a26e175789f7e75fa99593ac64

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10777)
<!-- Reviewable:end -->
2016-04-21 16:53:18 +05:30
Ms2ger
abcd4b654f Update web-platform-tests to revision 0a518aaff73532a26e175789f7e75fa99593ac64 2016-04-21 12:30:36 +02:00
bors-servo
7e370c4df4 Auto merge of #10710 - Ms2ger:js, r=nox
Update js.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10710)
<!-- Reviewable:end -->
2016-04-21 15:41:44 +05:30
bors-servo
9c172f49d0 Auto merge of #10631 - servo:wptrunner-20160415, r=KiChjang
Update wptrunner.

Fixes #10540.
Fixes #10392.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10631)
<!-- Reviewable:end -->
2016-04-21 13:54:19 +05:30
Ms2ger
5944add496 Note bugs. 2016-04-21 09:45:45 +02:00
Ms2ger
82e2d017ef Update wptrunner. 2016-04-21 09:45:44 +02:00
bors-servo
3bfa4cc741 Auto merge of #10749 - servo:split-mako, r=nox
Prepare related files to make it easier to split up the Mako template

https://github.com/servo/servo/pull/10586#issuecomment-211490049

r? @nox

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10749)
<!-- Reviewable:end -->
2016-04-21 10:38:09 +05:30
bors-servo
46080f31f1 Auto merge of #10766 - jdm:disable_webgl_intermittent, r=emilio
Disable quickCheckAPI-G_I.html until our WebGL APIs deal with random …

…data better. #10656

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10766)
<!-- Reviewable:end -->
2016-04-21 08:37:20 +05:30
Josh Matthews
35636cf43a Disable quickCheckAPI-G_I.html until our WebGL APIs deal with random data better. 2016-04-20 20:05:33 -04:00
bors-servo
75d99eec0f Auto merge of #10661 - DDEFISHER:master, r=jdm
write cookie_jar, hsts_list, auth_cache to file if profile_dir option is present

For Persistent sessions student project

"if the profile directory command-line option is present when the ResourceThread is instructed to exit, serialize the data contained in cookie_storage, hsts_list, and the new HTTP authorization cache, and write the serialized data in separate files inside the profile directory."

and

"perform the same serialization on shutdown for local_data in storage_thread.rs, which represents the LocalStorage API."

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10661)
<!-- Reviewable:end -->
2016-04-21 03:51:56 +05:30
Daniel
d4f63cda5f write cookie_jar, hsts_list, auth_cache, and local_data to file if profile_dir option is present 2016-04-20 18:12:00 -04:00
Emilio Cobos Álvarez
9fff9d45d1
webgl: tests: Update expectations of tests
This tests previously "passed", because they used the texImage2D
overload we're adding now.

Since that overload previously caused a TypeError, these tests were
never run in the first place.
2016-04-20 22:12:39 +02:00
Emilio Cobos Álvarez
764fac781e
webgl: tests: Mark the bufferDataBadArgs test as passing
It now passes consistently.
2016-04-20 21:42:58 +02:00
Emilio Cobos Álvarez
f6f1e37b29
webgl: Fix a few typos in comments 2016-04-20 20:30:05 +02:00
Emilio Cobos Álvarez
d152c7fe88
webgl: texture: Make initialize only mark as initialized the current face
Also refactor a bit the code, and remove the unused `is_initialized`
flag.
2016-04-20 20:27:37 +02:00
Emilio Cobos Álvarez
21e2f97cfa
webgl: Fix filling a non-zero level
You can fill a level > 0 as long as the width and height values are
power of two, so the previous test was bogus.
2016-04-20 20:24:56 +02:00
edunham
7ae63b1213 Remove modelines everywhere but tests/wpt 2016-04-20 10:49:09 -07:00
Josh Matthews
c7d5a2b311 Ensure that we aren't missing any errors in the tidy self-test. 2016-04-20 13:29:39 -04:00
Emilio Cobos Álvarez
1ad7f73caf
webgl: Reset bound buffer when appropiate in BufferData
This makes the test bufferDataBadArgs pass appropiately.
2016-04-20 19:22:05 +02:00
bors-servo
f051028ee8 Auto merge of #9942 - jdm:load_error, r=ms2ger
Moving the error handling out of network loader

Rebase of #8851. Fixes #8678. Fixes #9944.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9942)
<!-- Reviewable:end -->
2016-04-20 22:19:22 +05:30
Josh Matthews
d888ed368d Make new test use local resources only. 2016-04-20 12:38:38 -04:00
Ravi Shankar
16096f1a9c Added 'about:sslfail' and a reftest for SSL failure 2016-04-20 12:38:37 -04:00