servo/components
bors-servo 7cc4165dda
Auto merge of #20868 - tigercosmos:gg1, r=emilio
fix logic in overflow_direction, also add a FIXME

<!-- Please describe your changes on the following line: -->
This PR fix #19477, which the logic is obviously wrong.

However, it is impossible to add a test for this.

Due to #20867, the ` overflow_direction` is a hard code now. It never go to other conditions.
I add a FIXME there, and also add a SPEC link.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #19477(github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20868)
<!-- Reviewable:end -->
2018-05-28 18:50:18 -04:00
..
allocator Revert "Upgrade to rustc 1.27.0-nightly (8a37c75a3 2018-05-02)" 2018-05-18 11:44:47 -05:00
atoms beforeunload and unload infrastructure 2018-05-05 19:14:36 +08:00
bluetooth move top_level_browsing_context_id out of embedder msg 2018-05-23 21:46:05 +08:00
bluetooth_traits Automatically provide a resource reader for tests 2018-04-30 22:19:33 +08:00
canvas Implement most of the unsupported parameters in gl.getParameter() 2018-05-24 12:32:15 +02:00
canvas_traits Implement most of the unsupported parameters in gl.getParameter() 2018-05-24 12:32:15 +02:00
compositing Basic pinch zoom handling 2018-05-24 14:42:46 -07:00
config Automatically provide a resource reader for tests 2018-04-30 22:19:33 +08:00
constellation move top_level_browsing_context_id out of embedder msg 2018-05-23 21:46:05 +08:00
debugger Bump env_logger to 0.5 and log to 0.4 in every servo crate 2018-03-28 19:50:58 +02:00
deny_public_fields Update Webrender 2018-04-25 10:25:21 +02:00
devtools Bump env_logger to 0.5 and log to 0.4 in every servo crate 2018-03-28 19:50:58 +02:00
devtools_traits Bump ipc-channel and bincode 2018-03-21 13:05:47 +01:00
dom_struct Revert "Upgrade to rustc 1.27.0-nightly (8a37c75a3 2018-05-02)" 2018-05-18 11:44:47 -05:00
domobject_derive Update Webrender 2018-04-25 10:25:21 +02:00
embedder_traits send message to embedder in prompt_to_unload 2018-05-23 21:46:05 +08:00
fallible
geometry alias some euclid types 2018-03-16 14:34:29 +08:00
gfx Use std::simd instead of the simd crate 2018-05-24 17:39:38 +02:00
gfx_traits Update WebRender 2018-02-06 15:10:35 +01:00
hashglobe Bump ipc-channel and bincode 2018-03-21 13:05:47 +01:00
jstraceable_derive Update Webrender 2018-04-25 10:25:21 +02:00
layout Auto merge of #20868 - tigercosmos:gg1, r=emilio 2018-05-28 18:50:18 -04:00
layout_thread Automatically provide a resource reader for tests 2018-04-30 22:19:33 +08:00
layout_traits Bump ipc-channel and bincode 2018-03-21 13:05:47 +01:00
malloc_size_of Update to gleam 0.5 2018-05-05 13:08:36 +02:00
malloc_size_of_derive Update Webrender 2018-04-25 10:25:21 +02:00
metrics added spec comments 2018-04-11 21:29:03 +01:00
msg Notify the embedder when it should display or hide an IME 2018-04-21 19:46:42 -07:00
net Auto merge of #20707 - gterzian:embedder_handling_of_prompts_and_alerts_2, r=payl 2018-05-24 10:34:48 -04:00
net_traits move msg to embedder_traits, use in script, handle send error in embedder 2018-05-23 21:45:57 +08:00
nonzero Use new std::num::NonZero* types instead of deprecated core::nonzero::NonZero 2018-04-09 21:43:26 +02:00
profile Bump env_logger to 0.5 and log to 0.4 in every servo crate 2018-03-28 19:50:58 +02:00
profile_traits Measure cache memory usage (#19251): 2018-04-01 13:30:57 -04:00
rand Bump env_logger to 0.5 and log to 0.4 in every servo crate 2018-03-28 19:50:58 +02:00
range
remutex Use new std::num::NonZero* types instead of deprecated core::nonzero::NonZero 2018-04-09 21:43:26 +02:00
script Auto merge of #20837 - gterzian:tests_for_has_event_listener, r=cbrewster 2018-05-28 15:52:31 -04:00
script_layout_interface Add unique canvas IDs to all canvas operations. 2018-04-02 22:02:22 -04:00
script_plugins Revert "Upgrade to rustc 1.27.0-nightly (8a37c75a3 2018-05-02)" 2018-05-18 11:44:47 -05:00
script_traits move msg to embedder_traits, use in script, handle send error in embedder 2018-05-23 21:45:57 +08:00
selectors style: Allow 16% false positives in test bloom::create_and_insert_some_stuff. 2018-05-05 16:22:47 +02:00
servo move top_level_browsing_context_id out of embedder msg 2018-05-23 21:46:05 +08:00
servo_arc style: Fix tidy issues and Servo build. 2018-04-29 05:09:43 +02:00
size_of_test
style style: Appease tidy. 2018-05-28 16:02:31 +02:00
style_derive style: Remove values::Verbatim. 2018-05-05 16:20:38 +02:00
style_traits style: Ensure all lonhands have a working clone(), and to_css. 2018-05-19 10:15:17 +02:00
url Fix building servo_url by itself 2018-04-19 17:01:14 +02:00
webdriver_server Bump env_logger to 0.5 and log to 0.4 in every servo crate 2018-03-28 19:50:58 +02:00
webvr Bump env_logger to 0.5 and log to 0.4 in every servo crate 2018-03-28 19:50:58 +02:00
webvr_traits Bump ipc-channel and bincode 2018-03-21 13:05:47 +01:00