Commit graph

7794 commits

Author SHA1 Message Date
bors-servo
e10cf7adad
Auto merge of #25222 - pshaughn:node_isconnected, r=jdm
adding .isConnected DOM attribute

<!-- Please describe your changes on the following line: -->
is_connected already existed for this concept and just needed to be hooked up to an IDL attribute.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #25126

<!-- Either: -->
- [X] There are tests for these changes OR

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2019-12-11 15:04:45 -05:00
bors-servo
fc97a53a94
Auto merge of #25240 - pshaughn:unspecial_mouseover, r=SimonSapin
Took out the special mouseover cancel case

<!-- Please describe your changes on the following line: -->
eventtarget.rs was checking the event type to see if it was a mouseover; now it doesn't. Other special-case events like error and beforeunload go down other code paths entirely, so this one has no special cases left.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #25190

<!-- Either: -->
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2019-12-11 10:12:52 -05:00
Patrick Shaughnessy
0231a0a712 adding .isConnected DOM attribute 2019-12-11 10:08:05 -05:00
bors-servo
aa268e154f
Auto merge of #25228 - servo-wpt-sync:wpt_update_10-12-2019, r=jdm
Sync WPT with upstream (10-12-2019)

Automated downstream sync of changes from upstream as of 10-12-2019.
[no-wpt-sync]
r? @servo-wpt-sync
2019-12-11 00:17:09 -05:00
Josh Matthews
cf7fb78d65
Remove intermittent failure. 2019-12-10 23:08:21 -05:00
Patrick Shaughnessy
f35a870f55 Took out the special mouseover cancel case 2019-12-10 21:50:47 -05:00
Patrick Shaughnessy
15e5aef631 Workarounds for tests with about:blank onloads (rebased) 2019-12-10 15:52:53 -05:00
bors-servo
6cf618ae9f
Auto merge of #25207 - servo:replaced, r=nox
min/max-width/height, replaced elements
2019-12-10 10:49:17 -05:00
bors-servo
4d5bf653f7
Auto merge of #25217 - pshaughn:fix25150, r=jdm
hidden field named _charset_ now appears in FormData as UTF-8

<!-- Please describe your changes on the following line: -->
HTMLInputElement now has special case logic for putting a hidden field named `_charset_` in an entry set. To support this, the encoding used when constructing a form dataset is now being passed further down the callchain than it was before.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #25150

<!-- Either: -->
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2019-12-10 07:50:27 -05:00
Simon Sapin
b73eb49a58 Add sizing of inline replaced boxes 2019-12-10 12:36:43 +01:00
WPT Sync Bot
20d165ac2c Update web-platform-tests to revision fa41b43ac93bc2fdc2427a4378dc3754d483cdda 2019-12-10 11:06:32 +00:00
bors-servo
52559aad14
Auto merge of #25204 - servo:reftest-analyzer, r=jdm
Link to Gecko’s reftest analyzer

http://hoppipolla.co.uk/410/reftest-analyser-structured.xhtml seems to be gone
2019-12-10 02:40:56 -05:00
bors-servo
03a47c803c
Auto merge of #25201 - xu3u4:25183-add-onformdata-to-global-event-handler, r=jdm
Add onformdata to GlobalEventHandlers

<!-- Please describe your changes on the following line: -->
1. Adding `onformdata` to GlobalEventHandlers interface and global_event_handlers macro.
2. Deleting related FAIL tests.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #25183 (GitHub issue number if applicable)

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2019-12-10 01:30:38 -05:00
bors-servo
ebe432bf58
Auto merge of #25202 - Eijebong:domtokenlist_replace, r=jdm
Return a boolean from DOMTokenList::replace to match the spec

Fixes #25129
2019-12-09 22:26:27 -05:00
Simon Sapin
ef4447ee95 Link to Gecko’s reftest analyzer
http://hoppipolla.co.uk/410/reftest-analyser-structured.xhtml was inaccessible for a while
2019-12-09 21:14:18 +01:00
Patrick Shaughnessy
7f41b1b294 hidden field named _charset_ now appears in FormData as UTF-8 to fix #25150 2019-12-09 12:45:14 -05:00
bors-servo
e8d677ad26
Auto merge of #25158 - jdm:wr-spatial-panic, r=SimonSapin
Fix "Tried to use SpatialId before it was defined" layout panic

In the case where an element uses `text-overflow: ellipsis` and causes overflow, we create a TruncatedFragment that wraps the original overflowing fragment. When collecting stacking contexts for the truncated fragment, https://github.com/servo/servo/pull/18510 addressed the case where the wrapped fragment wouldn't be processed, but neglected the case where that fragment ends up creating a new stacking context. When that happens, the TruncatedFragment would be stuck with the updated scrolling/clipping information based on the new stacking context, but it would be a child of the parent stacking context. Since the new scrolling/clipping nodes do not exist in the display list until the new stacking context display item is created, this led to the observed panic.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24895 and fix #19281 and fix #22826.
- [x] There are tests for these changes
2019-12-09 08:23:10 -05:00
Josh Matthews
6dad51f570 layout: Ensure truncated fragment is updated with results of collecting inner fragment's stacking contexts. 2019-12-09 09:57:48 +01:00
xu3u4
7529591e8f Add onformdata to GlobalEventHandlers 2019-12-07 21:44:36 +09:00
Bastien Orivel
0bdab6bb50 Return a boolean from DOMTokenList::replace to match the spec
Fixes #25129
2019-12-07 13:22:10 +01:00
bors-servo
05922c380c
Auto merge of #25087 - bblanke:OffscreenCanvasasCanvasImageSoure, r=jdm
Support OffscreenCanvas as CanvasImageSource

Added methods to canvas_data to support drawing an offscreen canvas onto another canvas
Bug fix: Swapped OffscreenCanvas width and height parameters to match Mozilla spec
Tests: Updated metadata for 866 tests

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24269 (GitHub issue number if applicable)

<!-- Either: -->
- [x] These changes do not require tests because they are covered by existing tests

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2019-12-05 01:49:58 -05:00
Bailey Blankenship
deae103042 Addresses Issue: Support OffscreenCanvas as CanvasImageSource #24269
Added methods to canvas_data to support drawing an offscreen canvas onto another canvas
Bug fix: Swapped OffscreenCanvas width and height parameters to match Mozilla spec
Tests: Updated metadata for 866 tests
2019-12-04 18:23:28 -05:00
bors-servo
e70397d90a
Auto merge of #25033 - servo:intrinsic, r=nox
Add support for inline-block and for computing min/max-content
2019-12-04 16:23:33 -05:00
WPT Sync Bot
03e574fd3e Update web-platform-tests to revision 54a6679265caf957a1470c2b398a81bd5440dd2f 2019-12-04 14:25:42 +00:00
bors-servo
6e3c131139
Auto merge of #24977 - ridhimrastogi:async-wasm-compilation-final, r=jdm
Add StreamConsumer wrapper and methods to response

<!-- Please describe your changes on the following line: -->
Add Streamconsumer wrapper to Response

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21476
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2019-12-03 17:38:53 -05:00
Ridhim Rastogi
a5469f8710 Add StreamConsumer wrapper and methods to response 2019-12-03 15:59:35 -05:00
bors-servo
d99850ffa8
Auto merge of #24981 - servo:wpt-unexpected, r=jdm
Improve diagnostics for WPT failures

* Include the full output (including stdout/stderr) in the intermittent-filtered log
* Print the intermittent-filtered log at the end of the main log (which is one less click to reach from Taskcluster’s task view, compared to other task artifacts)
* <del>Fail with a specific message when a reftest screenshot is entirely white</del> (This caused over a hundred unexpected results. A few of them in reftests that use `about:blank` as a reference.)
* For failing reftests, add a message if the whole screenshot is a solid color, to help recognize instances of https://github.com/servo/servo/issues/24726

  ```
    ▶ FAIL [expected PASS] /css/CSS2/box-display/root-box-003.xht
    │   → /css/CSS2/box-display/root-box-003.xht 54a9df64f1476dd12020019d7cf22ac34d727bc0
    │   → /css/CSS2/box-display/root-box-003-ref.xht 636eb693bc214b6e1c64e6566c48e69e6777b946
    └   → Screenshot is solid color 0xFFFFFF for /css/CSS2/box-display/root-box-003.xht
  ```
  (The last line is new.)
2019-12-03 14:31:08 -05:00
bors-servo
7ba88e8237
Auto merge of #24626 - glowe:issue-21810/improve-validation-methods, r=jdm
Issue 21810/improve validation methods

<!-- Please describe your changes on the following line: -->
This is a start at addressing #21810. I'm putting these changes out early to get some feedback on the following items:

1. I added unit tests for the validation methods mentioned in #21810, because I couldn't tell whether any of the existing WPT tests covered them. Are these tests worthwhile? Are any of them unnecessary?
2. I changed the implementation for `is_valid_floating_point_number_string` so that it passed the tests. The previous version of the function wasn't restrictive enough (it allowed certain whitespace characters before the number string).
3. I changed the catch-all condition in `htmlinputelement.rs` to account for the remaining input types that don't have a value sanitization algorithm. This last change seems good to me since we won't be able to add a new input type without adding it to the case and checking the spec for an algorithm.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21810

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2019-12-03 13:11:22 -05:00
bors-servo
f31a88d85d
Auto merge of #24885 - shnmorimoto:implement_mediasession_set_positon_state, r=ferjm
Implement mediasession set positon state

<!-- Please describe your changes on the following line: -->

fix #24808

> Bonus points if you want to tweak the existing UI by adding a progress bar, and the info about the current position and total duration.

I haven't implemented this yet.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24808 (GitHub issue number if applicable)

<!-- Either: -->
- [x] There are tests for these changes OR

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2019-12-03 12:13:06 -05:00
Simon Sapin
f0b970d90d Add a test counter in WPT’s non-interactive output 2019-12-03 17:03:53 +01:00
Simon Sapin
8dc703f1df wptrunner: detect solid color screenshots for failing reftests
The output looks like this:

```
  ▶ FAIL [expected PASS] /css/CSS2/box-display/root-box-003.xht
  │   → /css/CSS2/box-display/root-box-003.xht 54a9df64f1476dd12020019d7cf22ac34d727bc0
  │   → /css/CSS2/box-display/root-box-003-ref.xht 636eb693bc214b6e1c64e6566c48e69e6777b946
  └   → Screenshot is solid color 0xFFFFFF for /css/CSS2/box-display/root-box-003.xht
```
2019-12-03 17:03:53 +01:00
Simon Sapin
40ce8c7105 Improve formatting of multi-line "message" in Servo’s WPT log formatter 2019-12-03 16:49:23 +01:00
Simon Sapin
0ac021c1a5 Include test output in filtered WPT logs 2019-12-03 16:49:23 +01:00
Simon Sapin
46f0f7d7e2 Implement shrink-to-fit for abspos 2019-12-03 15:11:35 +01:00
WPT Sync Bot
3214f9ea94 Update web-platform-tests to revision 0317e9a8591851f97d59c9de28c46ea1c2a25f88 2019-12-03 14:09:06 +00:00
glowe
b9ec6f99cd Remove redundant domstring unit test
This test is no longer necessary since the cases tested are also tested
by the number input web platform test.
2019-12-02 22:52:02 -05:00
glowe
b8a8c2b9bf Enhance wpt for number input
Add cases for all leading ASCII whitespace characters.
2019-12-02 22:50:13 -05:00
bors-servo
87c1019c5d
Auto merge of #24940 - Eijebong:trim-header, r=jdm
Trim header values in GetResponseHeader

Fixes #24917
2019-12-02 17:47:24 -05:00
Shinichi Morimoto
3e83b0bd25 updated tests for mediasession 2019-12-03 07:39:04 +09:00
WPT Sync Bot
d02774e688 Update web-platform-tests to revision ff11f93316527e37ec580adca01a9cf0a58a297e 2019-12-02 14:41:01 +00:00
bors-servo
6cd42bdcfb
Auto merge of #24980 - servo-wpt-sync:wpt_update_01-12-2019, r=servo-wpt-sync
Sync WPT with upstream (01-12-2019)

Automated downstream sync of changes from upstream as of 01-12-2019.
[no-wpt-sync]
r? @servo-wpt-sync
2019-12-02 01:07:08 -05:00
bors-servo
40fd7910a5
Auto merge of #24928 - servo:2020-images, r=SimonSapin
Start supporting images in layout 2020
2019-12-01 09:53:45 -05:00
WPT Sync Bot
f170d55d3e Update web-platform-tests to revision 5df56b25e1cb81f81fe16c88be839f9fd538b41e 2019-12-01 14:26:32 +00:00
Anthony Ramine
5a360ac63d Start supporting images in layout 2020 2019-12-01 10:56:33 +01:00
Anthony Ramine
ecfb82260c Fix an unimplemented in layout 2020 2019-12-01 10:51:19 +01:00
glowe
576f51f598 Add DOMString floating point string test and fix
Fixes an issue where DOMString::is_valid_floating_point_number_string
was returning true for strings that began with whitespace characters-
TAB, LF, FF, or CR. Also added a unit test to cover this since the
corresponding web-platform-tests are incomplete.
2019-11-30 23:29:09 -05:00
Emilio Cobos Álvarez
6712e316df
style: Update wpt expectations.
transform-scale-percent-001.html has been updated upstream, as the test is
invalid per CSSWG resolution.
2019-11-30 22:09:59 +01:00
Emilio Cobos Álvarez
f8e924f86a
style: Don't specify minor version for cssparser. 2019-11-30 20:45:06 +01:00
Bastien Orivel
a91176e7fc Trim header values in GetResponseHeader
Fixes #24917
2019-11-30 16:59:10 +01:00
WPT Sync Bot
dc71e05859 Update web-platform-tests to revision 3503c50a6452e153bde906a9c6644cb6237224fc 2019-11-30 14:25:22 +00:00